From: Alexey Dobriyan <adobriyan@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, mingo@elte.hu,
linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/asm] x86, 64-bit: ifdef out struct thread_struct::ip
Date: Mon, 11 May 2009 21:22:09 +0400 [thread overview]
Message-ID: <b6fcc0a0905111022g1df0b1c5l95c2a072745578a0@mail.gmail.com> (raw)
In-Reply-To: <20090511160324.GA7923@infradead.org>
On Mon, May 11, 2009 at 8:03 PM, Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, May 11, 2009 at 03:09:40PM +0000, tip-bot for Alexey Dobriyan wrote:
>> +#ifdef CONFIG_X86_32
>> unsigned long ip;
>> +#endif
>> #ifdef CONFIG_X86_64
>> unsigned long fs;
>> #endif
>
> What happened to the good old concept of #if #else #endif?
#else suggests alternative which is not the case.
->ip and ->fs can be in different parts of thread_struct.
next prev parent reply other threads:[~2009-05-11 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-03 23:30 [PATCH] x86_64: " Alexey Dobriyan
2009-05-11 15:09 ` [tip:x86/asm] x86, 64-bit: " tip-bot for Alexey Dobriyan
2009-05-11 16:03 ` Christoph Hellwig
2009-05-11 17:22 ` Alexey Dobriyan [this message]
2009-05-11 17:25 ` Robert P. J. Day
2009-05-11 19:27 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6fcc0a0905111022g1df0b1c5l95c2a072745578a0@mail.gmail.com \
--to=adobriyan@gmail.com \
--cc=hch@infradead.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®