From: Alexey Dobriyan <adobriyan@gmail.com>
To: monstr@monstr.eu
Cc: linux-kernel@vger.kernel.org, michal.simek@petalogix.com,
arnd@arndb.de, linux-arch@vger.kernel.org,
fujita.tomonori@lab.ntt.co.jp, akpm@linux-foundation.org,
mingo@elte.hu, joerg.roedel@amd.com
Subject: Re: [PATCH] asm-generic: dma: Add BUG_ON for uninitialized dma_ops
Date: Wed, 20 Jan 2010 12:48:17 +0200 [thread overview]
Message-ID: <b6fcc0a1001200248x1a4b3cedoae90b4f1495d2358@mail.gmail.com> (raw)
In-Reply-To: <1263982111-24123-2-git-send-email-monstr@monstr.eu>
On Wed, Jan 20, 2010 at 12:08 PM, <monstr@monstr.eu> wrote:
> From: Michal Simek <monstr@monstr.eu>
>
> Check that dma_ops are initialized correctly. Without this
> checking you get kernel fault and you don't know where the problem is.
Oh, yes you do. PC will be of some small value.
> + BUG_ON(!ops);
> BUG_ON(!valid_dma_direction(dir));
> addr = ops->map_page(dev, virt_to_page(ptr),
next prev parent reply other threads:[~2010-01-20 10:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 10:08 Generic DMA - BUG_ON monstr
2010-01-20 10:08 ` [PATCH] asm-generic: dma: Add BUG_ON for uninitialized dma_ops monstr
2010-01-20 10:48 ` Alexey Dobriyan [this message]
2010-01-20 11:00 ` Geert Uytterhoeven
2010-01-20 10:56 ` Joerg Roedel
2010-01-22 1:11 ` FUJITA Tomonori
2010-01-20 10:53 ` Generic DMA - BUG_ON Russell King
2010-01-20 11:00 ` Joerg Roedel
2010-01-20 11:18 ` Michal Simek
2010-01-20 19:03 ` Arnd Bergmann
2010-01-21 15:51 ` Steven J. Magnani
2010-01-21 17:53 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6fcc0a1001200248x1a4b3cedoae90b4f1495d2358@mail.gmail.com \
--to=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=joerg.roedel@amd.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@petalogix.com \
--cc=mingo@elte.hu \
--cc=monstr@monstr.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®