From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752326AbdLGXIn (ORCPT <rfc822;w@1wt.eu>);
        Thu, 7 Dec 2017 18:08:43 -0500
Received: from lelnx193.ext.ti.com ([198.47.27.77]:20214 "EHLO
        lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750931AbdLGXIm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 7 Dec 2017 18:08:42 -0500
Subject: Re: [PATCH v2 1/6] dt: bindings: lp8860: Update bindings for lp8860
To: Rob Herring <robh@kernel.org>
CC: <mark.rutland@arm.com>, <rpurdie@rpsys.net>,
        <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>,
        <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-leds@vger.kernel.org>
References: <20171205204327.12111-1-dmurphy@ti.com>
 <20171205204327.12111-2-dmurphy@ti.com>
 <20171207224347.hrqwygbm2xb7lzbs@rob-hp-laptop>
From: Dan Murphy <dmurphy@ti.com>
Message-ID: <b707d097-496a-1dbd-5872-003d24c3c31f@ti.com>
Date: Thu, 7 Dec 2017 17:08:23 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.5.0
MIME-Version: 1.0
In-Reply-To: <20171207224347.hrqwygbm2xb7lzbs@rob-hp-laptop>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Rob
On 12/07/2017 04:43 PM, Rob Herring wrote:
> On Tue, Dec 05, 2017 at 02:43:22PM -0600, Dan Murphy wrote:
>> Update the lp8860 bindings to fix various issues
>> found.  Add address-cells and size-cells, rename
>> enable-gpio to enable-gpios, update the node name
>> to the device name and indent the node example.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
>> ---
>>
>> v2 - New patch
>>
>>  .../devicetree/bindings/leds/leds-lp8860.txt       | 28 ++++++++++++----------
>>  1 file changed, 16 insertions(+), 12 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/leds/leds-lp8860.txt b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> index aad38dd94d4b..1b2fab05ec6a 100644
>> --- a/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> +++ b/Documentation/devicetree/bindings/leds/leds-lp8860.txt
>> @@ -6,24 +6,28 @@ current sinks that can be controlled by a PWM input
>>  signal, a SPI/I2C master, or both.
>>  
>>  Required properties:
>> -	- compatible:
>> +	- compatible :
>>  		"ti,lp8860"
>> -	- reg -  I2C slave address
>> -	- label - Used for naming LEDs
>> +	- reg : I2C slave address
>> +	- label : Used for naming LEDs
>> +	- #address-cells : 1
>> +	- #size-cells : 0
> 
> This should be added in the next patch when you have child nodes.
> 

Ack

> Rob
> 


-- 
------------------
Dan Murphy