From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D14A2381B00 for ; Mon, 13 Apr 2026 08:25:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776068759; cv=none; b=LyHfi2qmodov4ZVe51Y7l4phHNcdUThBg05EeP2MPmg52lycfiQarC2zZj/Luy3dQypOu6i1LZpwuka1r91JERsO1CnvqUVSeOUSSPW5Lzn8IJyMQx0z7nFw8VQCsul8F2HQU2P9bAvNlPEaJZESg2j4C+3gkyIrRWIf1AozvHM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776068759; c=relaxed/simple; bh=WbaClpuiijaEJZhRB9Dc8DeF1n892C6setvc/IZwtMM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FkIeA0h9Dlj5rsjQSq/9Dh6N8+ay6njgQeDEdM/E/Lbfx1y9C03uNwQmSwSeUe4LfOHjLzqFmLPz6DBLImc2WBRFbLxEUzxbuq75ibsfwk/l7QNPuQz5JTeUVGGjcGDI7mFAoPwSjQuDCMkNUTZdvNgvX0YVTP6w2Ugr+Fhhr9E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eC2Zia/R; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ZgCObfj4; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eC2Zia/R"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ZgCObfj4" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63D6wt7Z260858 for ; Mon, 13 Apr 2026 08:25:56 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 7+fqw4fN0pTXLVOUOmnDw72S91boPNMgI00B4oKchFo=; b=eC2Zia/RNQk/1CJb 7vKS95WJIoiYeUbj1v5MURU9ILPsfopYXjCuYJ5itFAPBLQRzh/2uXzlT8byOkp8 Cs7eoEpH7tyGzE8EuceyxrY41VM24F/oDUHDYhjHTnmXhxNIsvEQVOIC88izi4ew WCYbU7qYfCw2bN16SSiGb870LffLbFYtXnMJrm9k980eybLQfWxm9tYMQ0jlJjs4 OC78Nnz17bH19BEw62XToHoDhIuVPw2/eNwoKjX6/UrISq1J7QO3Ai0M6qoGG4ah Dgh2lXWTwFjeCglKCv+x0f9fHXAeNotPFj+lnnf63gpJejZngq8XHCBZs5sFCbXE kiW06A== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dfew04eqe-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 13 Apr 2026 08:25:55 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50d840206c3so6430341cf.3 for ; Mon, 13 Apr 2026 01:25:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776068755; x=1776673555; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=7+fqw4fN0pTXLVOUOmnDw72S91boPNMgI00B4oKchFo=; b=ZgCObfj4wZQWp08sYMowTSLIB43d3iLSQARUnecMC+d8roCEaralFG9q8izcsp101/ 9s1TWjyhBz03+hZghL0dIYDfd5Cwm+9Bc56569WNUebAGGl0aJETm77KoP6BZHXe06bb 0XqbexRH62MYtN//oElbbGP04AqrSm69GGydQl8GvgNQOOQZugLDhVVOU24aJsbRcy62 OddHKghF0n55p0mfDLw6VlSJ4OvLbnCuJVQtimELOpxFGAtdVyIKKEk5Hm/jENEPSrDj O13DygkG/uaQmVL4DJHhtTB+WwM1+PXWTLX00whW5mOF7CMFriVqlrIiUpv9nDwzN033 KXLw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776068755; x=1776673555; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7+fqw4fN0pTXLVOUOmnDw72S91boPNMgI00B4oKchFo=; b=InjEGPuMMfZWpt6dWfKlAeUIGDGE7T4QJJlDm9O55tzJYUFhI8aimVUqbmk4u0hEUG /t24zREAuvCP0Ibd256TW/y6nu4b7DcNSuEQQpUg1u/niyRumY5iZGKZskf9snFXW/ob c0TMW2VeQe94PLMgwerUwlhEN0mpWEsIh8bkdpDzJNtFUPZfICPCnOv6TMeIPSVxsdKT cfhCs2fTBNosefTk8UMIO19KlmA+kubsYQC1Z1Ku/v/OqoPSGVJuZK7exIL3cLIlF3nv M4rBIqNMyCTDhlew0saUNmY2vyw7KVfnDIHRR5SEZnHHrl2KQ3zk/QtWcDchmkubUfHH IoFw== X-Forwarded-Encrypted: i=1; AFNElJ9RwnGZGgszDDMXitqSESzio0LftvDuS0XuMS0DPxPHV5QQ6ouQamb/l/IxGctkypK5kJATGq/d7FVFMRs=@vger.kernel.org X-Gm-Message-State: AOJu0Yx1nDuvwgqnciDDtgibN405S3u3Et1XpGZk7zHg4Oqlqq8bV6hE 18gnD5Zp07eGKjjg0d7xgdvzCj19hgHpq7QheZzcwvth9+W5cGqiGdwRfNyvVWdbzf130MOeFg5 lVgFTFkAbWa63m/2Wdg3NDftvE89OnC0+6TB585iVgg6kUSwoNoVUO54QbJMnwCF7Be4= X-Gm-Gg: AeBDietLzv3wjLds91Bu4FVSqDroydKnhYMPauCEO/3WwKAhAbInZFjKkL4YhrOvM6Q h2ibaQxaAbyORuEpZZBu2X9W0u2zVsI1kwchZjz/3IOjSg/xpBrl+jGA3Wl41ymKK0L/8OfBwEL Wqjv6oFIrGsPpm+HalUg2dDkFiXf5OTZ7qSC0SNQTVPT+XyzMc9+Zq/gbTa79OuV3Tj8Fl0DAjv nQJ9Dle5XPSOmOK3s07qjLPE8/3PK0FXPg1H7zTWckSWGbCLbKsiHnnrdVl/dXAJFIqgGIISXxJ 5ihUjyo8OnQVbA6O+TM10CB+b+b0/ary3NKrqxa4/J1YkMfCbHg4ByWP2VPF1MSWkH1MJp9PcsS V1/4flLnmGK95JANtbKN/1V6bAQZXUoO8Dd5/dr6sf5mOngtUW4lPyfrFFBXA51eLBeNjJtg1NQ Wfy4o= X-Received: by 2002:ac8:7d90:0:b0:509:1057:4a67 with SMTP id d75a77b69052e-50dd7ccf4f5mr134206501cf.2.1776068755239; Mon, 13 Apr 2026 01:25:55 -0700 (PDT) X-Received: by 2002:ac8:7d90:0:b0:509:1057:4a67 with SMTP id d75a77b69052e-50dd7ccf4f5mr134206261cf.2.1776068754884; Mon, 13 Apr 2026 01:25:54 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6708d902086sm2137057a12.1.2026.04.13.01.25.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Apr 2026 01:25:54 -0700 (PDT) Message-ID: Date: Mon, 13 Apr 2026 10:25:51 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 06/35] irqchip/qcom-pdc: Use FIELD_GET() to extract bank index and bit position To: Mukesh Ojha , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio Cc: cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <20260410184124.1068210-1-mukesh.ojha@oss.qualcomm.com> <20260410184124.1068210-7-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260410184124.1068210-7-mukesh.ojha@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDEzMDA4MSBTYWx0ZWRfX9scu1BMSr35N sDlhI8bmGLh6g3EQ8ET7hdvhKA7sK3AMiCGRs/ekzEtbNkruFnUeHWtW/yf43A0PcGGDPQV+Eqi g5kDzqCeGsKQZ3qz6v5dM3Oe4oBTgWAYkpA4Z2q1+l4y6jdm556RD9xMYa37e3xnSKZ6VOJYMTy 3SLTB2c32MMUU9F1dCIbSIRIUuI4vPw++kPXEyySjX8J+I1WNkB0kXrUUBxAmnaQS8pXuwaWlDT COMU6V5j1GzpFZXSGtnlmaqw2S4U3qOuTBZAwonDL0INFnCakvm9coTyeqS0IAKNkAJoJHCUOcN FdxXgpdYQETSE2ST8xXABCTIORSYaRh72dwpvgc7JRIZAFaX45f4CQYU6NgkPEzDQePlmlBHSWU nJknXfeZp7fqN9xchzJQ5DY4JoF+rOOzhvuH0fg16VAN/NQC0WtCEJ+d95QZgy0r5R1ZoqlEuGV VN2Krx8lB1O4PQfbAgQ== X-Proofpoint-GUID: RuBcHHhudRKJPpLEz9-paI_21ad2ukrP X-Authority-Analysis: v=2.4 cv=AofeGu9P c=1 sm=1 tr=0 ts=69dca893 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=yx91gb_oNiZeI1HMLzn7:22 a=EUspDBNiAAAA:8 a=GoGuyCN6GRDGdbe8FcUA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-ORIG-GUID: RuBcHHhudRKJPpLEz9-paI_21ad2ukrP X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-13_02,2026-04-09_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 bulkscore=0 adultscore=0 phishscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 suspectscore=0 malwarescore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604010000 definitions=main-2604130081 On 4/10/26 8:40 PM, Mukesh Ojha wrote: > The IRQ_ENABLE_BANK register is a bank of 32-bit words where each bit > represents one PDC pin. The bank index and bit position within the bank > are encoded in the flat pin number as bits [31:5] and [4:0] respectively. > > Replace the open-coded division and modulo with FIELD_GET() and GENMASK() > to make the bit extraction self-documenting and consistent with the > FIELD_PREP() style already used in the PDC_VERSION() macro. > > Signed-off-by: Mukesh Ojha > --- Reviewed-by: Konrad Dybcio Konrad