From: "Mikhail Kshevetskiy" <mikhail.kshevetskiy@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Option to disable AMD C1E (allows dynticks to work)
Date: Fri, 14 Dec 2007 03:14:14 +0300 [thread overview]
Message-ID: <b70f2f960712131614u7515f0fcxf17d9791eb33c5eb@mail.gmail.com> (raw)
Hello Eduard-Gabriel,
You write:
> + dynamic ticks to work. It's safe to enable this option even if
> + your system doesn't have an AMD CPU (there are no side-effects if
> + such a CPU isn't detected).
It's definitely not safe. There are the computers with totally broken
BIOSes, they setup C1e flags for one core only. If you try to disable
C1e on such machine, you most likely kill the kernel.
>From my point of view, you patch should work in both directions, i.e.
1) user should be allowed to force disable C1e for all cores.
2) user should be allowed to force enable C1e for both cores.
and if the user don't use this flag, the C1e state should be untouched.
Mikhail Kshevetskiy
next reply other threads:[~2007-12-14 0:14 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-14 0:14 Mikhail Kshevetskiy [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-12-29 14:43 David P. Reed
2007-12-29 22:28 ` Islam Amer
2007-12-30 0:35 ` Islam Amer
2007-12-30 12:57 ` Ingo Molnar
2007-12-30 1:38 ` Rene Herman
2007-12-30 1:49 ` Islam Amer
2007-12-30 3:24 ` Rene Herman
2007-12-30 10:17 ` Eduard-Gabriel Munteanu
2007-12-30 14:42 ` Andi Kleen
2007-12-30 21:12 ` Eduard-Gabriel Munteanu
2007-12-31 2:34 ` Andi Kleen
2007-12-30 20:57 ` Richard Harman
2007-12-30 21:18 ` Eduard-Gabriel Munteanu
2007-12-30 13:36 ` Richard Harman
2007-12-30 23:32 ` Eduard-Gabriel Munteanu
2007-12-31 0:30 ` David P. Reed
[not found] <47754735.1050009@richardharman.com>
2007-12-29 7:52 ` Eduard-Gabriel Munteanu
2007-12-29 9:09 ` Richard Harman
2007-12-29 11:19 ` Eduard-Gabriel Munteanu
2007-12-29 11:46 ` Islam Amer
2007-12-30 20:45 ` Rene Herman
2007-12-13 22:47 Eduard-Gabriel Munteanu
2007-12-13 22:58 ` Johannes Weiner
2007-12-14 12:48 ` Eduard-Gabriel Munteanu
2007-12-18 15:43 ` Pavel Machek
2007-12-18 17:11 ` Eduard-Gabriel Munteanu
2007-12-13 22:44 Eduard-Gabriel Munteanu
2007-12-13 22:33 ` Andi Kleen
2007-12-14 12:39 ` Eduard-Gabriel Munteanu
2007-12-14 10:17 ` Andi Kleen
2007-12-14 13:41 ` Eduard-Gabriel Munteanu
2007-12-14 12:20 ` Andi Kleen
2007-12-14 16:01 ` Eduard-Gabriel Munteanu
2007-12-14 18:07 ` Thomas Gleixner
2007-12-14 18:12 ` Andi Kleen
2007-12-14 19:57 ` Thomas Gleixner
2007-12-14 20:06 ` Andi Kleen
2007-12-14 19:58 ` Eduard-Gabriel Munteanu
2007-12-14 18:10 ` Andi Kleen
2007-12-14 19:53 ` Thomas Gleixner
2007-12-14 22:35 ` Chuck Ebbert
2007-12-15 0:10 ` Eduard-Gabriel Munteanu
2007-12-15 12:41 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b70f2f960712131614u7515f0fcxf17d9791eb33c5eb@mail.gmail.com \
--to=mikhail.kshevetskiy@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®