From: Mark Brown <broonie@kernel.org>
To: Niranjan H Y <niranjan.hy@ti.com>
Cc: linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org,
ckeepax@opensource.cirrus.com, lgirdwood@gmail.com,
perex@perex.cz, tiwai@suse.com, cezary.rojewski@intel.com,
peter.ujfalusi@linux.intel.com, yung-chuan.liao@linux.intel.com,
kai.vehmanen@linux.intel.com, pierre-louis.bossart@linux.dev,
baojun.xu@ti.com, shenghao-ding@ti.com, sandeepk@ti.com,
v-hampiholi@ti.com
Subject: Re: [PATCH v1 1/2] ASoC: tac5xx2-sdw: update default regmap registers
Date: Wed, 19 Aug 2026 14:46:30 +0100 [thread overview]
Message-ID: <b714ed66-e722-461b-8cce-8535a14acc75@sirena.org.uk> (raw)
In-Reply-To: <20260819053427.2277-1-niranjan.hy@ti.com>
[-- Attachment #1: Type: text/plain, Size: 803 bytes --]
On Wed, Aug 19, 2026 at 11:04:26AM +0530, Niranjan H Y wrote:
> + /* SA */
> + {TAC_VOLUME_REG(SA, FU21, LEFT), 0x9c00},
> + {TAC_VOLUME_REG(SA, FU21, RIGHT), 0x9c00},
> + {TAC_GAIN_REG(SA, FU23, LEFT), 0x0},
> + {TAC_GAIN_REG(SA, FU23, RIGHT), 0x0},
> + {TAC_MUTE_REG(SA, FU21, LEFT), 0x1},
> + {TAC_MUTE_REG(SA, FU21, RIGHT), 0x1},
> + {TAC_MUTE_REG(SA, FU23, LEFT), 0x1},
> + {TAC_MUTE_REG(SA, FU23, RIGHT), 0x1},
Did you check the sorting of the table here?
> - REG_SEQ0(SDW_SDCA_CTL(TAC_FUNCTION_ID_SA, TAC_SDCA_ENT_FU23,
> - TAC_SDCA_CHANNEL_GAIN, TAC_CHANNEL_LEFT), 0),
> - REG_SEQ0(SDW_SDCA_CTL(TAC_FUNCTION_ID_SA, TAC_SDCA_ENT_FU23,
> - TAC_SDCA_CHANNEL_GAIN, TAC_CHANNEL_RIGHT), 0),
The new macros use _CHANEL_VOLUME and _MASTER_GAIN, there's none using
_CHANNEL_GAIN?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2026-08-19 13:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-19 5:34 Niranjan H Y
2026-08-19 5:34 ` [PATCH v1 2/2] ASoC: sdw_utils: add spk component string for tac5xx2 family Niranjan H Y
2026-08-19 13:50 ` Mark Brown
2026-08-19 13:46 ` Mark Brown [this message]
2026-08-20 5:06 ` [PATCH v1 1/2] ASoC: tac5xx2-sdw: update default regmap registers Holalu Yogendra, Niranjan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b714ed66-e722-461b-8cce-8535a14acc75@sirena.org.uk \
--to=broonie@kernel.org \
--cc=baojun.xu@ti.com \
--cc=cezary.rojewski@intel.com \
--cc=ckeepax@opensource.cirrus.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=niranjan.hy@ti.com \
--cc=perex@perex.cz \
--cc=peter.ujfalusi@linux.intel.com \
--cc=pierre-louis.bossart@linux.dev \
--cc=sandeepk@ti.com \
--cc=shenghao-ding@ti.com \
--cc=tiwai@suse.com \
--cc=v-hampiholi@ti.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®