From: Markus Elfring <Markus.Elfring@web.de>
To: Anand Moon <linux.amoon@gmail.com>,
linux-omap@vger.kernel.org, linux-pci@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Bjorn Helgaas" <bhelgaas@google.com>,
"Dan Carpenter" <dan.carpenter@linaro.org>,
"Krzysztof Wilczyński" <kwilczynski@kernel.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Manivannan Sadhasivam" <mani@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Siddharth Vadapalli" <s-vadapalli@ti.com>,
"Vignesh Raghavendra" <vigneshr@ti.com>
Subject: Re: [v3 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable
Date: Tue, 28 Oct 2025 08:33:44 +0100 [thread overview]
Message-ID: <b715fd29-3e83-4087-951d-4a6ed803c272@web.de> (raw)
In-Reply-To: <CANAwSgT43rsi+DxaMF3T-gsVoAAGSSDEL6s+TE2yZ+q+W3bRsQ@mail.gmail.com>
>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc3#n94
>>
> Assign the result of devm_gpiod_get_optional() directly to pcie->reset_gpio.
a … call?
> This removes a superfluous local variable, improving code clarity without
Thus remove? . Improve?
> altering the driver's behavior.
…
Regards,
Markus
prev parent reply other threads:[~2025-10-28 7:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-27 9:03 [PATCH v3 0/2] PCI: j721e: A couple of cleanups Anand Moon
2025-10-27 9:03 ` [PATCH v3 1/2] PCI: j721e: Use devm_clk_get_optional_enabled() to get the clock Anand Moon
2025-10-27 13:39 ` Siddharth Vadapalli
2025-10-27 9:03 ` [PATCH v3 2/2] PCI: j721e: Use inline reset GPIO assignment and drop local variable Anand Moon
2025-10-27 13:43 ` Markus Elfring
2025-10-28 7:06 ` Anand Moon
2025-10-28 7:33 ` Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b715fd29-3e83-4087-951d-4a6ed803c272@web.de \
--to=markus.elfring@web.de \
--cc=bhelgaas@google.com \
--cc=dan.carpenter@linaro.org \
--cc=kwilczynski@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux.amoon@gmail.com \
--cc=lpieralisi@kernel.org \
--cc=mani@kernel.org \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®