From: Chaitanya Kulkarni <chaitanyak@nvidia.com>
To: Jeff Johnson <quic_jjohnson@quicinc.com>, Jens Axboe <axboe@kernel.dk>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH 0/3] block: m68k: add missing MODULE_DESCRIPTION() macros
Date: Tue, 18 Jun 2024 05:04:17 +0000 [thread overview]
Message-ID: <b71c63e5-5ee3-4d20-8923-a8d57ace48e4@nvidia.com> (raw)
In-Reply-To: <20240617-md-m68k-drivers-block-v1-0-b200599a315e@quicinc.com>
On 6/17/24 18:13, Jeff Johnson wrote:
> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/amiflop.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ataflop.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/z2ram.o
>
> Since these have traditionally had different commit prefixes, I
> submitted individual patches. Let me know if you want me to squash
> them.
>
> In addition, drivers/block/swim3.c is also missing a
> MODULE_DESCRIPTION(), but I haven't yet actually triggered the
> warning. I need to customize a PPC configuration which enables
> MAC_FLOPPY in order to trigger the warning and verify the fix.
>
> I'll get around to that when I finish the remaining m68k issues.
>
> ---
> Jeff Johnson (3):
> amiflop: add missing MODULE_DESCRIPTION() macro
> ataflop: add missing MODULE_DESCRIPTION() macro
> z2ram: add missing MODULE_DESCRIPTION() macro
>
> drivers/block/amiflop.c | 1 +
> drivers/block/ataflop.c | 1 +
> drivers/block/z2ram.c | 1 +
> 3 files changed, 3 insertions(+)
> ---
> base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
> change-id: 20240617-md-m68k-drivers-block-46c301b46f49
>
>
For the series, looks good ...
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
-ck
next prev parent reply other threads:[~2024-06-18 5:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-18 1:13 Jeff Johnson
2024-06-18 1:13 ` [PATCH 1/3] amiflop: add missing MODULE_DESCRIPTION() macro Jeff Johnson
2024-06-18 7:41 ` Geert Uytterhoeven
2024-06-18 1:13 ` [PATCH 2/3] ataflop: " Jeff Johnson
2024-06-18 7:40 ` Geert Uytterhoeven
2024-06-18 1:13 ` [PATCH 3/3] z2ram: " Jeff Johnson
2024-06-18 7:41 ` Geert Uytterhoeven
2024-06-18 5:04 ` Chaitanya Kulkarni [this message]
2024-06-19 13:54 ` [PATCH 0/3] block: m68k: add missing MODULE_DESCRIPTION() macros Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b71c63e5-5ee3-4d20-8923-a8d57ace48e4@nvidia.com \
--to=chaitanyak@nvidia.com \
--cc=axboe@kernel.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®