From: Johannes Berg <johannes@sipsolutions.net>
To: Wentao Liang <vulab@iscas.ac.cn>,
ajay.kathat@microchip.com, claudiu.beznea@tuxon.dev,
kvalo@kernel.org
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH v3] wifi: wilc1000: Add error handling for wilc_sdio_cmd52()
Date: Tue, 08 Jul 2025 13:45:02 +0200 [thread overview]
Message-ID: <b71db1e03da50e161b898a763bd01f6a1c8ce3e2.camel@sipsolutions.net> (raw)
In-Reply-To: <20250519084211.1752-1-vulab@iscas.ac.cn>
On Mon, 2025-05-19 at 16:42 +0800, Wentao Liang wrote:
> The wilc_sdio_read_size() calls wilc_sdio_cmd52() but does not check the
> return value. This could lead to execution with potentially invalid data
> if wilc_sdio_cmd52() fails. A proper implementation can be found in
> wilc_sdio_read_reg().
>
> Add error handling for wilc_sdio_cmd52(). If wilc_sdio_cmd52() fails,
> log an error message via dev_err().
That's clearly hno longer true, please submit consistent patches.
Also, this change (at best!) addresses half the problem, please fix it
fully if you want to bother us with it at all.
johannes
prev parent reply other threads:[~2025-07-08 11:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-19 8:42 Wentao Liang
2025-07-08 11:45 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b71db1e03da50e161b898a763bd01f6a1c8ce3e2.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ajay.kathat@microchip.com \
--cc=claudiu.beznea@tuxon.dev \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®