From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 49EA73446C0 for ; Fri, 15 May 2026 12:22:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778847740; cv=none; b=js9Ypnh+pGpTYANLfum2G8XyVG3T9nKkVb6B5S3TPa+lJXWks8cdrZTqSmXgI+hZXoowqqa4EHQEz0XZIpH1vllWhmU4kmohVbzud+ukzDUXvgXT/OqfedBdN7pZFuqjR372ha1yBSDshFqkBqCihf8cY7mD3ZpH3PwTo8sdNJo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778847740; c=relaxed/simple; bh=cSbgwQsIMiL4r+c9TFJSvgPFeEAMxUXwZf80tWnw+EA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WGwv44Uvh05ps6ObuZ0dAt858cr/+VwmIBUooSBbfblak3RmkpPP70n3paXVED3AovCUyX2+1BFtSSuVYAy0ZZE/tvDKyCw/ArAkAg5194AWs60oc6xF4NnSugac4cN665PecQgD0xqcrvf5NAQ6dTTUujMBOTAanlQV2GMA1ac= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=UXHSf4Cm; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=SxxMA6qG; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="UXHSf4Cm"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="SxxMA6qG" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 64FB0LMf2676263 for ; Fri, 15 May 2026 12:22:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= X3CKBojgLIxLibEaJ8g467kLwm5xL6u1aVmhYP8EbH4=; b=UXHSf4Cm5cKa15Wg FCJv8H33r5CHEEvaoW3BEGGjYsMG0DwJ0317XBxPW1wONjByVR/znbBMc5lPardv fmgwpDUqUXDH7c6rm+K8i2KAeC+cevc9sJih5QYpFkeiP8sQ7L+s2Q/DiwtFo8pr L5RTp2sXj9CIvQrocyOdd+z8hj88snyr1Lcd3u3ZY7ILyM5Vod5H+Y0vLBwBqSS/ A/hi/jkZLeHCI9z5Nk2yMabC4UWkE6ln524+qkggDpfH4/klDc0jeIHdVfTS3fYM su8TerxT/GNaBLeXsSHUEcHW04zK7zE3edC0buujR1cfK/saFgcNShbYaMUQpQ8z 5BsDMg== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4e5m1vu7gr-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 15 May 2026 12:22:18 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8b58ab2c657so27603936d6.3 for ; Fri, 15 May 2026 05:22:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1778847738; x=1779452538; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X3CKBojgLIxLibEaJ8g467kLwm5xL6u1aVmhYP8EbH4=; b=SxxMA6qGqnM79FU6xGkre8MzRl/b6huGd0/uUphAJCVrCO5+9/8oNEDFvMSBJR+HMe x4pGR5hLX09hmb4SwR+9pcX0YpAwJCTeStuCLUylarXAn4+2rtzMoasi8xLeLHT7GEr+ 7UKT6sSGkVE2aqb+dunr8x38YxAABwIV2EfALa+IriEDQCU03SFs9+SslffeYKCQEeTa qpzNAseCikQrgr/5iN+a1wuj2ycnlVUykU0umGd1ssjgNo+cQxxgT7+VyEp/y5IMiyZv 4UqMtAeb0IMZcnW3TCbyixNpeuDuv0aXY/+GtxIUHpqd/k2Mji0dJsDrp4jAIgD9CHmX xL/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778847738; x=1779452538; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=X3CKBojgLIxLibEaJ8g467kLwm5xL6u1aVmhYP8EbH4=; b=o7KpUueYVuIRpZl+bjjxhCGAVe7t61PSdG5LVaaviNEhPLrSUhViEHaW14PKS3S4/0 7lETzuyO5huUZJgt8xYfsm12tadNT0rdWX3sdvt7KPXm16Msfvgaybf4r/0Rzw3TgucJ A0i2hfdrPv2dAbPBap4E0jy3g8tkrGqi/sPZuNU2DxlKHoN+64YbCiDw/XV/mmrYo2Hx w5ETWuYGK0xbtw3tPZv8Kiy6kM/NjwQt/fZemoyn7IneAGXiZV2f8hvYNBwuokRSsMN9 X3S4eoAieWXHSeDGmW8Phwl21IgwPnnBVWiuAsBeJ8X/suFOcCuY7xwgggGJMK4NnUXJ ESIQ== X-Forwarded-Encrypted: i=1; AFNElJ/sz/sDOdGFM4dPwrYnejEPrCwtUZ1k71JGxdoYAi7JlDNkMcbJNfeNsDx8uMEjM6MbeVp9vp4nJZQYTYs=@vger.kernel.org X-Gm-Message-State: AOJu0YyTU0M7Nk3AUVQMl7g4unFfDQc2IqN/pE1wlobaMvGdbNmkkweH fuDR1sv7ycoRmdiLtf5L1yQCXYaMETN+j2nC2XwPV8gkStuzfXm1GsbVEB2MsmfyasADTVTWJlt qWdbIZm/c6JhsJvueGlkvzQmjE/Dqgmabno8xI57Vdir/wsTBvKhcQ7Ke4zqEFurNggc= X-Gm-Gg: Acq92OFfwLjZm2L65eFQ6l8jcrir75aXGyV6sjq9XxDXD1tH04GH5ZXzECJ4SzQ5mQE qYRu1WHaO02DvDNmla0c1Fsp7XaY7TCkR2OXIVxVf3+gCNAOawr/yskRjx+wP7a09Y6bZXw4jnS b4OiNuBK2dLANLJ3J+jV3+4b2DSbJnQHrpPfBOK+jE775Ux+ytIJS1TbYZg15/pMNzEK23DYB/H 9uOcXJwiF1PpNyb1Ce5tN75Sc6Kpu4DZMknTtLjOYnebrQgFDsHcNhyzXRTyrxEb0DUHzTTOwX/ Zs/Op2cbbuWi3Zsgu8J8ugdrJLjfQwz4btKCXzBOj1eXqU85orDNZKSi300CXbPE8slPvV5S2vW X36sRG4B8xjTOglgetqL7j/PfoyCcKQrEt+oXtFfuMIroi8aosNmgef8ySCM7GJI2YGeVgyyCxE bJS6o= X-Received: by 2002:ac8:7dc4:0:b0:510:144a:636 with SMTP id d75a77b69052e-5165a22eb4emr32714911cf.8.1778847737572; Fri, 15 May 2026 05:22:17 -0700 (PDT) X-Received: by 2002:ac8:7dc4:0:b0:510:144a:636 with SMTP id d75a77b69052e-5165a22eb4emr32714571cf.8.1778847737129; Fri, 15 May 2026 05:22:17 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6834ba6af5dsm1677738a12.14.2026.05.15.05.22.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 15 May 2026 05:22:15 -0700 (PDT) Message-ID: Date: Fri, 15 May 2026 14:22:12 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] arm64: dts: qcom: arduino-monza: add WLAN enable and rfkill GPIO To: Qian Zhang , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Dmitry Baryshkov , Bartosz Golaszewski , Manivannan Sadhasivam Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260511-linux-next-v3-1-3e22737e71eb@oss.qualcomm.com> <920223a6-4e4a-4ebc-8a1c-c37d0923a470@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=PKE/P/qC c=1 sm=1 tr=0 ts=6a070ffa cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=NGcC8JguVDcA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=EUspDBNiAAAA:8 a=DHS6kQ4Rh5SRIDjE-IkA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNTE1MDEyNCBTYWx0ZWRfX0St2UtzlXi1z m/MClZMhOcJvhDGspsgdptL6X10CDDiHWNj+PyLOnDZm1LiRj3jy9O3rXNpUHkUiyzlZ4+jdYvz YKrZ9jVmna4QzGAOa/061RVjDLCLFpirddDEO3oJ5z1YiCAluQz8Cj54iDofeVsmvA1tysxv8yr utIASa6ZUIHzE198+A413mGWnXZBf9SwupFkg0nmMewlUkGpcDPUb7WocqDcGIOtjd7emMYqp3C 8BumZq+RbhtONWc1l7X9AY9H0le1+eND9r1vwcbyJ+Jxj8xHyOR0Sotlw32BKVvT2CVWtQ1HkdF s/iacxJZqJy1rw5EGeqG76vmFxUtN1UseUO3KtQjbaK6m8qMf8lTyndNF7DfgqZk7SOih/zVrTV r91SvSQe+L5/i2SbujrpJ27gkZQiIRs9x9GVvsyRMzjvE9CFhLAo+RzLwdhDbBml+SM/NKfUnn6 8/xBEj+mbLU7QqsMl7w== X-Proofpoint-ORIG-GUID: A_4Rwj3UDj9oGBPbaxgwBEWH3nxY9hwp X-Proofpoint-GUID: A_4Rwj3UDj9oGBPbaxgwBEWH3nxY9hwp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-05-15_03,2026-05-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 adultscore=0 malwarescore=0 bulkscore=0 priorityscore=1501 phishscore=0 clxscore=1015 impostorscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2605130000 definitions=main-2605150124 On 5/15/26 2:08 PM, Qian Zhang wrote: > > > On 5/15/2026 6:51 PM, Konrad Dybcio wrote: >> On 5/11/26 10:48 AM, Qian Zhang via B4 Relay wrote: >>> From: Qian Zhang >>> >>> The QCNFA765 M.2 PCIe WLAN module requires GPIO56 (wlan_en) to be >> >> But isn't that just the wlan-en pin that the power sequencing driver >> takes? >> >> ref: drivers/power/sequencing/pwrseq-qcom-wcn.c >> >> Konrad > Thanks for the review. > It's not the same pin functionally, though they share the same name. There are two key differences: > > > Different power topology: The pwrseq-qcom-wcn.c driver targets WLAN > hips powered by an on-board PMU via the power sequencing framework. In our case (VENTUNO Q), the WLAN module has its own internal PMU, and wlan_en controls the power-on/off of that internal PMU — it is not part of the board-level power sequencing. I don't believe what you said about the pwrseq driver is true. > PCIe probe ordering: The WLAN module connects to the PCIe root complex through a PCIe bridge that does not currently support hotplug. If we were to use a similar node configuration as in pwrseq-qcom-wcn.c, there is no guarantee that the WLAN module would be powered on before the PCIe root complex probes, which would cause enumeration failure. What do you mean by "*currently* does not support hotplug"? Does that depend on some more code changes? Konrad