mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, mail@timurcelik.de
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tun: fix blocking read
Date: Mon, 25 Feb 2019 07:53:08 -0800	[thread overview]
Message-ID: <b727b3bb-ec46-12bf-dd38-0363c9ca5854@gmail.com> (raw)
In-Reply-To: <20190224.221236.905722532971991928.davem@davemloft.net>



On 02/24/2019 10:12 PM, David Miller wrote:
> From: Timur Celik <mail@timurcelik.de>
> Date: Sat, 23 Feb 2019 12:53:13 +0100
> 
>> This patch moves setting of the current state into the loop. Otherwise
>> the task may end up in a busy wait loop if none of the break conditions
>> are met.
>>
>> Signed-off-by: Timur Celik <mail@timurcelik.de>
> 
> Applied and queued up for -stable, thanks.
> 

First part of the patch was matching the changelog, however
the second change was not really needed, or should have used 

__set_current_state(TASK_RUNNING);


  reply	other threads:[~2019-02-25 15:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-23 11:53 Timur Celik
2019-02-25  6:12 ` David Miller
2019-02-25 15:53   ` Eric Dumazet [this message]
2019-02-25 18:25     ` David Miller
2019-02-25 20:12       ` Timur Celik
2019-02-25 20:13       ` [PATCH] tun: remove unnecessary memory barrier Timur Celik
2019-02-25 20:15         ` Eric Dumazet
2019-02-25 22:28         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b727b3bb-ec46-12bf-dd38-0363c9ca5854@gmail.com \
    --to=eric.dumazet@gmail.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mail@timurcelik.de \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome