mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Qais Yousef <qais.yousef@arm.com>,
	luca abeni <luca.abeni@santannapisa.it>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Daniel Bristot de Oliveira <bristot@redhat.com>,
	Wei Wang <wvw@google.com>, Quentin Perret <qperret@google.com>,
	Alessio Balsini <balsini@google.com>,
	Pavan Kondeti <pkondeti@codeaurora.org>,
	Patrick Bellasi <patrick.bellasi@matbug.net>,
	Morten Rasmussen <morten.rasmussen@arm.com>,
	Valentin Schneider <valentin.schneider@arm.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] sched/deadline: Implement fallback mechanism for !fit case
Date: Thu, 9 Apr 2020 20:43:14 +0200	[thread overview]
Message-ID: <b72f72c1-6043-c44f-31f5-fb4137bd5d52@arm.com> (raw)
In-Reply-To: <20200409145359.y276yeikn7dp6jmx@e107158-lin.cambridge.arm.com>

On 09.04.20 16:55, Qais Yousef wrote:
> Hi Luca
> 
> On 04/09/20 15:00, luca abeni wrote:

[...]

>> There is already a tunable for the SCHED_DEADLINE admission test
>> (/proc/sys/kernel/sched_rt_{runtime,period}_us, if I understand well
>> what you are suggesting). The problem is that it is not easy to find a
>> value for this tunable that guarantees the hard respect of all
>> deadlines.
> 
> I don't think it's similar to what I was referring to. But my knowledge about
> DL could have failed me to fully appreciate what you're saying.
> 
> This tunable for RT prevents a single task from using 100% CPU time. I think
> DL uses it in a similar manner.
> 
> What I meant by overcommiting, is allowing more DL tasks than the system can
> guarantee to meet their deadlines.
> 
> For example, in the context of capacity awareness, if you have 2 big cores, but
> 4 DL tasks request a bandwidth that can only be satisfied by the big cores,
> then 2 of them will miss their deadlines (almost) consistently, IIUC.

__dl_overflow() now uses

    X = cap_scale(dl_b->bw, rd_capacity(cpu)) instead of X = cpus

in

    dl_b->bw * X < dl_b->total_bw - old_bw + new_bw;


As an example, Arm64 Hikey64 with 4 LITTLE and 4 big CPUs uses now
(4x462 + 4x1024)/1024 = 5944/1024 ~ 5,80 instead of 8 CPUs.

On mainline, the rt-app tests:

"tasks" : {
 "thread0" : {
  "policy" : "SCHED_DEADLINE",
  "instance" : 8,
  "timer" : {"ref" : "unique0", "period" : 16000, "mode" : "absolute" },
  "run" : 10000,
  "dl-runtime" :11000,
  "dl-period" : 16000,
  "dl-deadline" : 16000
  }
}

is admitted on this board whereas with the patchset some of the tasks
are rejected:

[rt-app] <crit> [7] sched_setattr returned -1
sched_setattr: failed to set deadline attributes: Device or resource busy

---

IMHO, one of the 3 places where DL Admission Control hooks into is:

    __sched_setscheduler -> sched_dl_overflow() ->__dl_overflow()

[...]

  reply	other threads:[~2020-04-09 18:43 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-08  9:50 [PATCH 0/4] Capacity awareness for SCHED_DEADLINE Dietmar Eggemann
2020-04-08  9:50 ` [PATCH 1/4] sched/topology: Store root domain CPU capacity sum Dietmar Eggemann
2020-04-08 12:29   ` Vincent Guittot
2020-04-08 16:30     ` Dietmar Eggemann
2020-04-08 17:03       ` Vincent Guittot
2020-04-09 13:50         ` Dietmar Eggemann
2020-04-09 14:13           ` Vincent Guittot
2020-04-14  9:20             ` Dietmar Eggemann
2020-04-14 12:45         ` Quentin Perret
2020-04-14 15:27           ` Dietmar Eggemann
2020-04-14 15:43             ` Vincent Guittot
2020-04-08  9:50 ` [PATCH 2/4] sched/deadline: Improve admission control for asymmetric CPU capacities Dietmar Eggemann
2020-04-08 10:42   ` Valentin Schneider
2020-04-08 12:26     ` Dietmar Eggemann
2020-04-08 13:30     ` luca abeni
2020-04-08 14:23       ` Qais Yousef
2020-04-08 15:01       ` Valentin Schneider
2020-04-09 17:29         ` Dietmar Eggemann
2020-04-14 11:40           ` Qais Yousef
2020-04-14 14:29             ` Valentin Schneider
2020-04-14 15:41               ` Qais Yousef
2020-04-14 14:28           ` Valentin Schneider
2020-04-17 12:19           ` Juri Lelli
2020-04-17 14:55             ` Dietmar Eggemann
2020-04-17 15:08               ` Juri Lelli
2020-04-17 15:47                 ` Juri Lelli
2020-04-08  9:50 ` [PATCH 3/4] sched/deadline: Make DL capacity-aware Dietmar Eggemann
2020-04-10 12:52   ` Juri Lelli
2020-04-15  9:39     ` Dietmar Eggemann
2020-04-15 13:20       ` Juri Lelli
2020-04-15 16:42         ` luca abeni
2020-04-16 13:19           ` Juri Lelli
2020-04-08  9:50 ` [PATCH 4/4] sched/deadline: Implement fallback mechanism for !fit case Dietmar Eggemann
2020-04-09 10:25   ` Qais Yousef
2020-04-09 13:00     ` luca abeni
2020-04-09 14:55       ` Qais Yousef
2020-04-09 18:43         ` Dietmar Eggemann [this message]
2020-04-14 11:29           ` Qais Yousef

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b72f72c1-6043-c44f-31f5-fb4137bd5d52@arm.com \
    --to=dietmar.eggemann@arm.com \
    --cc=balsini@google.com \
    --cc=bristot@redhat.com \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luca.abeni@santannapisa.it \
    --cc=mingo@redhat.com \
    --cc=morten.rasmussen@arm.com \
    --cc=patrick.bellasi@matbug.net \
    --cc=peterz@infradead.org \
    --cc=pkondeti@codeaurora.org \
    --cc=qais.yousef@arm.com \
    --cc=qperret@google.com \
    --cc=rostedt@goodmis.org \
    --cc=valentin.schneider@arm.com \
    --cc=vincent.guittot@linaro.org \
    --cc=wvw@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®