From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BE708337BA6 for ; Fri, 13 Mar 2026 14:14:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773411242; cv=none; b=ErUKpiFl+WwOizfUlqvRT6mRdMKhM+/BYWfCmKXa3ntT95ADZgWg4ta6Kl6BXhicBphdc55f05GhjPgMuguS/lBHkd5zxkdXqzJ9gSpt0BrPXsj525h2FsReNfnoYdauGqTb+fxBxdFe5z1LlCQYvfCaq9mN54m/rnb3cWRPkY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773411242; c=relaxed/simple; bh=2Ax6mEoBmIIINq7jKCbWHwBPcWYjG4Z6TEjYdt9ZADA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Keyy+udc58FgGSReQ3s7SLLfhRqNv60qLr1T+OOqXWgrM/cYhL2yc6F5gJDaDfrUlYhnY16NOz8xaLMUZIfQGAFp+eeh6RM3dt1YI9A5L2719Tgl//gtELw+Q3WKvM517Ie2v+62tkieaDvnjZ90QbVXkn1xP0sD5dPc97CY7m8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=dmOXagPF; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=frwlslwm; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="dmOXagPF"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="frwlslwm" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62DCtQXX3230023 for ; Fri, 13 Mar 2026 14:14:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6MkXKrmgHZEgqEUoaPglu+nEPsg2SnNw3eYI/5+7A20=; b=dmOXagPFgDc19zEQ I1ngbGcpsA/rJ3dxQEUqfQBGXf6KBmN8+/BQpNkn1RMkkguWcDF2UIUITYySjm4R TgJcDKkqBT7KbJz02P+SYgE119LxFikSH9C3z8FDpGGuZjs9lqN2Stg3OrpH2XxE UVklkl1aE1HQmd7Jc6XIw++fFs+uzwDfGPhrI8SLF3G7cpFoZ2wk5EF+0BhJhbk8 6ar9FEVOw27OVbhPMd2Chwk8rmQr0ZwjNR9fQlHNOzgFgEwlHHoMSCtrdTStVk1D 6uCsiSil4CaJGGpQMcwZ1Nk2mUR0PIGxH5xCsBLOBiuInsG8gAyDSjbMB1d4I28+ sYmonA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cv8n7jfyg-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 13 Mar 2026 14:14:01 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2ae50463ba8so171560125ad.0 for ; Fri, 13 Mar 2026 07:14:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773411240; x=1774016040; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=6MkXKrmgHZEgqEUoaPglu+nEPsg2SnNw3eYI/5+7A20=; b=frwlslwm3ZlR0nJ/INtWnYB8PLFnX8NUWMoK7/4vjDmZTbgC7HYzY6O0onR7UwTk3b VOYLE4uAfLmsoTfBv0m08QahdE4BAFM8KblysNaIchc4i0IyUXUwf3lZfE9juOMo4iR1 CwO21XZ3QGIOaJiCOMzqZEfwQxCtE5UMIewq6YBcuc1isJ59PsYtMkUr6YonAC30e2Cu qgA8WQAbjhIYydQ7cpAcEbjS/RSRTAwod8vPSo4s2EWx8DmTaSVqkmI2kVP5SfhugvFE +Oy5Cu537kdIvKc/KGIzBMa7nUzknjEmIhibDq5A9bVCAL7tNiAhbk1lmGe4p5RcCpkc sCtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773411240; x=1774016040; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6MkXKrmgHZEgqEUoaPglu+nEPsg2SnNw3eYI/5+7A20=; b=T62IF8EwfIZfIsoYBjX2BBG8A2uwVKeWY8FogkIp0Olx1qv47Y7gUyCcC+XV/jyDtp wW5783dvYkEagYKIFtBNBnuZRTNz/WwFnhZZTU4UCo0e5vxCK16LKqS63JQQkCPjoG3c Q4B94R/bqY2tLxAsy7Wn4MgqXTj4iPzzO+7jh+z6T1g/zGpxivZLFINfmAF/VzFQtmaZ 4CKi/hU/tlFS3ycTayo6wDAKs48Q7R2fDlnfW3OhiZj1KzXkh79K1LDjYQBztEg7kJZ+ CCoUXZHgnLDPoJl8hpUJ2eSMwzmoUfwhtA+KMgtzNG9+ah9agQNHKSTUOWSahUFdmMKv ZbRw== X-Forwarded-Encrypted: i=1; AJvYcCUzsh3fNpm9uEJOURQMpv6oTECxK8HmL55vHZKRKjq//9c3Lh919AUVZvtOmFrh0zyctznkFO93b67ET44=@vger.kernel.org X-Gm-Message-State: AOJu0YxSY3O3PMgLSDHco4H1LhgX9ghZaorquPVM8sbRMeQWixQxk37Y F/pOhLAtiRY4kfoOmosWnAwygAt/x8wxr/4Oo6lXQPHD5Z47cUN56m165nWTHOMY5orgoyxXcld 3AZM/o/cnees+/rRZdERY15iETVol/TgfjqsGdMlU9rW5TkvX6ju6dv5zN0+Fi6rGWgg= X-Gm-Gg: ATEYQzw0VmDKQP02wZ5qN0EqlvtulrWao8SWpKTj5VwLFiVzSAjUNz2QdrY2RNG+J0D xe+LrZntcaF19gx3nKXAkyljAlM5bC6BNvLHnHEhoYDEaVhM3tJcU3rgENWohsaH2gLxD8yvfVk fhj8fN8qKQyIDTCcqoniKftPTqm6nNSOOL9w2+GBKus3NsbegWo5pC2lxTRt21by9osbTRLLyEa 2kz43zlPPmxrJ86I27aggI/H8Q9aqmlFIFt+c71i2vP/At1KKb2obtBOhn4INlSTvkY3K4RUYIW SPur9+A2vIEzjVNqBbTpdjES89b8mf2NUcy6p7BesXHFcnWp7jdk5s/iWW+wEkEh672Dps4pSJO 4Az5Cq8yZEEJlsT8qM+/Imz3y2zvPjD4ebSnAL/p33+0= X-Received: by 2002:a17:902:ffce:b0:2ae:d3fb:bc08 with SMTP id d9443c01a7336-2aed3fbbe29mr12260815ad.26.1773411240331; Fri, 13 Mar 2026 07:14:00 -0700 (PDT) X-Received: by 2002:a17:902:ffce:b0:2ae:d3fb:bc08 with SMTP id d9443c01a7336-2aed3fbbe29mr12260555ad.26.1773411239885; Fri, 13 Mar 2026 07:13:59 -0700 (PDT) Received: from [192.168.1.8] ([101.0.62.124]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2aece56c2b9sm30155405ad.18.2026.03.13.07.13.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 13 Mar 2026 07:13:59 -0700 (PDT) Message-ID: Date: Fri, 13 Mar 2026 19:43:54 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 2/5] platform: arm64: Add driver for EC found on Qualcomm reference devices To: Bryan O'Donoghue , Sibi Sankar , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bjorn Andersson , Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org, Maya Matuszczyk References: <20260313-v04-add-driver-for-ec-v4-0-ca9d0efd62aa@oss.qualcomm.com> <20260313-v04-add-driver-for-ec-v4-2-ca9d0efd62aa@oss.qualcomm.com> <9241da21-6b02-434d-a746-6bccc25a335d@linaro.org> Content-Language: en-US From: Anvesh Jain P In-Reply-To: <9241da21-6b02-434d-a746-6bccc25a335d@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Proofpoint-ORIG-GUID: 6Ml15BOrpcinRfK8uWx53kytwRJbEcIN X-Proofpoint-GUID: 6Ml15BOrpcinRfK8uWx53kytwRJbEcIN X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzEzMDExMyBTYWx0ZWRfX8oaXpOnXl+Rx gPakWK6Rj4Fu2Km5CwXj0HR61ZnnUGrN50ifSCO0pureaigTUvWQxjJrfxHMfwfPfkH+iaVdIGJ IzOLIF64o6KT0sOfjEFfWlV6Vks6yZK1JbD4Aimj7nWMI4HXcsZDptmWXc0nFol/ZVt/DWxHl1w JKPjTZKoq9qPUEEpm1o6nglcYWTtJMMa6yTU99cDTESbQXaXRWJKCBLliQFnltRESIwOjEzgn5V +IC4T6dcZmG+xUNUnWjhYkXMR3TNx5SHngR9OXIfYA5Hsq/BM6kdZWeBNW2w94XzE+iN3KJ3gTJ +QICbatieiLHy75clKSM6Nxvta8gyCNNMMI9aQTP1lMmfh7sOwGWNlkziNYAsqYye7t/aCv9qel T7in8RLoXibC9Pl9WcPwQhkF/l2l27Nmxx3UsLwpuzAqWOXke9C9Kp5ms1jWMeKdHrvbi5FJ+lJ SNZdPAUlaP9P8WlfQuw== X-Authority-Analysis: v=2.4 cv=CpCys34D c=1 sm=1 tr=0 ts=69b41ba9 cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=EhmMhbG5NVnfTD3xWHIiWQ==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=kLZw7Tj2Bp1Qn3bclxgA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-13_02,2026-03-13_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 spamscore=0 priorityscore=1501 adultscore=0 suspectscore=0 bulkscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603130113 On 3/13/2026 5:47 PM, Bryan O'Donoghue wrote: > On 13/03/2026 10:29, Anvesh Jain P wrote: >> + * Read Response: >> + * >> ---------------------------------------------------------------------- >> + * | Offset    | Name        | Description                | >> + * >> ---------------------------------------------------------------------- >> + * | 0x00    | Byte count    | Number of bytes in response        | >> + * |        |        | (exluding byte count)            | > > Great to see this documented in the code. > > Please run checkpatch and take heed of what it says. > > 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch has no > obvious style problems and is ready for submission. > 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch:184: > exluding ==> excluding, exuding > 0002-platform-arm64-Add-driver-for-EC-found-on-Qualcomm-r.patch:224: > exluding ==> excluding, exuding > total: 0 errors, 0 warnings, 0 checks, 28 lines checked Thanks for the review! Confirmed the typo — will fix both occurrences in the next revision of the patch series. > > --- > bod Best regards, Anvesh