From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S938900AbcIYHpm (ORCPT <rfc822;w@1wt.eu>);
        Sun, 25 Sep 2016 03:45:42 -0400
Received: from mout.web.de ([212.227.15.14]:51788 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751633AbcIYHpk (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 25 Sep 2016 03:45:40 -0400
Subject: Re: [PATCH v2 3/3] Input-gameport: Replace some printk() calls by
 pr_info() in joydump_connect()
To: Joe Perches <joe@perches.com>
References: <d8da8333-d83a-ca61-b887-7fd7528c63a4@users.sourceforge.net>
 <f486d64d-0759-9cd6-1e4e-df723acb6fea@users.sourceforge.net>
 <1474733610.23838.2.camel@perches.com>
 <814f7993-de4b-05d8-845e-3f0230122061@users.sourceforge.net>
 <1474788689.2238.3.camel@perches.com>
Cc: linux-input@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org,
        Julia Lawall <julia.lawall@lip6.fr>
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <b735e40a-4fd2-fcc5-0c55-357ba1e4360f@users.sourceforge.net>
Date: Sun, 25 Sep 2016 09:45:30 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <1474788689.2238.3.camel@perches.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:u1R1if692OSunatm4iMHW6/aRCm0mJ+a8r/XakAImnjmktkbIFq
 Si+4q8FUpuqj2PB8Qp83uv7F+jW1wMIr0se+paD5uFjf4hY7gC/R9fPmhy6VZ0SgQEVvIiw
 n9gy9OzJiqjQiv5FJzAi5hqy8pZ064NM3BG3rFfEf31iKLXlyossYAJwB0XNzMtNDpJyIQB
 3DyZCziDHnF6ZzNYuhlLA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:irdCUz39nEU=:163/P+yRqDo2E1hwNkyAOg
 WDE6czLISC1g3HrhBY2OzElXGtytQQ1IsADYt3548JfVPcV7N2Ul5BBrrFKhRhQGm0/ZwX64D
 0NJJyxfLOl+u1fCBJyUOE3H84y4Ew1YGG9GPR+GRjHquv4VXZTKxwbvkyN9NkWuFL5ZbY5KBO
 9KiYmgjN7vHXQq9kH5+tnpjG4XvnJda+FFLy+ID0jW84pnj5qVmoUs/GA2LbzyrajzRep1WJv
 xiiQ1GBMlkncxQ0SobHpHo6at7QEmxxJxtuy+8LTVkJJFrMR+nk2v6twQTkHS0FiSi1EltPAQ
 ym1b2JNzntbXxz8uy5FpdBjLp1sb/zyy0z0TeVGKbQpqVZwzTsnmh7GfiAXowYlxSmlUrIHSR
 eRO7ZyJLOszAEFzPP9QXb1Sjm/UiQmfNLzy4LlOIik1UfAl1ET65fqHtdjvc5TEY5hJGaK0ZL
 ZtQyAIRX93edsrk6wCxd79jMTGBpehuTN0hg+NjNuVyt4Y8WJEbgYQmA1e9H/fOSvwkpCT9Wp
 wd7CQG5To2mfh4oHIIgaVggYsoV4MgNfPfm0VgMSmwHk4ShJCVC3t/UZarKOnQ9Ay7g85ieXG
 Ja1V7uUx9gDU4o05G4fXUj7KYPLXcfoWlPj2TlPwm/VLCqj2pvxtIptbtKy7Zt2tV0CDBwJ9L
 tAtftvBnTXL4VQwvt/bzbjl20kUXy1I07JgknubKT4bUEPh33QQuSpI8jpVIb/6eIHazNee5b
 OsdqqlIophxwocshhf3mtEXJUAf5cOokFBiaXCma7YHlzF1KPYGIzwWGmT/I83Y0N/LI9Y1tr
 mUsxOu5
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> This is not a good change as it messes with dmesg timestamps.

Thanks for your quick feedback.

Have you got any more concerns around multi-line text output?


> Simpler to read and more straightforward is multiple
> individual function calls.

Will it become feasible to pass the desired data also only
by one logging call directly?

Regards,
Markus