From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A75D33B19B9 for ; Thu, 7 May 2026 08:54:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778144091; cv=none; b=uklXwGgH6oc/NbU+5Kp/h/oaWOTl1Ocp3b3IJTlo90i9D3Orv1Pz0CuWFJRt9Xd2WBD/YMyIOaayj3x0Im0/WtACyACw+P5r4OkPX+mvWmdnzhVvs1p4azKWoikkoRygBee3kWa3k1bYjBx6Wd6/FJMqzhCO2qnP4ybP1gUY9IQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778144091; c=relaxed/simple; bh=xb6ZiBwLsP6jdQI3LJVb4v/501VM5gzJU50dn0+gU+k=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=i2oCGwJeb9vb8PurKwzZPbbTZnWTcLC/EF0Fki30dBHYJP9I4ALuOf51u7j73+QJS2TxFCAOsvYhu+wOc5jwSLP7epV2LrX+un56JaAgvWayXOPO224DzR/X8/GwjD+3VthEwov/0Ipu25WzdzhQ/ykV8x0Je/sb1UZFzr7DH5I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=DMUO1+7y; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=L9Ux6+0H; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="DMUO1+7y"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="L9Ux6+0H" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778144077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Cf5Hiy8Ry8GA3Jd9aF9Qx8+o0rODNaBHOnWLQ2WctSg=; b=DMUO1+7yvuvt36bs5BG8MUG+r049TDMdkONeL4XDNZxzZqCmVfN7FYtf1goOfrwX8keY5p CaJSHHBMV9vM9wwvN4hXxVO/iEvp6wHKfTcTeGwLVLweSYThHLvyP0iDryr1fAEZgAY/mf 4Cr8ysxcXepNL2AzVMC6OxQpDrDLpGE= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-550-Py0xEGHwNKiKeSjhkGmfTA-1; Thu, 07 May 2026 04:54:36 -0400 X-MC-Unique: Py0xEGHwNKiKeSjhkGmfTA-1 X-Mimecast-MFC-AGG-ID: Py0xEGHwNKiKeSjhkGmfTA_1778144075 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-48e5df296aeso3190235e9.1 for ; Thu, 07 May 2026 01:54:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778144075; x=1778748875; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Cf5Hiy8Ry8GA3Jd9aF9Qx8+o0rODNaBHOnWLQ2WctSg=; b=L9Ux6+0Ht5CdORY8beTbWj1Cb+2+S8TCcWboY8UyuxSGRn76je4gnHQwo8u28oxIup MWWpqdDIIy2XslNfsX+LI4FotkPNO3raF2y97VNBsFq7G3TziU5p3opaqhdwEAso8W61 emzhD1aQ2dfobYmpP4hhIEZZuneVDRQ8RpbE3mCodDWAzhQjOHiFgqX5SCS4gv2YQ56X sP19lyPo/aW9AcKr504ogvDXeINXwnXypDk75/dByNSubr9Z8eZI2SS+oSETP6tWiUJ+ hsRDDloXPeCdJMRjrgfAOcX2aXREVfrnxY3QmB8IRpCAamfe4jWWrkQ69jDUWA9bz2G2 Fd2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778144075; x=1778748875; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Cf5Hiy8Ry8GA3Jd9aF9Qx8+o0rODNaBHOnWLQ2WctSg=; b=aD232RZJW6m4n9TI/DpiNUWjZXtgs5n3wi9rr9e91Fii53UiiNVXlZMmzGO1W83Jf3 xn7AqxJYeJ2OCYSvP73wk10pb486YXTTVP1wBQ8G94GP/yOC+ib3JecqHJrXoeTDgsZo sqqjp2ddz5x3dldOSh/JhSCWNyt+cQ0pU0wxjue3BURjSEexwrOcGMAhFfsZrrjlRHUj ap1cieN/hNubfEe5TpTAH9lSCG1o8nUmeFV/Vmtw2JSGhI+n+Qrz+O4cPIHMlK7+Wtrk h+MvhFGZOzz40AbqaSOrV28Ev+QPwmpxM6nGDmOUdeLbUv+ox32ql4eQExQTyoGrjzGB c54A== X-Forwarded-Encrypted: i=1; AFNElJ9hGxEKOQo7AytmE+IGQKB4G0RX8okvpVzE1+tY8daAtJucntM96+qrTAv5R4GYC0r0k79ZgQU1X44JZkI=@vger.kernel.org X-Gm-Message-State: AOJu0Ywt0zAXiq4vjyFEjN5ozjbDXf/CCDDT/QzrXw8CPMHkrR2D+npi MpZVrUU72heEf0NzZE6onthrBJegsxiueD1UE3Hgp8bVM3LbhNpQDolr2ltn9vRtEqM7jVsEZHV 9ZtAKW/dcOSH/8qUk838pebO5IHCGFIbScJ9oNK0iE85w9ErPsNL6l2fHggE6wc49Dw== X-Gm-Gg: AeBDietTIihtBYD4VMTtPutrSVWg9eDPdjNnCah+0Nl96beRtF9/d5We6Ax9scDEqRT 5b6ApSmhxA2FhRvyOaqwSEPjXTitlOpYUgg8uOSdMWn5K7WvLjHlOJK0upcMVF4aQX7sAbs5ybi LX6+XvnzkfJ8CvZ/fc3DBF/OAtn7MRLX4IwqRZ8+60qFhLxeX5bs/S9iX2JTQ8ecFshHvJTbvBQ tfpNxNCxmAN/B8LM7OwnfhSO5sNJaX0Zd2M+mvHjmcUOCzVjam0mCfPJEEcKA1FGquzetBT/0cr FbqJoBTEuQVfgKO7DSSHXbHGkux4ailKbFmp18G1v2doOv/4gB/EqV1B9H9lcAPIHD2Xxek2TUl b2SUGbwmcgc8tOM/2M/W8z+bM69AfpPfSomfWM34JAlhS1K0mxXpiijemjXshRKjFA2v/ZD6A7p gG X-Received: by 2002:a05:600c:3e10:b0:485:3cef:d6ea with SMTP id 5b1f17b1804b1-48e5e0089e0mr31312655e9.13.1778144075246; Thu, 07 May 2026 01:54:35 -0700 (PDT) X-Received: by 2002:a05:600c:3e10:b0:485:3cef:d6ea with SMTP id 5b1f17b1804b1-48e5e0089e0mr31312015e9.13.1778144074746; Thu, 07 May 2026 01:54:34 -0700 (PDT) Received: from [192.168.88.32] ([150.228.93.82]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e53891163sm118910315e9.2.2026.05.07.01.54.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 07 May 2026 01:54:34 -0700 (PDT) Message-ID: Date: Thu, 7 May 2026 10:54:32 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v3 09/13] net: lan966x: add PCIe FDMA support To: Daniel Machon , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Horatiu Vultur , Steen Hegelund , UNGLinuxDriver@microchip.com, Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , Stanislav Fomichev , Herve Codina , Arnd Bergmann , Greg Kroah-Hartman , Mohsin Bashir Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20260504-lan966x-pci-fdma-v3-0-a56f5740d870@microchip.com> <20260504-lan966x-pci-fdma-v3-9-a56f5740d870@microchip.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260504-lan966x-pci-fdma-v3-9-a56f5740d870@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 5/4/26 4:23 PM, Daniel Machon wrote: > +static int lan966x_fdma_pci_rx_check_frame(struct lan966x_rx *rx, u64 *src_port) > +{ > + struct lan966x *lan966x = rx->lan966x; > + struct fdma *fdma = &rx->fdma; > + struct lan966x_port *port; > + struct fdma_db *db; > + void *virt_addr; > + u32 blockl; > + > + /* virt_addr points to the IFH. */ > + virt_addr = fdma_dataptr_virt_addr_contiguous(fdma, > + fdma->dcb_index, > + fdma->db_index); > + > + lan966x_ifh_get_src_port(virt_addr, src_port); > + > + if (WARN_ON(*src_port >= lan966x->num_phys_ports)) > + return FDMA_ERROR; > + > + port = lan966x->ports[*src_port]; > + if (!port) > + return FDMA_ERROR; > + > + db = fdma_db_next_get(fdma); > + > + /* BLOCKL is a 16-bit HW-populated field; reject obviously-bad > + * values before they feed memcpy/XDP sizes. > + */ > + blockl = FDMA_DCB_STATUS_BLOCKL(db->status); > + if (blockl < IFH_LEN_BYTES + ETH_FCS_LEN || blockl > fdma->db_size) > + return FDMA_ERROR; Pre-existing issues reported by sashiko (most of them actually) can be safely ignored/postponed to follow-ups, but the above OOB (and in patch 11/13) access looks real and IMHO should be addressed. /P