From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1EC1C4363D for ; Fri, 2 Oct 2020 10:06:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C581206CA for ; Fri, 2 Oct 2020 10:06:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="PV71i67y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387723AbgJBKGd (ORCPT ); Fri, 2 Oct 2020 06:06:33 -0400 Received: from fllv0016.ext.ti.com ([198.47.19.142]:33308 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725993AbgJBKGc (ORCPT ); Fri, 2 Oct 2020 06:06:32 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 092A6RPU085459; Fri, 2 Oct 2020 05:06:27 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1601633187; bh=xBCGG8uSnuwgHbQccQCfe/sl8mZ7XEzoHyACYS52sj0=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=PV71i67yQPdfMOxmof/v+w2EFQB40MUadDaoHjSuZXyRKxo5kwIdezpSHa9IAomc+ oBL1T1ycF6bIXTfCM3FqJgdyH8Fz24vBlapbBYG0sYJnrJKQO4WkpU3UtmnGO1nbZ4 qteN95HaeLjxOXQ5fUQRBUm19HVMGIQy0L3OH2nU= Received: from DLEE111.ent.ti.com (dlee111.ent.ti.com [157.170.170.22]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 092A6Rgo004194 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 2 Oct 2020 05:06:27 -0500 Received: from DLEE104.ent.ti.com (157.170.170.34) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Fri, 2 Oct 2020 05:06:27 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE104.ent.ti.com (157.170.170.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Fri, 2 Oct 2020 05:06:27 -0500 Received: from [192.168.2.14] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 092A6PBk106642; Fri, 2 Oct 2020 05:06:25 -0500 Subject: Re: [PATCH] usb: cdns3: platform_get_irq_byname_optional instead platform_get_irq_byname To: Pawel Laszczak , "balbi@kernel.org" CC: "peter.chen@nxp.org" , "gregkh@linuxfoundation.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Rahul Kumar References: <20200930065758.23740-1-pawell@cadence.com> <722fa58e-604b-bc34-d404-caf7939bb176@ti.com> From: Roger Quadros Message-ID: Date: Fri, 2 Oct 2020 13:06:24 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pawel, On 02/10/2020 12:08, Pawel Laszczak wrote: > Roger, > >> >> On 30/09/2020 09:57, Pawel Laszczak wrote: >>> To avoid duplicate error information patch replaces platform_get_irq_byname >>> into platform_get_irq_byname_optional. >> >> What is duplicate error information? > > The function platform_get_irq_byname print: > " dev_err(&dev->dev, "IRQ %s not found\n", name);" if error occurred. > > In core.c we have the another error message below invoking this function. > e.g > if (cdns->dev_irq < 0) > dev_err(dev, "couldn't get peripheral irq\n"); > > So, it's looks like one dev_err is redundant. If we want all 3 IRQs to be valid irrespective of dr_mode then we should use platform_get_irq_byname() and error out in probe if (ret < 0 && ret != -EPROBE_DEFER). We can get rid of the irq check and duplicate error message in other places. cheers, -roger > >> >>> >>> A change was suggested during reviewing CDNSP driver by Chunfeng Yun. >>> >>> Signed-off-by: Pawel Laszczak >>> --- >>> drivers/usb/cdns3/core.c | 4 ++-- >>> 1 file changed, 2 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/usb/cdns3/core.c b/drivers/usb/cdns3/core.c >>> index a0f73d4711ae..a3f6dc44cf3a 100644 >>> --- a/drivers/usb/cdns3/core.c >>> +++ b/drivers/usb/cdns3/core.c >>> @@ -465,7 +465,7 @@ static int cdns3_probe(struct platform_device *pdev) >>> >>> cdns->xhci_res[1] = *res; >>> >>> - cdns->dev_irq = platform_get_irq_byname(pdev, "peripheral"); >>> + cdns->dev_irq = platform_get_irq_byname_optional(pdev, "peripheral"); >> >> As per DT binding document, these are mandatory properties > > I think that name platform_get_irq_byname_optional is little confusing. > Function descriptions show that both are almost identical: > /** > * platform_get_irq_byname_optional - get an optional IRQ for a device by name > * @dev: platform device > * @name: IRQ name > * > * Get an optional IRQ by name like platform_get_irq_byname(). Except that it > * does not print an error message if an IRQ can not be obtained. > * > * Return: non-zero IRQ number on success, negative error number on failure. > */ > >> >> - interrupts: Interrupts used by cdns3 controller: >> "host" - interrupt used by XHCI driver. >> "peripheral" - interrupt used by device driver >> "otg" - interrupt used by DRD/OTG part of driver >> >> for dr_mode == "otg" -> all 3 are mandatory. >> for dr_mode == "host" -> "otg" and "peripheral" IRQs are not required. >> for dr_mode == "periphearal" -> "otg" and "host" IRQs are not required. >> >>> if (cdns->dev_irq == -EPROBE_DEFER) >>> return cdns->dev_irq; >>> >>> @@ -477,7 +477,7 @@ static int cdns3_probe(struct platform_device *pdev) >>> return PTR_ERR(regs); >>> cdns->dev_regs = regs; >>> >>> - cdns->otg_irq = platform_get_irq_byname(pdev, "otg"); >>> + cdns->otg_irq = platform_get_irq_byname_optional(pdev, "otg"); >>> if (cdns->otg_irq == -EPROBE_DEFER) >>> return cdns->otg_irq; >>> >>> >> > > Regards, > Pawel > -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki