mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: Ma Ke <make24@iscas.ac.cn>,
	vkoul@kernel.org, kishon@kernel.org, sjakhade@cadence.com,
	sergio.paracuellos@gmail.com, robh@kernel.org
Cc: linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: cadence-torrent: Check return value on register read
Date: Tue, 2 Jul 2024 14:54:04 +0300	[thread overview]
Message-ID: <b73fa427-9b55-4ca5-8edd-530ad26c7df4@kernel.org> (raw)
In-Reply-To: <20240702032042.3993031-1-make24@iscas.ac.cn>



On 02/07/2024 06:20, Ma Ke wrote:
> cdns_torrent_dp_set_power_state() does not consider that ret might be
> overwritten. Add return value check of regmap_read_poll_timeout() after
> register read in cdns_torrent_dp_set_power_state().
> 
> Fixes: 5b16a790f18d ("phy: cadence-torrent: Reorder few functions to remove function declarations")
> Signed-off-by: Ma Ke <make24@iscas.ac.cn>

Reviewed-by: Roger Quadros <rogerq@kernel.org>

  parent reply	other threads:[~2024-07-02 11:54 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02  3:20 Ma Ke
2024-07-02  7:43 ` Markus Elfring
2024-07-02 13:12   ` Vinod Koul
2024-07-02 11:54 ` Roger Quadros [this message]
2024-07-02 13:35 ` Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b73fa427-9b55-4ca5-8edd-530ad26c7df4@kernel.org \
    --to=rogerq@kernel.org \
    --cc=kishon@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=make24@iscas.ac.cn \
    --cc=robh@kernel.org \
    --cc=sergio.paracuellos@gmail.com \
    --cc=sjakhade@cadence.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®