mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dave Hansen <dave.hansen@intel.com>
To: Alexander Potapenko <glider@google.com>,
	tglx@linutronix.de, chang.seok.bae@intel.com, bp@suse.de
Cc: dvyukov@google.com, elver@google.com, x86@kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/fpu/signal: initialize sw_bytes in save_xstate_epilog()
Date: Tue, 30 Nov 2021 13:08:58 -0800	[thread overview]
Message-ID: <b740b48e-2675-d324-d35c-d96f973f24e0@intel.com> (raw)
In-Reply-To: <20211126124746.761278-1-glider@google.com>

On 11/26/21 4:47 AM, Alexander Potapenko wrote:
> save_sw_bytes() did not fully initialize sw_bytes, which caused KMSAN
> to report an infoleak (see below).
> Initialize sw_bytes explicitly to avoid this.
...
> Reported-by: Alexander Potapenko <glider@google.com>
> Signed-off-by: Marco Elver <elver@google.com>
> Signed-off-by: Alexander Potapenko <glider@google.com>
> Tested-by: Alexander Potapenko <glider@google.com>
> Fixes: 53599b4d54b9b8dd ("x86/fpu/signal: Prepare for variable sigframe length")
> Link: https://lore.kernel.org/all/CAG_fn=V9T6OKPonSjsi9PmWB0hMHFC=yawozdft8i1-MSxrv=w@mail.gmail.com/

Hi Alexander,

Marco's SoB entry is before yours.  Was this authored by you or Marco?
If it was Marco, it's customary to add a:

	From: Marco Elver <elver@google.com>

at the top of the changelog to make sure git gets the author right.  I'm
happy to fix it up this time, I just need to know who wrote it.

  reply	other threads:[~2021-11-30 21:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-26 12:47 Alexander Potapenko
2021-11-30 21:08 ` Dave Hansen [this message]
2021-11-30 21:38   ` Alexander Potapenko
2021-11-30 23:28     ` Marco Elver
2021-11-30 23:22 ` [tip: x86/urgent] x86/fpu/signal: Initialize " tip-bot2 for Marco Elver

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b740b48e-2675-d324-d35c-d96f973f24e0@intel.com \
    --to=dave.hansen@intel.com \
    --cc=bp@suse.de \
    --cc=chang.seok.bae@intel.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®