mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mark Pearson" <mpearson-lenovo@squebb.ca>
To: qvkap <qvkapp@gmail.com>, "Hans de Goede" <hansg@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
	"Ike Panhc" <ikepanhc@gmail.com>
Cc: "platform-driver-x86@vger.kernel.org"
	<platform-driver-x86@vger.kernel.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] platform/x86: ideapad-laptop: add no_rfkill quirk for IdeaPad Slim 3 16IRH10
Date: Mon, 09 Nov 2026 20:06:37 -0500	[thread overview]
Message-ID: <b7428de0-c009-45a3-a2c8-0722ed7bce6e@app.fastmail.com> (raw)
In-Reply-To: <CAABLQ8qdSC1r=-et0y6qnEjNE-FCvoT8wxbo6R9vmW5=bUOSgA@mail.gmail.com>

Hi,

On Mon, Nov 9, 2026, at 12:02 PM, qvkap wrote:
> Hi Hans, Mark, Ilpo,
>
> On newer IdeaPad models such as the IdeaPad Slim 3 16IRH10 (83K2), the
> EC/ACPI firmware reports erratic rfkill radio states through
> VPCCMD_R_WIFI / VPCCMD_R_RF, causing periodic soft/hard blocks of the
> native Wi-Fi/Bluetooth interfaces (iwlwifi) without any user
> interaction or physical hardware switch.
>
> This patch introduces a no_rfkill quirk and adds IdeaPad Slim 3
> 16IRH10 to skip registering defective ACPI rfkill devices. Tested and
> confirmed working on live hardware.
>
> GitHub: https://github.com/qvkap/ideapad-slim3-rfkill-patch
> Raw Patch: 
> https://raw.githubusercontent.com/qvkap/ideapad-slim3-rfkill-patch/master/0001-platform-x86-ideapad-laptop-add-no_rfkill-quirk-for-.patch
>
> Signed-off-by: qvkap <qvkapp@gmail.com>

I assume posting a link to a patch is not going to be acceptable (I almost didn't bother looking at this one because of that because I'm behind on my overflowing inbox) but I'll let the experienced maintainers comment on that.

I've been looking at a similar issue on Thinkpad's but have been trying to gather data on which platforms are impacted. We're finding the same thing there where the kill is powering down the device and it's never recovering - and we've been fixing FW for the last 3 years to make the APCI method a no-op where it has caused problems. Recently the FW team complained as the ACPI method is used for debug testing...so trying to find a better long term solution.

I'm not a fan of the DMI approach as I don't think it's going to scale well - it means every new platform is (likely) going to need to be added; which is going to get really tedious fast.
I don't think it's really a FW issue and more a fact that device drivers have caught up and the ACPI rfkill is no longer needed - but I'm guessing a bit. For Thinkpad I did get confirmation that it's not used on Windows FWIW.

I have a patch that is almost the opposite - I was going to disable the rfkill mechanism unless a module parameter specifically enabled it. 
My logic is maybe some older models will need it - but so far in my testing newer (5 years or less) seem fine. I've been unable to determine the cut-off so far.

If anybody on the list has opinions let me know. Gathering data on the impact is taking time (sadly in short supply)

Mark


  reply	other threads:[~2026-11-10  1:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 17:02 qvkap
2026-11-10  1:06 ` Mark Pearson [this message]
     [not found] <CADR1qY06VsPbztPW=E9eTNm1fhgwXvhnOWFYSO676S63gn6wVQ@mail.gmail.com>
2026-11-09 17:00 ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b7428de0-c009-45a3-a2c8-0722ed7bce6e@app.fastmail.com \
    --to=mpearson-lenovo@squebb.ca \
    --cc=hansg@kernel.org \
    --cc=ikepanhc@gmail.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=platform-driver-x86@vger.kernel.org \
    --cc=qvkapp@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®