From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CB18A243964; Tue, 29 Apr 2025 23:48:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745970509; cv=none; b=jqwACP85bEi/hQmZjSQmpU4uh2SpNYycmWCVvM3XSD+5jPUjrvowfPgqXU0pCytJO2bHC0mNl72L1yB3PfAlnzQSukNOG/q5dJeiqCwpBN1IMaMsUK47Frc4Uk9YRiNVAXE3GxlEdQh7CFEGJ61lLvnB5g3GRGmP9WRUhlu2NiY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745970509; c=relaxed/simple; bh=4UQrbLqnprywh1jT+CZHStDeoQvlUasn56dHNhU58J0=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=OBCAHQYtgbfCaC3M6JUYpT3cMgmoiiOdRVrBGa2CLL3bYBkn4X/BWEaHeMFeC85Etoi6TUQQ4EjLOw1qTqztkDOnuHYE/C2ZhPtwkvVVcigS/pevNw5axPPuoc4ux6YFP1el2q0lmpKkWJgk20r8rHPYXBOHZydULYG77yleeqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com; spf=pass smtp.mailfrom=quicinc.com; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b=NM9pNT7t; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=quicinc.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=quicinc.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=quicinc.com header.i=@quicinc.com header.b="NM9pNT7t" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 53TLaYKj020989; Tue, 29 Apr 2025 23:48:12 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= oxUzzwgOdMjLzaUEsHCOAZMj5vXBisxuhB1rh5eePP8=; b=NM9pNT7tUZ3VrfPy nkirBQwdr9kTg1r8ntzz77GdJ/o0euXluUURgZ+EIVmLW/7rZXSKM4/2qRPSVXY/ LHcm2wRtNsxR+3uc9wTKdwY5uto411Dbf7uPcFWIZJi/veFeUII1fAuTndlxgmZJ 8BXw043HpeFUXqNHT7LwVV7k+U7FKoS8KRmHqfoqAJ2Vp/TuVwlcoZnntrYwEl4N nKTQdNLqVnMEU8RLP3y7zxyGaR5e6zn+Dyu7scMKn9c3K60Blw1oHe7w9cpcWMQQ tXARRzc4VqAtWc3BxiwkJkGkWV7foWdQFPT+FsGKwFMU9WZkvLesXT1OsRMfYeDt +qcVOw== Received: from nasanppmta04.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 46b6u1r7e0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Apr 2025 23:48:12 +0000 (GMT) Received: from nasanex01b.na.qualcomm.com (nasanex01b.na.qualcomm.com [10.46.141.250]) by NASANPPMTA04.qualcomm.com (8.18.1.2/8.18.1.2) with ESMTPS id 53TNmBfE006356 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 29 Apr 2025 23:48:11 GMT Received: from [10.134.71.99] (10.80.80.8) by nasanex01b.na.qualcomm.com (10.46.141.250) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Tue, 29 Apr 2025 16:48:10 -0700 Message-ID: Date: Tue, 29 Apr 2025 16:48:10 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 3/8] drm/msm/dpu: pass master interface to CTL configuration To: Dmitry Baryshkov , Rob Clark , Abhinav Kumar , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter CC: , , , , "Neil Armstrong" References: <20250307-dpu-active-ctl-v3-0-5d20655f10ca@linaro.org> <20250307-dpu-active-ctl-v3-3-5d20655f10ca@linaro.org> Content-Language: en-US From: Jessica Zhang In-Reply-To: <20250307-dpu-active-ctl-v3-3-5d20655f10ca@linaro.org> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nasanex01b.na.qualcomm.com (10.46.141.250) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Authority-Analysis: v=2.4 cv=G5AcE8k5 c=1 sm=1 tr=0 ts=6811653c cx=c_pps a=JYp8KDb2vCoCEuGobkYCKw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=GEpy-HfZoHoA:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=KKAkSRfTAAAA:8 a=tVI0ZWmoAAAA:8 a=COk6AnOGAAAA:8 a=pM9NJlXElLjiyNQRogoA:9 a=QEXdDO2ut3YA:10 a=cvBusfyB2V15izCimMoJ:22 a=-BPWgnxRz2uhmvdm1NTO:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNDI5MDE3NiBTYWx0ZWRfXw9zFPWohdwU5 AnYbY8+HcXA4pFfcS/nf9j89bvqgD0YVfKpECfsdBMo+7+VBkwZTX60ZQaiDUycytGkHhI/sLCJ AuFjvOP5/l4d7Qxv5VnvvINJTMweYPoOR/k4eEnIp6YqTGgWCEg+hBvULvPEtWmCI3DfzmKbOPk EMfNu+7yOhl/Q7BYZCAp+V3WY5a1ehwwi3+MNQrRoYYHIWDFRAVLfaLd6vLjNTTBOBKFdVTA8MU yUTTWVBPhsmYi3ZgKR+/OC/l3tN1ba5rGg3IpN9AHbBrILei1OQpiERYHH7MGinB5FEUkdr/Dnz 8gQhImlSwzXCdzwrgpfcTOb96n1xLXEo8ytdEi2Qo99ONbDGeKq014+woIf6+6Jf9lKQ3rCpTxF M1/XF71FtQztCYHEpSsJnAzDD8gvlEk4d4rRO7gu/7U3tCjhSx7KXvkUGQTnUAhH8HROdttL X-Proofpoint-GUID: xy3JhOGD3_KXcWNcSvOVls6D8--26v28 X-Proofpoint-ORIG-GUID: xy3JhOGD3_KXcWNcSvOVls6D8--26v28 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-04-29_08,2025-04-24_02,2025-02-21_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 impostorscore=0 phishscore=0 mlxlogscore=999 lowpriorityscore=0 adultscore=0 mlxscore=0 malwarescore=0 suspectscore=0 clxscore=1015 bulkscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2504070000 definitions=main-2504290176 On 3/6/2025 10:24 PM, Dmitry Baryshkov wrote: > From: Dmitry Baryshkov > > Active controls require setup of the master interface. Pass the selected > interface to CTL configuration. > > Reviewed-by: Marijn Suijten > Tested-by: Neil Armstrong # on SM8550-QRD > Signed-off-by: Dmitry Baryshkov Reviewed-by: Jessica Zhang > --- > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 2 ++ > drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 2 ++ > 2 files changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > index da9994a79ca293ec0265680c438835742102db2a..a0ba55ab3c894c200225fe48ec6214ae4135d059 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c > @@ -60,6 +60,8 @@ static void _dpu_encoder_phys_cmd_update_intf_cfg( > return; > > intf_cfg.intf = phys_enc->hw_intf->idx; > + if (phys_enc->split_role == ENC_ROLE_MASTER) > + intf_cfg.intf_master = phys_enc->hw_intf->idx; > intf_cfg.intf_mode_sel = DPU_CTL_MODE_SEL_CMD; > intf_cfg.stream_sel = cmd_enc->stream_sel; > intf_cfg.mode_3d = dpu_encoder_helper_get_3d_blend_mode(phys_enc); > diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c > index abd6600046cb3a91bf88ca240fd9b9c306b0ea2e..232055473ba55998b79dd2e8c752c129bbffbff4 100644 > --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c > +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_encoder_phys_vid.c > @@ -298,6 +298,8 @@ static void dpu_encoder_phys_vid_setup_timing_engine( > if (phys_enc->hw_cdm) > intf_cfg.cdm = phys_enc->hw_cdm->idx; > intf_cfg.intf = phys_enc->hw_intf->idx; > + if (phys_enc->split_role == ENC_ROLE_MASTER) > + intf_cfg.intf_master = phys_enc->hw_intf->idx; > intf_cfg.intf_mode_sel = DPU_CTL_MODE_SEL_VID; > intf_cfg.stream_sel = 0; /* Don't care value for video mode */ > intf_cfg.mode_3d = dpu_encoder_helper_get_3d_blend_mode(phys_enc); >