From: "Gustavo A. R. Silva" <gustavo@embeddedor.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, Kees Cook <keescook@chromium.org>,
Mathieu Malaterre <malat@debian.org>
Subject: Re: [PATCH] firewire: mark expected switch fall-throughs
Date: Thu, 14 Mar 2019 13:42:14 -0500 [thread overview]
Message-ID: <b7451b1f-d770-5173-8af7-468491ccafd5@embeddedor.com> (raw)
In-Reply-To: <20190314110038.7ef825de@kant>
On 3/14/19 5:00 AM, Stefan Richter wrote:
[..]
>> diff --git a/drivers/firewire/core-iso.c b/drivers/firewire/core-iso.c
>> index 35e784cffc23..7e5c98840b80 100644
>> --- a/drivers/firewire/core-iso.c
>> +++ b/drivers/firewire/core-iso.c
>> @@ -308,7 +308,7 @@ static int manage_channel(struct fw_card *card, int irm_id, int generation,
>> if ((data[0] & bit) == (data[1] & bit))
>> continue;
>>
>> - /* 1394-1995 IRM, fall through to retry. */
>> + /* fall through - to retry for 1394-1995 IRM */
>
> If you don't mind, I will apply your patch with a different wording of this
> comment:
>
> /* fall through - It's an 1394-1995 IRM, retry. */
>
> I'll mark my modification to your patch in the signed-off-by-tag.
>
Sure. That's fine with me.
Thank you.
--
Gustavo
prev parent reply other threads:[~2019-03-14 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 18:03 Gustavo A. R. Silva
2019-03-14 10:00 ` Stefan Richter
2019-03-14 18:42 ` Gustavo A. R. Silva [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7451b1f-d770-5173-8af7-468491ccafd5@embeddedor.com \
--to=gustavo@embeddedor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=malat@debian.org \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®