From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A360A2750FB; Tue, 10 Feb 2026 16:11:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770739915; cv=none; b=VX96lx9foArMM9CcuZg6rI3SyD5X9lGXKhRf52Y4oGG8q4lmpnNXDGIaAmcPpySm/ldJA/zSXbK27QzgixAYtBaXxS98O7oHEqx4XiOn4MoV1r6zQxhP5rP1hzQHpEWw1Ntyw9y4JKho8qDeTr5LsqjPSU25PeBsmURFITEufkc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1770739915; c=relaxed/simple; bh=hv8MdTxOARYgBArz8CFu0FgtRleZmIW+avTLP5qtEBc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WDR0WeARzrI670uUCSRtPvs1dhnOfDHJa71o9HBgLtCDUEVKtgG70uoId4USJjE5+7YPMQknD9+mBvY+QKOVxjzH9Ng1XmQPnmYJHSQDrEBmTNCInU0dQLu3zy/i+X/fjs9cAcgE18re01Hv+OhYmxm38ucNipLiaXFTR6ddP1U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=XfeT/V11; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="XfeT/V11" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CCD9C116C6; Tue, 10 Feb 2026 16:11:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1770739915; bh=hv8MdTxOARYgBArz8CFu0FgtRleZmIW+avTLP5qtEBc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=XfeT/V11i6qk9/PeHPt1BcMS6C6fmDNbJliWA+IJPLT8kmyFU9tld3TljsafPmc4O nmcqSxi5plExE42VRcTCvrhJe68QSj54VSY3BVbWYU/jMf0sQ5M9cZl7QLTu4LsNwJ S6K7LxUwH9a3etcF363PJ9B3WX64+38C20rNLdgKJqdkcqY6hNCEW8XP+e1uUGlwdV DDrzapJQZQ4Fil7Z33/iLf1naVel8CSAwn+bCHw78tmnmxnf7p/ST3ypF61x6TViDh 1swmsLHkr9OoWnKOje5dqc12Iib4WjR/rOEN9Hrr4s0GpC5BGpzqHxHt0sXH1+6rFf eTOf9Qbh4Whgw== Message-ID: Date: Tue, 10 Feb 2026 17:11:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/2] dt-bindings: watchdog: Add NPCM reset status support To: Tomer Maimon , andrew@codeconstruct.com.au, avifishman70@gmail.com, tali.perry1@gmail.com, wim@linux-watchdog.org, linux@roeck-us.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: venture@google.com, yuenn@google.com, benjaminfair@google.com, joel@jms.id.au, openbmc@lists.ozlabs.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260210133843.1078463-1-tmaimon77@gmail.com> <20260210133843.1078463-2-tmaimon77@gmail.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <20260210133843.1078463-2-tmaimon77@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/02/2026 14:38, Tomer Maimon wrote: > Add reset status detection for NPCM7XX and NPCM8XX platforms via syscon > integration. Document syscon property and three configurable reset type > properties (nuvoton,card-reset-type, nuvoton,ext1-reset-type, > nuvoton,ext2-reset-type)that map reset signal detection to specific > reset bit positions. > > Signed-off-by: Tomer Maimon > --- > .../watchdog/nuvoton,npcm750-wdt.yaml | 51 ++++++++++++++++++- > 1 file changed, 49 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/watchdog/nuvoton,npcm750-wdt.yaml b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm750-wdt.yaml > index 7aa30f5b5c49..054cc0115af2 100644 > --- a/Documentation/devicetree/bindings/watchdog/nuvoton,npcm750-wdt.yaml > +++ b/Documentation/devicetree/bindings/watchdog/nuvoton,npcm750-wdt.yaml > @@ -12,7 +12,7 @@ maintainers: > description: > Nuvoton NPCM timer module provides five 24-bit timer counters, and a watchdog. > The watchdog supports a pre-timeout interrupt that fires 10ms before the > - expiry. > + expiry and reset status detection via syscon integration. > > allOf: > - $ref: watchdog.yaml# > @@ -40,12 +40,55 @@ properties: > clock-frequency: > description: Frequency in Hz of the clock that drives the NPCM timer. > > + syscon: First iteration. See "How to Get Your DT Schema Bindings Accepted in Less Than 10 Iterations" or just read the docs please. > + description: phandle to the Global Control Register (GCR) syscon node. > + $ref: /schemas/types.yaml#/definitions/phandle > + > + nuvoton,card-reset-type: > + description: Reset type for external card reset signal detection. > + enum: > + - porst > + - corst > + - wd0 > + - wd1 > + - wd2 > + - sw1 > + - sw2 > + - sw3 > + - sw4 You want it to be static configuration, so cannot be changed runtime? Why? > + > + nuvoton,ext1-reset-type: > + description: Reset type for external reset signal 1 detection. > + enum: > + - porst > + - corst > + - wd0 > + - wd1 > + - wd2 > + - sw1 > + - sw2 > + - sw3 > + - sw4 > + > + nuvoton,ext2-reset-type: > + description: Reset type for external reset signal 2 detection. > + enum: > + - porst > + - corst > + - wd0 > + - wd1 > + - wd2 > + - sw1 > + - sw2 > + - sw3 > + - sw4 > + > required: > - compatible > - reg > - interrupts > > -unevaluatedProperties: false > +additionalProperties: false Why? Nothing explains this in the commit msg. > > examples: > - | > @@ -57,4 +100,8 @@ examples: > interrupts = ; > reg = <0xf000801c 0x4>; > clocks = <&clk NPCM7XX_CLK_TIMER>; > + syscon = <&gcr>; > + nuvoton,card-reset-type = "porst"; > + nuvoton,ext1-reset-type = "wd0"; > + nuvoton,ext2-reset-type = "wd2"; > }; Best regards, Krzysztof