From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E0BCF35F60A for ; Mon, 2 Mar 2026 11:07:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772449624; cv=none; b=CtLKtRFjnrWhgWRu7c6CPeCR2CYIiTzZkM/iePRJN29gX8sc3MpU0tSfexpMLEjLY2Z/qSEt+TYcvKkH9TqyDvzqEs9S/Cr/AlbmsEsvM/WBmQECEjYvNH7wE4KavLwKfCB7pAovMEJjetfD8hdiEAl1s2t8RapTGOrBArg50gU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772449624; c=relaxed/simple; bh=BBuFilbkJGsN6xMCsRGB9mMzj5tWOIs/AWZNl6o5ujM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ktjwB/uqYXyizmF/yAr10sgFdxncYjWcecoE2v0vVll9OEqnx99+WM+0rNAAn11LE/Y3LPEQu5Fw6TwjibQjQU42WpDNJzffBLXRRNT2z3CGtbGi/F/MQz2+xCSnVmZm6L32nNpYe/0B2K10vHNaXIkx+NJaZAk1Oqqz5jgkqnc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OfEe3/Q3; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jdD86HH2; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OfEe3/Q3"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jdD86HH2" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6229Em7C3630778 for ; Mon, 2 Mar 2026 11:07:01 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 8p5W6PTajQxRRdBVXun2ntjArNqAZvNR3wDMgU+v+Nc=; b=OfEe3/Q3k25ZMdzD M+qtpADaKdb1/139SeHxGM7YsjbNJd0aa7ZKuuMNt9JoowXlp2icMAKzde3NiXXG nqDg3bXfHo7Qzu2CHmKP5dhd0zqToN1aBK0o83dmGahBQ4uU05/QD7crkFmakKyb kvS0K+MvV268dzEr38QXpneaMGR7mcvaIkKPQwupy9K/YMK0wvtEmhqd8ITbI1ew 3n1UmQz4jSNihqjgXTWUwiMsnIJPGVZnNQ79nlBFQv1fpWTFMEFJswH7SBy2UR0+ YklhYy0BDeA4pPEGXoVZTwxja+Ggz7JOmI9RtMcNmtoVrvlbwyF9B2QxWXneOHrf T2vOIw== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4cn7rhrd0h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 02 Mar 2026 11:07:01 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8cb38a5dc3cso436777185a.3 for ; Mon, 02 Mar 2026 03:07:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1772449621; x=1773054421; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=8p5W6PTajQxRRdBVXun2ntjArNqAZvNR3wDMgU+v+Nc=; b=jdD86HH2nE79P8bTOhVQJvKfPFJpI3/mXbwIBw9N2vxZwydoeMRzOpzPifVFR+vYeo v3n840OPBe1oJZnNR2AmWRCx4rcQYh2ujOjy5GosnivX9tAKXlejltHQ76F6H/3xWUqt 1911PJ4WTgY8uRynNvt4LhM8YFfC7WBN1O1l2n1onawuKRLbQ0isJQ6LSpUgcrrVUabJ cDhyOuHyjsVRtLuMDUrTbovZKNtRhvgNjEwuu0j2LH8s5jI2PFh1TfLP04/3IKyRcqeh TAUOobKbHf1JzZmQLg3iZPdWbEyHO9YzR4U1eKRFxKIoXe6QXXCs2GsZQPpMlwb7qc9/ qBmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772449621; x=1773054421; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=8p5W6PTajQxRRdBVXun2ntjArNqAZvNR3wDMgU+v+Nc=; b=v02O0krM3eyaU9J3THmf30tXc1NEvXlLU8lPGiSGt5KrWQbXrOueALAh2S2Aq/taHP 1HHUOXQA9vgHXpiOd+agRIpBGuwiNfJkCC8cC43IVpRnQ+LHMjHhCHeqM5DQQyQeZdtS EXrd+uPfSNp6xEK8TQvGWbWuJGDCnI3AEVDkli3ykakcowrs4V1yG8232amvy2Jd5n1w sd1bRDyGl0S9zZHjlT2trDp8y97iDRDPJmQPb50TCFsiOzZKthBBuRA6pZTIT9pj6Atg FRfzqJC0Vq654HEeGaSp1OkT0DU4b3MFclGOCb+RTZvHkgmUNoBHt74oO6qFe/892NnO h8tA== X-Forwarded-Encrypted: i=1; AJvYcCVhWM41l9CDXvt3KQohFcQv1K+Go22weqEPrH4UHylAEl/IQzn0SDwxl1QE1cPMRXkFBOdStXKH1d74nBM=@vger.kernel.org X-Gm-Message-State: AOJu0YwUDsfaekDFJSAZryldnkOdMlDmaZ/KeLu9pZQbJkB4oVh2IcrF T44XQYIzZCEKCSA2yX2/aCqc4U3R2u7wcsqrBG/VnLO4tMdrcmolveQ71LScMVTfaGh+ERi0naz ZkqXx/wMzu/5j3rmgZhF1Yx2JX+pyw1UlBccz+K8FJ0UgZKYlAZBXyxTwUr967JZa6lc= X-Gm-Gg: ATEYQzwgjV+ATvNcadu2B5EvzY5uwREs+3FIktz7VZV5NxpcprI0VJw2bfmUI7oMdG+ YwcajH4mLcX8F3JaLOpyFLWdQd83/Y/XvFD9m4uxSPsuOSXcGgBIISnNCGxUL6am3eyQNwC6AZ/ AgPFgUpJb6I809ZvMT/G99w1CuIUPawDM62D5XmlPS4i2Fa1HrxnIQmKaq7bROnZzQ5rzl4RFhh zy0SljI2XNOyROZY7gBzq+5caDeyoQipOeEvTU7i0KHcm+sM1uY1Wu75MU991E1F1EDmnfvKktk 9x+tjS/q8n7u9umU7mJxBKe+Hu4GfCyfUWUh9beRVUD8CQLy8tG4eDWHjZMfqnsWS8bX7Zo+mql zI6NQEXJMyJgWDOJctn6YxJSSZQapu+aR/RyUzUndoJQl9n34shKLvi81HV0sgoztF4kd4L9+X+ mSKpI= X-Received: by 2002:a05:620a:4004:b0:8c7:1b40:d096 with SMTP id af79cd13be357-8cbc8e79d8bmr1105603285a.9.1772449621119; Mon, 02 Mar 2026 03:07:01 -0800 (PST) X-Received: by 2002:a05:620a:4004:b0:8c7:1b40:d096 with SMTP id af79cd13be357-8cbc8e79d8bmr1105599485a.9.1772449620636; Mon, 02 Mar 2026 03:07:00 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-65fabf6cfd9sm3331067a12.22.2026.03.02.03.06.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Mar 2026 03:07:00 -0800 (PST) Message-ID: Date: Mon, 2 Mar 2026 12:06:55 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/10] arm64: dts: qcom: sdm845-google: Add STM FTS touchscreen support To: david@ixit.cz, Dmitry Torokhov , Maxime Coquelin , Alexandre Torgue , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Henrik Rydberg , Bjorn Andersson , Konrad Dybcio Cc: Petr Hodina , linux-input@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, phone-devel@vger.kernel.org References: <20260301-stmfts5-v1-0-22c458b9ac68@ixit.cz> <20260301-stmfts5-v1-10-22c458b9ac68@ixit.cz> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260301-stmfts5-v1-10-22c458b9ac68@ixit.cz> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: REuhEnpFxGChxOcUyxVfTo9WC6AdJkW1 X-Proofpoint-GUID: REuhEnpFxGChxOcUyxVfTo9WC6AdJkW1 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzAyMDA5MiBTYWx0ZWRfX72SrshYrctFZ jdIrI1UDwkyJOX7yjlZoK0luYeDGgjX8XYcVnD41YqxmRuhNwAox0oaY1i076VF3RLtinmiemSW IWalOOdgymjFCxjy0VI4XukHfvsrhD8kX7w73oEk4x3FoB1E2hNjvj9K+F8GO8lX3dQXM7DLAPj iZNZILQBCukhXJX6chEYj8c45LZYACXZh8mnnLuHcDvhE0a1RFKy6G8oHWeJsHJxudn3Be+uJz4 ePtzpq9QLp+ASMJQGcWCWxTjsei9EdZwqOajZiM5oVegD+nMUnICR7yu7oqNR/MpQ4TWQYi+fSj bNKDS9JTFswaq+LnFC3BOht9TbGzx01k6rWm6UEzrFkPfIVvlGXiF1POnfBe3lQHJSRxCCG0lYk COy33GXgOVrxsavLpLzfFyfZ5W63+/5+oBgHPjHBgv+Vsw4YhGkNoIIA6WeLvQzckit1az63coG jPPT2TeeL4YRnBi/8Yw== X-Authority-Analysis: v=2.4 cv=cLntc1eN c=1 sm=1 tr=0 ts=69a56f55 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=sfOm8-O8AAAA:8 a=8wVjoaYgGRnUAGDsoUAA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 a=TvTJqdcANYtsRzA46cdi:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-02_03,2026-02-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 malwarescore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 impostorscore=0 phishscore=0 spamscore=0 suspectscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2602130000 definitions=main-2603020092 On 3/1/26 6:51 PM, David Heidelberg via B4 Relay wrote: > From: Petr Hodina > > Basic touchscreen connected to second i2c bus. > > Signed-off-by: Petr Hodina > Co-developed-by: David Heidelberg > Signed-off-by: David Heidelberg > --- > arch/arm64/boot/dts/qcom/sdm845-google-blueline.dts | 21 ++++++++++++++++++++- > 1 file changed, 20 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-google-blueline.dts b/arch/arm64/boot/dts/qcom/sdm845-google-blueline.dts > index fa89be500fb85..2501104b06e1b 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-google-blueline.dts > +++ b/arch/arm64/boot/dts/qcom/sdm845-google-blueline.dts > @@ -26,7 +26,26 @@ &i2c2 { > > status = "okay"; > > - /* ST,FTS @ 49 */ > + touchscreen@49 { > + compatible = "st,stmfts5"; > + reg = <0x49>; > + > + pinctrl-0 = <&touchscreen_pins &touchscreen_reset>; > + pinctrl-names = "default"; > + > + interrupt-parent = <&tlmm>; > + interrupts = <125 IRQ_TYPE_LEVEL_LOW>; > + > + irq-gpios = <&tlmm 125 GPIO_ACTIVE_HIGH>; This is an anti-pattern - you can translate the GPIO handle to an IRQ handle, but unless the hardware is spectacularly odd, an interrupt reference is usually what you're after > + switch-gpios = <&tlmm 136 GPIO_ACTIVE_HIGH>; > + reset-gpios = <&tlmm 99 GPIO_ACTIVE_LOW>; > + > + avdd-supply = <&vreg_l14a_1p8>; > + vdd-supply = <&vreg_l19a_3p3>; > + > + touchscreen-size-x = <1079>; > + touchscreen-size-y = <2159>; Are you sure about these off-by-ones? FWIW input/touchscreen.c: touchscreen_get_prop_u32(dev, "touchscreen-size-x", input_abs_get_max(input, axis_x) + 1, notice ^ Konrad