From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 16DF865192 for ; Mon, 18 May 2026 14:01:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.44 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779112892; cv=none; b=lONvGumLvZCeNdeHfBVX6gvVA6wHtXgARxOaR8NuYkUWjkui9MvHgOUCm3jWaWgF3rLuFRcc7JIzqzuvR9E8pOhbW1MN+MIH2rJOoT4zu4UJ8jMdk7R79JBGskOMmsiQ1TpZMIVJqRfnK4pP54Avw+iCeUPol5PA8P1bzK+S3S8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779112892; c=relaxed/simple; bh=ZO1VYH60iC5+y7zVuhjJDXYWdSl4NRI4sN2pV2576No=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=L2WJroWm9XdR0/72YydWR2YF4lYxQTFlCh+cZ3JchBnabjBcE6HocTzhfTUrccteulMN8zqI4DBH1ekd1KgRRWP6ypzUIIEytXn8M9j5hLdSx+zdW3ezv8x9GkrLVtm4Hfrnp8VbNtqSBR9VfnwUCNgUMZbYGrm2qlHEGn/UvQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=duXUc5Zn; arc=none smtp.client-ip=209.85.128.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="duXUc5Zn" Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-488b0046078so21230495e9.1 for ; Mon, 18 May 2026 07:01:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1779112889; x=1779717689; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=+LB2Sjg0VNa6qbJErLOgdik8RDhZEWe/BW61T3GfWXI=; b=duXUc5ZncybgRtDXd8zBBIL6zYsHMGIfD+4m18SNHjYmuuBXQN/8gtJWlKIXJ1f6+5 xePyHkyh/pRCkle7QvSlvM5M1a/2k1WVOal6mN+WWHQQILScVVVqWWT65gHUSmhTYftP dlcGERaAuwmyd1qt7b/9FZm2h4MvixbTqOHL+HPZu7ZhcHjFb/vMM5GwSdE+aplhHw5o GNHrcfIoKQPiOJxb+XRwwVHR4Hd+cmZu9x1o+z5eeb0PMVocGJR1agfNzHYOBVjDXM7B zBojx6azOdIMSI+bqprGYx1HXQwKiYjovksHQ1so/fX39EKg1aj6aYFYWftCXp03rO2h cGiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779112889; x=1779717689; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+LB2Sjg0VNa6qbJErLOgdik8RDhZEWe/BW61T3GfWXI=; b=AD5hMELSx2qpIPX13ohk5gUgVgxuDEvDrFjKEvb6fy604bSq3uqcUGdMil75/Nr1QH 8FXq5y1uJL5O0262a7B0pOxev1Z0Q/6UTXLWWoDAqQuMaieSbkntyXNFFJ3Z4IWB1KBP +l8ZU5sWXLPwKLFkjm4RHAHHnaK+98d+xNCQ0qOScpGiNSRcdkHid8T6O7qPO93EgjRY lHg3nsgtE29h2B5o6zlXtdaGzvMFUHx0m8NNRXx6z3HJ49EahuM3q4JvmFqyXhHwR9GN Iuh3rkFtiZcM3we+BdnAa5CQTRsAqPuEYhO20X9GVEKiXxoz67oIv8hgwX3T+7Gp1DS4 tLdQ== X-Forwarded-Encrypted: i=1; AFNElJ9DKIe0QPU4nh1SkH4WrXmXJ9BiBZBrMeJ8C/o472YrHO+o7vpdg7J5is4LoaCt/z/VAhKb5HSDUAWry3A=@vger.kernel.org X-Gm-Message-State: AOJu0YzJvz0bIjiA+BNXZVMeQp9lnb96uBdeplx6CujIGAs5Tw33b2wx mpRX5AiuGqC4PBSx+ReUl7G5GIDmxVOojmp021wwIv59tjpS2IHQXmdwOvuc2/mP3/E= X-Gm-Gg: Acq92OEb/t0HZfWntJmxdJsl9K9GpNXT/z1Gh4ksOVUS1tFOCUPlDpx2ZrZtEo6Q9qn /xjf7qFhCYVyWMsNvap4DxxzPAjSzqam/OAS449kwzHhYjmV4SZpL0c54lizVcPjdM16Z2GFsnn 2lX7YZxSP7iSDU5IzgiV/gnHYTKphIK1NvtzUmafUKfG42jn6Ua2J7uKszKRMFzgqZ4gVWOZKnJ QoUK7HPWpiy20iWiS9URwq22u5J3OY8/ELLsd3DPEHD9cBlQPmO2RWyFue9smulkHRvHthqaxC9 QO0MGqYjymXqnk7sheY9hdyNPBIpgKRf8WkmS24BroRMlK3t+gupoZjzmpcfHzILf+HF+Vr1YXl fE2sJzUiGakz/IUiv3fctspMsNYKCFKEcLW5f1VO+5NZxeZxQI+b488pfEW6Gz9heRTAVMVzKbe JROfA2imnEpPQ/lop2rhnfGYwUHKM2GMraYDPv9G1sqpT7tArEHJptYMpEGxjQQZc7cZCOp5Vdk 5H++jY= X-Received: by 2002:a05:600c:8b6e:b0:48a:6fd4:d3d3 with SMTP id 5b1f17b1804b1-48fe61ed21amr247255575e9.20.1779112889228; Mon, 18 May 2026 07:01:29 -0700 (PDT) Received: from ?IPV6:2a01:e0a:106d:1080:1029:e3c5:362e:1250? ([2a01:e0a:106d:1080:1029:e3c5:362e:1250]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48fe53767ecsm234857745e9.10.2026.05.18.07.01.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 May 2026 07:01:28 -0700 (PDT) Message-ID: Date: Mon, 18 May 2026 16:01:27 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Neil Armstrong Reply-To: Neil Armstrong Subject: Re: [PATCH v3 13/13] drm/panel-simple: Fix powertip,ph800480t013-idf02 timings To: Tomi Valkeinen , Marek Vasut , Andrzej Hajda , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dave Stevenson References: <20260513-tc358762-fixes-v3-0-6698b55008b9@ideasonboard.com> <20260513-tc358762-fixes-v3-13-6698b55008b9@ideasonboard.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260513-tc358762-fixes-v3-13-6698b55008b9@ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/13/26 15:10, Tomi Valkeinen wrote: > The powertip,ph800480t013-idf02 panel was added to panel-simple, and > with the tc358762 driver, enabled the use of RaspberryPi 7" DSI display. > > I have been testing the RaspberryPi 7" DSI display module with TI's > BeagleY-AI, and I can't get a good image with the current panel timings. > > It's been quite difficult to figure out exactly what are the issues. > Possibly RPi DSI TX and TI DSI TX have their own quirks which affect > this also. However, now that the tc358762 driver has been fixed wrt. the > signal timings it sends, this patch makes the panel work fine on > BeagleY-AI. > > Fix the timings according to the datasheet: > > - hsw + hbp must equal to 46. This was correct in the timings, but the > hsw was very tight, and at least Cadence DSI has trouble with such > short hsync. Increase hsw to the middle of the hsw range from the > datasheet, and decrease hbp accordingly. > - vsw + vbp must equal to 23. This was 24, resulting in slight shift in > the image. > - The upstream timings seemed to aim for 50 fps, but this is a normal 60 > fps panel, so adjust the timings to get 60 fps. As there's no strict > rule what numbers to pick here, I used the "typical" values from panel > datasheet for pclk, hfp and vfp. However, vfp of 23 instead of the > datasheet's 22 give us a closer match to 60 fps, so I used that. > > Signed-off-by: Tomi Valkeinen > --- > drivers/gpu/drm/panel/panel-simple.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 91ab280869ba..16aeafd2b02e 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -4041,15 +4041,15 @@ static const struct panel_desc powertip_ph128800t006_zhc01 = { > }; > > static const struct drm_display_mode powertip_ph800480t013_idf02_mode = { > - .clock = 24750, > + .clock = 33333, > .hdisplay = 800, > - .hsync_start = 800 + 54, > - .hsync_end = 800 + 54 + 2, > - .htotal = 800 + 54 + 2 + 44, > + .hsync_start = 800 + 210, > + .hsync_end = 800 + 210 + 20, > + .htotal = 800 + 210 + 20 + 26, > .vdisplay = 480, > - .vsync_start = 480 + 49, > - .vsync_end = 480 + 49 + 2, > - .vtotal = 480 + 49 + 2 + 22, > + .vsync_start = 480 + 23, > + .vsync_end = 480 + 23 + 2, > + .vtotal = 480 + 23 + 2 + 21, > .flags = DRM_MODE_FLAG_NVSYNC | DRM_MODE_FLAG_NHSYNC, > }; > > Reviewed-by: Neil Armstrong Thanks, Neil