From: Paolo Bonzini <pbonzini@redhat.com>
To: Vipin Sharma <vipinsh@google.com>, David Matlack <dmatlack@google.com>
Cc: Sean Christopherson <seanjc@google.com>,
Vitaly Kuznetsov <vkuznets@redhat.com>,
Wanpeng Li <wanpengli@tencent.com>,
Jim Mattson <jmattson@google.com>, Joerg Roedel <joro@8bytes.org>,
kvm list <kvm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86/mmu: Speed up slot_rmap_walk_next for sparsely populated rmaps
Date: Sun, 27 Mar 2022 12:40:59 +0200 [thread overview]
Message-ID: <b754fa0a-4f9e-1ea5-6c77-f2410b7f8456@redhat.com> (raw)
In-Reply-To: <CAHVum0dOfJ5HuscNq0tA6BnUJK34v4CPCTkD4piHc7FObZOsng@mail.gmail.com>
On 3/26/22 01:31, Vipin Sharma wrote:
>>> -static void slot_rmap_walk_next(struct slot_rmap_walk_iterator *iterator)
>>> +static noinline void
>>
>> What is the reason to add noinline?
>
> My understanding is that since this method is called from
> __always_inline methods, noinline will avoid gcc inlining the
> slot_rmap_walk_next in those functions and generate smaller code.
>
Iterators are written in such a way that it's way more beneficial to
inline them. After inlining, compilers replace the aggregates (in this
case, struct slot_rmap_walk_iterator) with one variable per field and
that in turn enables a lot of optimizations, so the iterators should
actually be always_inline if anything.
For the same reason I'd guess the effect on the generated code should be
small (next time please include the output of "size mmu.o"), but should
still be there. I'll do a quick check of the generated code and apply
the patch.
Paolo
next prev parent reply other threads:[~2022-03-27 10:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 23:31 Vipin Sharma
2022-03-25 23:52 ` David Matlack
2022-03-26 0:31 ` Vipin Sharma
2022-03-27 10:40 ` Paolo Bonzini [this message]
2022-03-28 19:13 ` Vipin Sharma
2022-03-28 20:29 ` Sean Christopherson
2022-04-08 19:31 ` Vipin Sharma
2022-04-18 16:29 ` Vipin Sharma
2022-04-26 20:33 ` Vipin Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b754fa0a-4f9e-1ea5-6c77-f2410b7f8456@redhat.com \
--to=pbonzini@redhat.com \
--cc=dmatlack@google.com \
--cc=jmattson@google.com \
--cc=joro@8bytes.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=seanjc@google.com \
--cc=vipinsh@google.com \
--cc=vkuznets@redhat.com \
--cc=wanpengli@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®