From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3250315E97 for ; Tue, 16 Dec 2025 00:20:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=198.175.65.17 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765844459; cv=fail; b=sZXPbS7YjlSHN/8nIybKtS7NeWYn/bzUFDo5BTqTX35CN88Nzctzqd7zcCV1p04HNqgVJqujOxB56RA/KkgHTqO40BPHuSE/8z23SM7Y6DMpl8Fc5IfsACSCwjLUAtOSOjbtpbg6qb4ppUMjmSUwtzlHo73/jdsHeedJ7UACrpY= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765844459; c=relaxed/simple; bh=T2MXUt+3ZHXaZHQf4H+HIs3Smb7/T6PJX2orEpn+k6A=; h=Message-ID:Date:Subject:To:CC:References:From:In-Reply-To: Content-Type:MIME-Version; b=C5x/34ysVXKKE+C4oaWyYxW+4Y4L9pwi6oLR5vw9MqOIpb/WYTKfJPldNhEKjG+IUrA2gtVo9NMjGyp6JWuGMiLGofiO4nMbXXoWPtcWnLFOHvGhkOjmsxi6DuBsZcjhYS4/xIIzkiFyi6mP4sm0B/I4vy3N9j1wgb9Z2eBFZBw= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Y8ZoIiId; arc=fail smtp.client-ip=198.175.65.17 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Y8ZoIiId" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1765844458; x=1797380458; h=message-id:date:subject:to:cc:references:from: in-reply-to:content-transfer-encoding:mime-version; bh=T2MXUt+3ZHXaZHQf4H+HIs3Smb7/T6PJX2orEpn+k6A=; b=Y8ZoIiIdX4mPsuHDEZAB8knCIunp59CRKs7Fk9W8FrOzOWzGWsqu5c9P ZoLy2SDr4xD0WMw6ixBeTHrL2sbWBdvIlxt9cVSI7RK7KaIXygvMIAX1k UsTFulq1XBAmqQYzRCrnHGdsEZXaAeIDq4TzrYHS1BbwRFtOZz3ILpgom 3Iqt1Dp0BWm7KLHnbwnhVtC8CqqviD0F8UtLa0hDCD8cxhoLTwUnyLwaj 7f2uX2odirQkeC4EQwgEpF6giu2mWJO3L7TcQxWpQ1z0d5voSkAlHzh+k yvzNQFV+lIuEHgmKS6x5qpEM9w9r861+bEje89L8pS8NW35/3yQlc2six Q==; X-CSE-ConnectionGUID: o0RoQ1sKQXqULW1WWu4KYg== X-CSE-MsgGUID: 9uDMIVKPQG26AZYKRSherQ== X-IronPort-AV: E=McAfee;i="6800,10657,11643"; a="67721572" X-IronPort-AV: E=Sophos;i="6.21,151,1763452800"; d="scan'208";a="67721572" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by orvoesa109.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2025 16:20:57 -0800 X-CSE-ConnectionGUID: B0fvhq5nSS+0OPS5/5LHgw== X-CSE-MsgGUID: WagCc953Q6WtuOsIdeNawQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,151,1763452800"; d="scan'208";a="202782530" Received: from orsmsx901.amr.corp.intel.com ([10.22.229.23]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Dec 2025 16:20:55 -0800 Received: from ORSMSX903.amr.corp.intel.com (10.22.229.25) by ORSMSX901.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Mon, 15 Dec 2025 16:20:55 -0800 Received: from ORSEDG903.ED.cps.intel.com (10.7.248.13) by ORSMSX903.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29 via Frontend Transport; Mon, 15 Dec 2025 16:20:55 -0800 Received: from BN1PR04CU002.outbound.protection.outlook.com (52.101.56.2) by edgegateway.intel.com (134.134.137.113) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.2562.29; Mon, 15 Dec 2025 16:20:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k8fX0b06Y9v4idZIxy673EzId4NAwajNqJJo06EJ3UZ3ljOa9tsrcnd4RjUXhKirqkEMmExzvfxku3/2sSCLs+UBChfEHXAEOFsqO940jdxjsL9gEJtLFBjHJBjCDwSbvLwKaWjRtZD+Hma6ByHx/RApOpn8JH+DErmStzqq/PEp1FipB0/mMqyk9h03yjKxeglE6/HIiJLCgJP7r+wkSAHaSvHLBbI5TNFezn/AKu/Relz0UJ2bF3dsCXgj8JL1gGylvlRQoAs/icJCGiCAtYEVrB57aGaVVZMTrvMlcAcZQFy9KDWGmYACepIWEJMXrIOJcBGHc3RUwVPeE79sqw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gWR4l6OuNKQ4e+J/hERT59yhbahCQvYKJH6kWd+Q2t4=; b=Tro3j+4snlnfAJKafz7qKsojB8zR3pircKmVhQNLz4uMianJlTRYmoTlgaIY/ErABWunVoJyzvgV+JEaONbGi9xxOoc/3ME/IJdpfyN0xcnJt0LbJd7jf0lZhcdFiHXnVh2aoNiRmfEVs6gtsFbp2p2At7bH+U3/BWJoilwa4ZXoaOuhvYMATys27UUbtoaPgpkq3weK51T5GDK60jMI1VAEHehz3s8XUwNnf7JN4moFdagNP8gRadhsRjNt3dvA2R+xACpHD0OX5lEscKZsp+k8mt6BfkgW8voZKoSPCGqcZYfOGYRDrXXq+ld9ZAaPzhrorwBQMlrnG6z+Dw/neA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) by DS7PR11MB7932.namprd11.prod.outlook.com (2603:10b6:8:e5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9412.13; Tue, 16 Dec 2025 00:20:50 +0000 Received: from DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::4af6:d44e:b6b0:fdce]) by DM4PR11MB6020.namprd11.prod.outlook.com ([fe80::4af6:d44e:b6b0:fdce%4]) with mapi id 15.20.9412.011; Tue, 16 Dec 2025 00:20:50 +0000 Message-ID: Date: Tue, 16 Dec 2025 08:20:33 +0800 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 06/23] sched/cache: Track LLC-preferred tasks per runqueue To: Peter Zijlstra , Tim Chen CC: Ingo Molnar , K Prateek Nayak , "Gautham R . Shenoy" , Vincent Guittot , Juri Lelli , "Dietmar Eggemann" , Steven Rostedt , Ben Segall , Mel Gorman , "Valentin Schneider" , Madadi Vineeth Reddy , Hillf Danton , Shrikanth Hegde , Jianyong Wu , Yangyu Chen , Tingyin Duan , Vern Hao , Vern Hao , Len Brown , Aubrey Li , Zhao Liu , Chen Yu , Adam Li , Aaron Lu , Tim Chen , References: <20251209121617.GN3707891@noisy.programming.kicks-ass.net> <88cc1be4cbcab6d52172cbbf74fdd063c5e93d98.camel@linux.intel.com> <20251210094246.GQ3707891@noisy.programming.kicks-ass.net> Content-Language: en-US From: "Chen, Yu C" In-Reply-To: <20251210094246.GQ3707891@noisy.programming.kicks-ass.net> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: SI2PR01CA0032.apcprd01.prod.exchangelabs.com (2603:1096:4:192::18) To DM4PR11MB6020.namprd11.prod.outlook.com (2603:10b6:8:61::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM4PR11MB6020:EE_|DS7PR11MB7932:EE_ X-MS-Office365-Filtering-Correlation-Id: 79168191-b251-4c96-961a-08de3c38f661 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|7416014|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?T0d3Z0R4VXhTVjRndG5yQUZHOC9XeTd0MjBZcDZaTWhuTTdQSXpiVmxCWHhK?= =?utf-8?B?U0pRUTZMVmRTRjB0RksvejhLTzNralI5YTEvWEh3Q1VJaU5SUzh3WXRNQzRP?= =?utf-8?B?TVpjV3B3NVQrcnM5QmtGSGhIb1RNZ3pMb3VJVVJ5Nm9KQzNSTDkwVWRUYVFE?= =?utf-8?B?bG9RUnhOakhqYlkzWVhkV2orcmxNaWdNWUo2bTBBR2FxY1prYUJjT0cxdm5q?= =?utf-8?B?Y3J1ZnpFNzlGL1MwRlNKZjlFcVJLTGpGd0NqOVU5V3ZkeVVEd21QVm1FL1V4?= =?utf-8?B?ZE55ZGhDSHJHR2dCamdTZURlSVdVNk1SR1QrWG9CTXN5bFl4aFdldzVlOU9n?= =?utf-8?B?SnYwZFFSZFFza1JxVDIzRGtOdzZKcjg2bmNRZXgycStDUWtWVFdRWm1RdkVH?= =?utf-8?B?ZzFlc0pQWmhCc2tIN1l4Vjh6TWZqR2p2dUV4aDNYVWdEc0F5bjJGK3M4K3JG?= =?utf-8?B?OW5oVllzYzM0V0l2ZHQrRDd4MUc4aXRHTkhVUmN3SHpPVlRjUVF0SGhEZzRJ?= =?utf-8?B?b2VicnpLbGNlS0RsRTVXeTFGYlcyM3d6WkZneGYzVjJTVUdqaDNLSjFOMWdq?= =?utf-8?B?RE0ra3VNSHI3bWNSeVhtRmNUUlhRTi9ZYXM0YkxNOG5aQTZwSlJTTDEyNm94?= =?utf-8?B?UksrWXRGS09pR2FFcE1TZWYySDZjaG9OT2kvejdZSExydTBqbm5vT0hSM1V0?= =?utf-8?B?c0F5RFZSY0ttL2dYeEg5WGs3Tmo5UTkwSi9hWC9kaXJ3cFNqU2dkMjNKc2wy?= =?utf-8?B?ckNiaHJRRXM0R1hvWWdxRVVhZVN1RTU1Z1Npb3RYQlNicFN5cGMrUUt2ZlVv?= =?utf-8?B?MXJENitjNU9PWi9jcFMySnRTVWI4RVJIZjk3TXAzZjJiRUpEWkVsZ0JncE1S?= =?utf-8?B?ZlQ2WkNoNlBoa21YN2xZcDllbXB5c3FFc013ZDBGWWRsUWRnRUsxUWZya3JZ?= =?utf-8?B?K3p3b2trOUpqN0o0R3FnZHMrcEowR09HMUoxZTdkaUc1T2ZYUS9mRXVWQ25D?= =?utf-8?B?MVhybE9TRldHOStOdVl4b1QySzRDR01jbGRnVHlyQzFuUDZaZ3NRdkMvSmJJ?= =?utf-8?B?WFU4aEJWQXAxcnkwSmhXQlEyUUF4c1N2RXdSbVR1SHhva1FPdmxKdXRuMnds?= =?utf-8?B?bkg0aFBPRm1BRlM3elByL2Y2OWpOY29sdnZSOS9NbUJLc2tENldRLzh0dTI3?= =?utf-8?B?cFlIUXRYcU5uYUZsMG5TWC95a00xc2daK3BubXJFOGpiOHVxaGlkR3JVZnl4?= =?utf-8?B?SytYWXR2RnowVGJUeGFabmF3TDVqeExKRWpVYkcrWHVRQnQxNHAzL2Z2VEF1?= =?utf-8?B?KzVSVHZLRkc4bXE2OUxpYUFLUFU1eVJ1dW42MWIxWXNwNG95OGZaZHNyVlJ4?= =?utf-8?B?a2ZxZkVKb0VzV1VUT2VzZ01INFNSNFVwVkltOUVYTkFHQkFSbzU2NFlmRjhi?= =?utf-8?B?OWhyYUxDeStpR1dQYnArbFZDU0xLa2JzWjByeDZ2d0cwZ3JXSjJtRUxUdklF?= =?utf-8?B?Ym95eFJabUl2N3VOOUxtb1JXNjdRVlgwOFkrUmRLR1hUd05abDlLV0drKzBr?= =?utf-8?B?VkU4YWhxMHpjRDJQZ1BSckl5VSsvekJOTTR3Z3dXZXo3U1B2eURlTTlzUXUx?= =?utf-8?B?dmpMMkxZSGJ3a1JhL25RVnltTVlJejhlelNqWjltK2xmYW5zTCt2Q3FmeUxu?= =?utf-8?B?UzV3NnNmTDY5bnI1RGRYWG8zNm4yTkpLQ2R1NVJRTFRad05Gd3pVdDdOcVFT?= =?utf-8?B?SVBtejNnY2U4VGtqMWRsaDNOMkw1a2oyZWozYVNYM0xmeVhEZUJLbzhCUFd1?= =?utf-8?B?K2Z3ZW1Pdy9HZmlxMDlzMFRxMnd3blNWZjZjY1R2dmJKU1ViREI3QjBpREwx?= =?utf-8?B?Rnh5NFdhaEdJNkc4L0xQZVpBSnpHU0hZMW9Zc2pYMDRtK1hmQTI3WmUrejgv?= =?utf-8?Q?IXsxSpDtYHdUkQzVyCl+qsT3zh+1fQJL?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM4PR11MB6020.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(7416014)(376014)(1800799024);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TUhtTjQvbXBpcTZwZlBLejZxbHpUQWxuL2hSdU1yd1dhZHVucW5lYlNHdEVo?= =?utf-8?B?VUVnQU5JRG5uM0F3RmJ4WE0xRlo1cjgxd1lyRXJCSDhMWEd2QjRuZ0RqeEJD?= =?utf-8?B?T0tXVjJyNVRTVEtxbVcxOGNpZVErK3M2ZmZlZGpWQ3dxbm1GeFFmZGt5K1JQ?= =?utf-8?B?VlR3NE9KWnBrYmE3cWhkcjhXRzZHTHgrYmc2RGFLdnpPYUNwTEwwN09VYzZp?= =?utf-8?B?L0ZsTkdodGRTelFIUWs5N2RlU2Y5ZEQzWk1vNnhWejJyMWU1WW5ySyt1Z0hr?= =?utf-8?B?UlkwNTNBajRTUGx2NVZrUkFUUit4Q0dWWEJvTnRCTzBFbFU2cmV5NjRDbE04?= =?utf-8?B?SWQvMGVSa0EwWjNiUVJOZTErdEZEU21IUTJXOXRLTEl4cDRDS0h5MWVrVjZM?= =?utf-8?B?bXl5V1Y3VUU2QlRxRjBqbnRUTnIvTkFLSWh0OERaQi9EbWdnbnk1WVY5MVRi?= =?utf-8?B?T2ZDYzU0cXdES1I1Nlh5ckw0SEVjNXJOWUV0L2taTDNsa295eGdzL2xUNDdF?= =?utf-8?B?ZVVNaGQxejVYNFE0cURJZFEyVzFLcjF2VDd5RTJybmVkMHMvWXk0NnhsTXBa?= =?utf-8?B?TU8yQWM3VjBDTEtGL3FORjRwWmZOZWlPMXJzWXBlNXJ5Mlc1RDRqa1M1N00y?= =?utf-8?B?bDNOOGRKVEFxNDMvQkZkMnVsbkcxSnFHaE9SV0t2MnVVZ0ZkNDVMV0NRYmZ3?= =?utf-8?B?dDFqdDZHK09iWUk0VGdWRUpxZFU1N3VlYXZ1c2c4a3g0eXFqbXBvaEdDQjVn?= =?utf-8?B?SXVJTXdhb0w3TjFkcHR1TU9jeldSaUxTaFdzbmlQLzRWYTRyUGZLYkt1aEIr?= =?utf-8?B?MDBjM21rdHNNV2VwaVNrT1FqNzVrNVE1VHpCWElCM0FrUDdUUHk4aHEwVXM4?= =?utf-8?B?elk0dDRzZ3pUMUlMKzVTaiswV3FIcXJDWExrdm5RaUhvajcwcXI1T2IyRlk5?= =?utf-8?B?a2VEY2RnZWIvQmUveXBYbytaZTVkYVduYnRZTVQ5ZnI5S3dmYWM2d0dGd3JC?= =?utf-8?B?eE1ib2g1RW1LQThPTWJlSk1kdm81aVVtTDVkenlRd3J1TjVwUjFBWnZsRWJy?= =?utf-8?B?cmsycjhHakFpSnFPT0JaM3YyRUcybEF2RGVKbWpGaGhDMy9yckN3TVg2Uytz?= =?utf-8?B?QWVlcXl5RW43WE5FMm1ISUlCWTVzUDV2aHJDclhqOU9qdWlDaWFDYXppdUtu?= =?utf-8?B?T2tPWlZ0M2gwbUdkSHJxU2gzZ2Q1YVY4bG1WRGZCcDhta0ViTlBUMmZIWlpT?= =?utf-8?B?RHVBTHV0ekdESjZXVTUxRzhReitFRmJOQk1TeVA4ZS9vWVUzYVZWYmh5OFVz?= =?utf-8?B?OGlIY1BGZCt0T1JCVklUalJqaXJHZTNQYmRZbVlrZGl5bTg0dTZYZnN1dnlP?= =?utf-8?B?LzJsc2FkdjBHNzd0cnUzRmtlRUQrWXR2eEw5VHA3TFVFV24zQVFvSnk4SjlI?= =?utf-8?B?aVVvTzRzQVJqWEh6VnlpcXNOZEtuZWtMbDZxbStZMS9SVUU0U0M0M1FaQlpq?= =?utf-8?B?dzliUHNUNHhIc2M3SFBjN2VNdnI1VC9BKzZ0K3BnOVRmTldLaDVqUHNGd2RT?= =?utf-8?B?WjhKWmh3K2lGaW85dVU2eldHSnZid3NwNUJNZjFhREs3NVNlQXhwMTVEY0cz?= =?utf-8?B?c3lDVnE5cTFWcjBUUFBpNDVIRUx3cHBHWGt6cXdoQzN2YkZtVWkzZ2tLWDRH?= =?utf-8?B?aW1WNEVzZ0R3emZpMWVBMlhHRTBBTXorZmZDUnlTS1JZWDQzcjBCTlZROXAy?= =?utf-8?B?Wm5ManNKR3JVTnFIbG5YZGptNU8wU1Q3b0NsRjlSU0VUaXZWdlV4MHNScUlm?= =?utf-8?B?M0RVSUEwcVNMcWZKQ0gweTFtK2JuVWgzbVFRcHRESmNHU1ZYRmxMYktsMkVq?= =?utf-8?B?YXczQ0N0VlVib0d1czkwOG9Hc21yTmp5QkJJUUVYTFk2czU5OU1OR1p5RjZn?= =?utf-8?B?ZXJzQ0FCOGs3enp3Mlg3RklXQldkaHRoVkJqdmYrUUZtajdiQXdaVHlZb1RJ?= =?utf-8?B?NE9iQ1VRRFhWbWZKU0ttN1d5OWREZDYxSVlKOEpYSnNLVlA5TGxYU0U1SHYz?= =?utf-8?B?OElwZWRzUnB4RmhWUU1FWGZUU3lSS1p5Zm5yMkY5Z1M2ZWlsRUNPMWZBOEJ4?= =?utf-8?Q?w/hc38ZLBRutwz1dRGLIWQLgk?= X-MS-Exchange-CrossTenant-Network-Message-Id: 79168191-b251-4c96-961a-08de3c38f661 X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6020.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Dec 2025 00:20:50.2026 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7UxOWQPGeaBOrCbQ6FAzIhPxKftJAM5nK9WBg2aKfx5o+QJmLDgjuC7hdQhErliKtsoBZA5SUfzjG5u6Zf3UUQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB7932 X-OriginatorOrg: intel.com On 12/10/2025 5:42 PM, Peter Zijlstra wrote: > On Tue, Dec 09, 2025 at 02:55:21PM -0800, Tim Chen wrote: > >>>> +static void account_llc_dequeue(struct rq *rq, struct task_struct *p) >>>> +{ >>>> + int pref_llc; >>>> + >>>> + /* >>>> + * Borrow the uc_se->active from uclamp_rq_inc_id(), >>>> + * uclamp_rq_dec_id() to avoid the unbalanced calculation >>>> + * of rq statistics. >>>> + */ >>>> + if (unlikely(!p->sched_llc_active)) >>>> + return; >>> >>> Another very confusing comment; what? Also, can you please explain (in >>> the new comment) how we get here without having llc_active set? >> >> The comment meant to say that we are using a similar mechanism as >> accounting done in uc_se->active from uclamp_rq_inc_id(). I agree that >> it confuses more than making things clearer. >> >> How about the following comment to make things clearer: >> >> /* >> * Cache aware scheduling was active when the task was enqueued. >> * Admin has disabled cache aware scheduling before task was dequeued >> * but the accounting has to be kept straight in case cache aware scheduling >> * is re-enabled. >> */ > > Is having that sched_cache_enabled() test worth it? > account_numa_{en,de}queue() don't seem to have any of this. > > OK, I think we can remove the sched_cache_enabled() check and make the account_llc_{en,de}queue() depending on CONFIG_SCHED_CACHE, so the sched_llc_active can be removed. thanks, Chenyu