From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BEF3EB64DD for ; Sat, 8 Jul 2023 20:36:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229689AbjGHUgD (ORCPT ); Sat, 8 Jul 2023 16:36:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229437AbjGHUgB (ORCPT ); Sat, 8 Jul 2023 16:36:01 -0400 Received: from mx01.omp.ru (mx01.omp.ru [90.154.21.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A8BE2E4C; Sat, 8 Jul 2023 13:35:58 -0700 (PDT) Received: from [192.168.1.103] (178.176.79.158) by msexch01.omp.ru (10.188.4.12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.986.14; Sat, 8 Jul 2023 23:35:49 +0300 Subject: Re: [PATCH] sh: Avoid using IRQ0 on SH3 and SH4 To: John Paul Adrian Glaubitz , Guenter Roeck CC: Yoshinori Sato , Rich Felker , , References: <544f02b696a0a1554efe63f799754f3e5fbfecdc.camel@physik.fu-berlin.de> From: Sergey Shtylyov Organization: Open Mobile Platform Message-ID: Date: Sat, 8 Jul 2023 23:35:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <544f02b696a0a1554efe63f799754f3e5fbfecdc.camel@physik.fu-berlin.de> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [178.176.79.158] X-ClientProxiedBy: msexch01.omp.ru (10.188.4.12) To msexch01.omp.ru (10.188.4.12) X-KSE-ServerInfo: msexch01.omp.ru, 9 X-KSE-AntiSpam-Interceptor-Info: scan successful X-KSE-AntiSpam-Version: 5.9.59, Database issued on: 07/08/2023 20:23:14 X-KSE-AntiSpam-Status: KAS_STATUS_NOT_DETECTED X-KSE-AntiSpam-Method: none X-KSE-AntiSpam-Rate: 59 X-KSE-AntiSpam-Info: Lua profiles 178491 [Jul 07 2023] X-KSE-AntiSpam-Info: Version: 5.9.59.0 X-KSE-AntiSpam-Info: Envelope from: s.shtylyov@omp.ru X-KSE-AntiSpam-Info: LuaCore: 520 520 ccb018a655251011855942a2571029252d3d69a2 X-KSE-AntiSpam-Info: {rep_avail} X-KSE-AntiSpam-Info: {Tracking_from_domain_doesnt_match_to} X-KSE-AntiSpam-Info: {relay has no DNS name} X-KSE-AntiSpam-Info: {SMTP from is not routable} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.79.158 in (user) b.barracudacentral.org} X-KSE-AntiSpam-Info: {Found in DNSBL: 178.176.79.158 in (user) dbl.spamhaus.org} X-KSE-AntiSpam-Info: d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;178.176.79.158:7.4.1,7.7.3,7.1.2;omp.ru:7.1.1;127.0.0.199:7.1.2 X-KSE-AntiSpam-Info: {iprep_blacklist} X-KSE-AntiSpam-Info: ApMailHostAddress: 178.176.79.158 X-KSE-AntiSpam-Info: {DNS response errors} X-KSE-AntiSpam-Info: Rate: 59 X-KSE-AntiSpam-Info: Status: not_detected X-KSE-AntiSpam-Info: Method: none X-KSE-AntiSpam-Info: Auth:dmarc=temperror header.from=omp.ru;spf=temperror smtp.mailfrom=omp.ru;dkim=none X-KSE-Antiphishing-Info: Clean X-KSE-Antiphishing-ScanningType: Heuristic X-KSE-Antiphishing-Method: None X-KSE-Antiphishing-Bases: 07/08/2023 20:30:00 X-KSE-Antivirus-Interceptor-Info: scan successful X-KSE-Antivirus-Info: Clean, bases: 7/8/2023 6:08:00 PM X-KSE-Attachment-Filter-Triggered-Rules: Clean X-KSE-Attachment-Filter-Triggered-Filters: Clean X-KSE-BulkMessagesFiltering-Scan-Result: InTheLimit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/6/23 5:01 PM, John Paul Adrian Glaubitz wrote: [...] >> On Thu, Jun 01, 2023 at 11:22:17PM +0300, Sergey Shtylyov wrote: >>> IRQ0 is no longer returned by platform_get_irq() and its ilk -- they now >>> return -EINVAL instead. However, the kernel code supporting SH3/4-based >>> SoCs still maps the IRQ #s starting at 0 -- modify that code to start the >>> IRQ #s from 16 instead. >>> >>> The patch should mostly affect the AP-SH4A-3A/AP-SH4AD-0A boards as they >>> indeed are using IRQ0 for the SMSC911x compatible Ethernet chip. >>> >> >> Unfortunately it also affects all sh4 emulations in qemu, and results in >> boot stalls with those. There isn't a relevant log to attach because there >> is no error message - booting just stalls until the emulation is aborted. >> >> Reverting this patch fixes the problem. >> >> Bisect log is attached for reference. Note that bisect requires applying >> commit 7497840d462c ("sh: Provide unxlate_dev_mem_ptr() in asm/io.h"), >> which is also the reason why the problem was not observed earlier since >> it was hiding behind a build failure. > > Interesting. My naive understanding was that IRQ0 is no longer usable in the > kernel as Sergey claimed. Was that not correct? According to Linus, using IRQ0 should only be allowed in the arch/ code (usually the i8253 driver). As for the platform devices, this have been finally enforced by this patch. > Adrian MBR, Sergey