From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935011AbcIOMHC (ORCPT ); Thu, 15 Sep 2016 08:07:02 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:54466 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934732AbcIOMGp (ORCPT ); Thu, 15 Sep 2016 08:06:45 -0400 Subject: Re: [PATCH 13/26] drm/omap: omap_display_timings: Use display_flags for interlace mode To: Peter Ujfalusi , , References: <20160901112320.15246-1-peter.ujfalusi@ti.com> <20160901112320.15246-14-peter.ujfalusi@ti.com> CC: , , From: Tomi Valkeinen Message-ID: Date: Thu, 15 Sep 2016 15:06:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160901112320.15246-14-peter.ujfalusi@ti.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="luBpuO1qBNNGJ0nUGJrmm1rSvITDufQ3L" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --luBpuO1qBNNGJ0nUGJrmm1rSvITDufQ3L Content-Type: multipart/mixed; boundary="NFADr64aoXgBF5A1OCGbkD7hFGFTiuokx"; protected-headers="v1" From: Tomi Valkeinen To: Peter Ujfalusi , thierry.reding@gmail.com, airlied@linux.ie Cc: daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Message-ID: Subject: Re: [PATCH 13/26] drm/omap: omap_display_timings: Use display_flags for interlace mode References: <20160901112320.15246-1-peter.ujfalusi@ti.com> <20160901112320.15246-14-peter.ujfalusi@ti.com> In-Reply-To: <20160901112320.15246-14-peter.ujfalusi@ti.com> --NFADr64aoXgBF5A1OCGbkD7hFGFTiuokx Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 01/09/16 14:23, Peter Ujfalusi wrote: > Remove the interlace member and add display_flags to omap_video_timings= to > configure the interlace mode. >=20 > Signed-off-by: Peter Ujfalusi > --- > diff --git a/drivers/gpu/drm/omapdrm/dss/omapdss.h b/drivers/gpu/drm/om= apdrm/dss/omapdss.h > index aca9d3028155..97acc340dcd5 100644 > --- a/drivers/gpu/drm/omapdrm/dss/omapdss.h > +++ b/drivers/gpu/drm/omapdrm/dss/omapdss.h > @@ -323,8 +323,6 @@ struct omap_video_timings { > enum omap_dss_signal_level vsync_level; > /* Hsync logic level */ > enum omap_dss_signal_level hsync_level; > - /* Interlaced or Progressive timings */ > - bool interlace; > /* Pixel clock edge to drive LCD data */ > enum omap_dss_signal_edge data_pclk_edge; > /* Data enable logic level */ > @@ -333,6 +331,8 @@ struct omap_video_timings { > enum omap_dss_signal_edge sync_pclk_edge; > =20 > bool double_pixel; > + > + enum display_flags flags; /* display flags */ The comment here feels a bit pointless. Tomi --NFADr64aoXgBF5A1OCGbkD7hFGFTiuokx-- --luBpuO1qBNNGJ0nUGJrmm1rSvITDufQ3L Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJX2o7OAAoJEPo9qoy8lh71E48P/iW6CjMKOuteH3AaqHNl4ur9 0snlYm0GZBtgUz8etsnv6pre+4afgVpW2n636zE9KhPmJEUnOn0H6DiNy8WplBBU Iwsu4PIi4WhlkPpPQAKykpCR1ZfbFVOsX6XhIa2SVjZ3lr9y/bpWWmWsKq/JV3Wb CrxDEGoW20bJ2u+RZeIhO/XX0rOnUxqi8zbHBaEzaUnSqUqYsX1i0YkGCk5BP9S0 nLGeRCnzIPow9oi4iGuqWuICSCO18U8YUCY5o7CpCdmTxWtqMFl3mb3L4m3CBiIL I6ZuBJt1hB6Z+E54BHO6T0iJTz4RKNB7EVVdzde1gOX/XNo5nBcGCthxDhEZlMV/ SONR/pywBsw2ufm8A8jpinfp6MeOkWoScE99f69g/B3pTZcvG/kD7SDwV04iqXyn yerTgZTeiIHhlM2pblqousoiR0lBulPWcacTgK2x2+DNE2Sf/wz0q5Qkw/ywkIs0 9SAyJgCP1YoCNatKI23qOWAPj+QOpRZp7gPvPXfZ4bdAoTHkfr7CPbbx/B2TEe02 Q4TNqNahs7eKKpzNw1x+XxBcBMpNJxusyhQm1W6p33mJeuaGMotpeL5lPxBKAdf5 6Mc6nHMkpYCAjxY1fefjxtbmzhtBLbaAM43CZGh/IuOflzj1gS+BlZEd9nEzzSwh b4hm19KenHpyrbtX7k6O =OqS3 -----END PGP SIGNATURE----- --luBpuO1qBNNGJ0nUGJrmm1rSvITDufQ3L--