From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C616C368275 for ; Wed, 6 May 2026 12:12:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778069530; cv=none; b=YhcpNy+o4ttS6dIJOiYk3SEOUimySjUjoG5E2jBkSHwyJ/oLZkuZ0OEZd24qegYMtvrK0Dym+Af8EhSZwnzlDqZXD1V8GrsWDYOxQ0ArMl0Ebe+EgrDLRw1U/IPL8ZHN+7sQ+P04CnbxPQXtkyr0be89B2WvAQsUvvNXYjMofF4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778069530; c=relaxed/simple; bh=jfaWp8ixppP8eOYKh4ns9ulx+xbxaJZiancW/JSA0pI=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=lzfsNoxIm+dG94XW3agB8DV8KaM+Yohu6xZ8IRvRT3Z1JDOWn7Ri6Di4GI9riaC9/jrgzIrD4eltVnx/A5gV6h0ugTOY4OCHg2ZjQmMiJ+WJFnIkJ1EG8uqXKIxHa/SbJHWnMxx5b5GA2K/7xPOXGHr5M4fxhPamzWUEvT2mcXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=nrJ5hFOX; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nrJ5hFOX" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-43d75312379so556484f8f.1 for ; Wed, 06 May 2026 05:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1778069527; x=1778674327; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ws629W1+/OZhaFCmlUMwKh3w716Ok42C3gMHhe8mbxc=; b=nrJ5hFOXuaflWcEsoXo3dxTHpuS3ftE95u7k7KXNz4zU4Actt5qBQIG762MMZa6AMF ptUyu9wv2fRxgViXB2h/JD/xyEVBQhaYcLTG+w298GRJ4FkvSIyYGLhPKH2hx4oolsfd RMawdbH8hJtcaSmlMPVGXsnONWoDQd28L5imB1FB0bgONq+ev3H9P35u8cTUIYDIVxUt PgZjgsgHKB/HlpXwnAMSBOkcL7lNbRxwlQ1CJBZ8c30ZGiIqBNgXP24dVEfpIMpZI/u+ rdoUgYGfj5y8ApxZtFR2++zZlGeujcePYZdROaD372tlww6+VOAEHxHMJqmry2OhqY+h 9xWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778069527; x=1778674327; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ws629W1+/OZhaFCmlUMwKh3w716Ok42C3gMHhe8mbxc=; b=OmKPv/2zV2aZ+F1OdfTXpBriFYcPqO6ypoIfBHz02zSd9DS7JqNAvQWUpqoZj78/DX vEEAFNkm3ft8epmxMnyN/kXA1SEJXLASFrvmm8dTXBqmYjGTyL00sIyihZBdPCFS2IyH TE6iJxkoeFkaXC2GmxNLBC2ccXSvTzxbqpJyhJTqInKxfckknOTt+M6Yrr8Qcw0NikUi Phcj4daio28dhPQU80yoI4pdoGQuRfZQMu06tF3FfV3iGdIwPQw9RUSmTbWV+1g4TX7O PyinhIdHGulx1dlWCCf2RHXAspxyyBYTmY0MeyHffsvI25rk7N8wDWUht+PinIm//O7d Q6vQ== X-Forwarded-Encrypted: i=1; AFNElJ9ab+piFtWPbYB/vip0fIo+W2NrNWFhedEvmYn79IoKCJVZjoDhovQs0fCtHlBtz7bRi0lc4qtxblA4luQ=@vger.kernel.org X-Gm-Message-State: AOJu0YwoPCXJC2yRprWTf/9NJ4PaucNlitM9uspxEhz56zHRZCBQjS6D OLT3I0bkFVj41DPAiW3b0W7rn19pP8ONIY9a9f6MXZVKI2MlBWlZqJ8Wg/1oUGKfNOk= X-Gm-Gg: AeBDievlIWqhSIhJrp2gyirpoz+1M9+13t5BBiNA99y3jU+50L520m9Oj0/k7BhFQr/ e5J/y9FRqngZyooD09mEuKyCusLR6QqpNKavsH0JbBn5BThl2PptChs8ftLTQRa3DVLELN3TiT+ OrHBwL2NqU0f6mR374TXhRaC+QQnoxZby/uXdWW1aRRoXomDHtGyC1EvuF2nff6awy7jCAL4ZZE ZuXzyOzl3jvUp9ILnuLBtGr66pqcrrqJIqaKb4qbB9FdTgscaRlw76AHZjwwuKC6lBp2tDQ4XUh o0848UJ6BdU1S1UoOaCTjvlOvpWXNqtbJXUKLfPXYPl/fgwdjfUvxHNcm8okoGy4rfCmano6jV3 iGrVyJct27QqHjt88xKhe/IjldJpUS/Yu3S23qVqfxh/Hw2DxbHvDwN4YYGHZB8HSjO6KcHKBem nDeaqImDQe0jQrHqEwWVVNUeHoagppHIw12tbbz6ney7I= X-Received: by 2002:a5d:64c5:0:b0:43e:a75e:352 with SMTP id ffacd0b85a97d-45162570080mr4694269f8f.4.1778069526968; Wed, 06 May 2026 05:12:06 -0700 (PDT) Received: from [10.11.12.108] ([79.115.63.228]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45052a488d8sm12000365f8f.12.2026.05.06.05.12.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 May 2026 05:12:06 -0700 (PDT) Message-ID: Date: Wed, 6 May 2026 15:11:58 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: exynos850: Add SRAM node To: Alexey Klimov , Krzysztof Kozlowski , Rob Herring , Krzysztof Kozlowski Cc: linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Sam Protsenko , Conor Dooley , Alim Akhtar References: <20260413-exynos850_sram-v1-1-7fda5b7fb7d4@linaro.org> <2ff077e1-8983-4a41-bb21-5e4140545aa3@kernel.org> <4c6a92e0-15a1-4f82-afc9-542f5ad9d2df@kernel.org> Content-Language: en-US From: Tudor Ambarus In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 4/30/26 6:37 PM, Alexey Klimov wrote: > On Tue Apr 14, 2026 at 10:08 AM BST, Krzysztof Kozlowski wrote: >> On 14/04/2026 11:00, Alexey Klimov wrote: >>> On Mon Apr 13, 2026 at 4:23 PM BST, Krzysztof Kozlowski wrote: >>>> On 13/04/2026 16:52, Alexey Klimov wrote: >>>>> SRAM is used by the ACPM protocol to retrieve the ACPM channels >>>>> information and configuration data. Add the SRAM node. >>>>> >>>>> Signed-off-by: Alexey Klimov >>>>> --- >>>>> arch/arm64/boot/dts/exynos/exynos850.dtsi | 8 ++++++++ >>>>> 1 file changed, 8 insertions(+) >>>>> >>>>> diff --git a/arch/arm64/boot/dts/exynos/exynos850.dtsi b/arch/arm64/boot/dts/exynos/exynos850.dtsi >>>>> index cb55015c8dce..cf4a6168846c 100644 >>>>> --- a/arch/arm64/boot/dts/exynos/exynos850.dtsi >>>>> +++ b/arch/arm64/boot/dts/exynos/exynos850.dtsi >>>>> @@ -910,6 +910,14 @@ spi_2: spi@11d20000 { >>>>> }; >>>>> }; >>>>> }; >>>>> + >>>>> + apm_sram: sram@2039000 { >>>>> + compatible = "mmio-sram"; >>>>> + reg = <0x0 0x2039000 0x40000>; >>>>> + #address-cells = <1>; >>>>> + #size-cells = <1>; >>>>> + ranges = <0x0 0x0 0x2039000 0x40000>; >>>> >>>> You miss here children. >>> >>> Thank you! I guess I should convert it to smth like this: >>> >>> apm_sram: sram@2039000 { >>> compatible = "mmio-sram"; >>> reg = <0x0 0x2039000 0x40000>; >>> ranges = <0x0 0x0 0x2039000 0x40000>; >>> #address-cells = <1>; >>> #size-cells = <1>; >>> >>> acpm_sram_region: sram-section@0 { >>> reg = <0x0 0x40000>; >> >> This covers entire block, so feels pointless. Maybe requirement of >> children should be dropped. What's the point of having children? Why >> does the driver need them? > > Thinking further about this. I was looking at the schema file and > different commits and it the right approach could be: > > - add separate compatible for mmio-sram region for this case. Similar > to scmi and scpi, i'd say it should be "exynos,acpm-sram" or > "samsung,acpm-sram"; > > - update schema sram.yaml to exclude requirement for having child nodes > and properties like ranges, address and size cells > Similar like in commit, for instance, git show d0fe6491ddd22 > (or git show 2d4a22e79a5fd). this works fine, but only if the sram is consumed as a whole, and only by ACPM. Is this the case for exynos850? Cheers, ta