From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D9FB381E87 for ; Fri, 28 Aug 2026 19:07:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787944054; cv=none; b=hOapcz95VL6vySAHSRNXovTrVT4nF2qIwhoaUxwzvBALae9sjoBerEN4A6UiMXBAiFP9FTn3FgbBa62jrmWCk/v1uZmigRKF9cvzDxUB6T+obZu/9DxFXjWu97FxXHojAw9ljNgnjGKQeU6JpUTFSygHSzKdHS0xg0M7DF8ryY8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787944054; c=relaxed/simple; bh=g8Uk7dadfnDolxcTGbSvab1I//fUChPncO4C07pseF8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GkJs3ZobIQVrFfE+1opmggJ5EMn/ghGpMsPcFkTl4kUF/Ybqo5TEa5oPnlAzmUbn//ZOYJPEJfy+2DNXOrGmIbb/MN8+WSVHADPM5xy204jO2BijVu0k9nasV/G9buRZo87JLiKibF5eNttWNXxGJYz9gKBoEdnBMkGb6BTJI/A= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Dv6zr27+; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=caZmOxjM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Dv6zr27+"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="caZmOxjM" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 67SJ7BJu3675258 for ; Fri, 28 Aug 2026 19:07:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 1s2kjAf1yML7/2kxSNB22gighqjpflXP5UiWdef4W/Q=; b=Dv6zr27+cCL2KOoO I5pdhB7ZvHhjoocoyoQgdQ8V/e9OZsHPK9nWu+YCPmJS77rC9q44TICj3JaPMOWJ 1Oea3OVJtGR/3+1eJK3+ly4TG62IWoKJflCBYP4iW9MZempqyN4f4vu/TWn/nj0q rYf3+Qme3nM7FHqdx71s12kjEkb3AiOICskesM89tpLNTsLTmj1KJdjLd9GMatx/ PnRVdYn8C5puO5fSnngZDgAHmbPWzv5N/4q5txZzpZ75VpwR/F2sKznje7ffQIl1 eqF0OW5uG2hghhGdPFQrcZKFOzy4kUwyknAVj6m0qAl44y/wTS42BxV44VFLGy/k SRpzPQ== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gb3hs3a6c-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 28 Aug 2026 19:07:31 +0000 (GMT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51e9d892f0dso3513491cf.2 for ; Fri, 28 Aug 2026 12:07:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1787944051; x=1788548851; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1s2kjAf1yML7/2kxSNB22gighqjpflXP5UiWdef4W/Q=; b=caZmOxjMY0213kzOaiB/w0UkD14iZJhQzQ9qZsI5IGAQGTBBNiccSHmdNg6uHEVGAb gRVKqGZrbT2YT5xCjuNotR6aB8ZZD0Z+0sz4umbEw6/queubumg12RINX1UzxOvyjcId 4XZPr7O19a/ZRq3CEfATvrquABxrLTU1b3rNxH6nTtde8MLwLYOORdpc+51Lh6GD0ma6 gnhNYnKl1htDyEliDIHJrRz46t/sNwUKpGxY7+jzONVovedo4CoIvm7JbZSx0Ed4iU9s 35RfOhvaCQg4JHQnRO8+c9KTMC7e/BEq8SJXFF1pg536GZZ5AEmFEJs/gsInHBMrx1JA ekrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1787944051; x=1788548851; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=1s2kjAf1yML7/2kxSNB22gighqjpflXP5UiWdef4W/Q=; b=Xjzt/klkM+0wfv4sWizeTMk+fW5NSxFDrQvjmZK5yEGPA/xZ/o5j0v0Thf4oKn4EUg JtNtp+4MI6MfgzThA8mwn7Gcy6kj4e42+aDQxW+Zrf16jodGGhcbiXRYkEsDb1Cj1AZ5 FB/YKbfgQrsfMkPIwFtwxuYxMCb5mWGed3L9bySSBTFILngZgZaRjYddf8S3xJHZC+0k UqnLOILVfBexUkuBpF5kU9CzfMVEujC+K9tW9+uS/fHXF4un7viNDPmAvMJPbQyOjiQ6 U2/1FYUlkIUeHyriD1pvoP+cyPQ5MGL2FqWWPJd2gUU4RZpS2OdMlwn7n+8hEqphSdgr TPjg== X-Forwarded-Encrypted: i=1; AHgh+RrvOL5HLnO446o6aYTnKdVpdxLGbGF1iOVvzvByhXnIH/mhap4qnj4Z1NPCJ3k72m1N60Cw93l/tT5FyGQ=@vger.kernel.org X-Gm-Message-State: AFuF++n6NER3d6fta/B/T4JxNhxkSY4bEnzvT6nmh0Lwh05eZL8eoRFL EkNqXSNCc3INO6kWO++xQ1n8xoQj1jenmcslAEPtsvB3wlMoBt1oqM1UwZYefwtBxnToE6qBKmQ wgmnIu4xaME1TT0UQDuJoddOLqWLTWdxaS+7ILooOzpaUDuOPXRtG3AB+Jol+2FPAFrU= X-Gm-Gg: AR+sD109m+YOuVYXOFysilxOqMJlszV8FuNsK0nW4rMGSPNwhJB/dU0S8z8SPYkWkd4 JwoSS9kXktFTA8T3UcEW5ss+qjweQGsMqWBOC1XK2VeX7mQmuVG7CAHM5Ztj2KfrZ3tZPqPHRql K/vCYyA3aBvXDsUroojA+dB7otsz78ZU3IvJUxXflV0vk8q07jdP75beOMauuuvmDD7i8vtA62I NwEQmNUt/wN4jB8nAIChiCs+4GvL9N+cN/9czQjXGcbRTay9sUFkkIl/apkIb3YXAN/hnYyvGad z7HXCvStIFFFDekjikDEw8vXS6UGjHMSi0uiWMzMofHoLBKDJXhcCjXRkjudZl5rkWVyULTi77y y2+L/Q83fmHJFipL46cIF3uY= X-Received: by 2002:ac8:5d14:0:b0:51c:10e9:ec47 with SMTP id d75a77b69052e-52fb96aece6mr73034841cf.5.1787944051248; Fri, 28 Aug 2026 12:07:31 -0700 (PDT) X-Received: by 2002:ac8:5d14:0:b0:51c:10e9:ec47 with SMTP id d75a77b69052e-52fb96aece6mr73034181cf.5.1787944050739; Fri, 28 Aug 2026 12:07:30 -0700 (PDT) Received: from [192.168.120.193] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-6a611c38cbbsm760796a12.16.2026.08.28.12.07.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Aug 2026 12:07:28 -0700 (PDT) Message-ID: Date: Fri, 28 Aug 2026 21:07:24 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 2/3] arm64: dts: qcom: kodiak: enable inline crypto engine for SDHC To: Abel Vesa Cc: Kuldeep Singh , Ulf Hansson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , cros-qcom-dts-watchers@chromium.org, linux-arm-msm@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Neeraj Soni References: <20260629-ice_emmc_support-v8-0-1a26e1717b85@oss.qualcomm.com> <20260629-ice_emmc_support-v8-2-1a26e1717b85@oss.qualcomm.com> <1a0b91c6-5e17-4330-a8ab-ac14d3339024@oss.qualcomm.com> <56ab63c3-4288-45f7-bfea-d40046437a9f@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=XKYAjwhE c=1 sm=1 tr=0 ts=6a91dc73 cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=YurnkI7Am4XMX7TwPFgA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODI4MDE2NiBTYWx0ZWRfX/hmOFBdOm82R DHUds43QxfonUseVdqHumoTm6dBwucZX21qYpQGGX9yzE1MwjjFFkVTJP8vzDBeQaP53b2qgoWR I8opq33HXFFHtAnoyl0I0njRKn+o7ULvBT0gUg5jOq6RFbhGWXDKrrc/S+bKMYww/spN0Eey7Ra tg4WV7sHeof6QrOkucJhr4BxgfsWXAgrDlo5HSNNj6pwO2xzVlriM+eM0XBeHcziz/qKxgic4tX JNqBayRi+GFldOX5gXDAvi1PvQKlCDdMedyBrVePVTPWuxtypoxa539FZHjrUZDoxCtOJ1SUEI4 3dEs3XMoHv7Ul4GmKdkK+f2HCC1jRTCNLQrVSYyUaUvTvvD8LIwY6MYMqKRRVE5X+Bx6MVcIiiF QtF+EYd8jeEDW3OOQvV/y+QjNI/sK94rNngZROUK5tmS8howGjXGxZyinz/xiytAQFAsENT9Q7D 1/kbDQ0WHIGkXAfaFSA== X-Proofpoint-Spam-Info: AW1haW4tMjYwODI4MDE2NiBTYWx0ZWRfX5rNYb+xqc5qD AbXpdowYkQBSu3RrdssWKYbZB9Z7cuo0Ajf3WISs1YvxF0K7VcFC+6JubiVrmzOhhq9WcgWxQKn 8oldcGd+uJI2uyL/D+tUGHmfJZ2jov8= X-Proofpoint-GUID: q_qjpBl9KQan5rwWpYPq_iyAGaq8nJEk X-Proofpoint-ORIG-GUID: q_qjpBl9KQan5rwWpYPq_iyAGaq8nJEk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-28_06,2026-08-27_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 priorityscore=1501 bulkscore=0 adultscore=0 phishscore=0 suspectscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608280166 On 8/28/26 2:57 PM, Abel Vesa wrote: > On 26-06-30 13:25:13, Konrad Dybcio wrote: >> On 6/30/26 12:23 PM, Kuldeep Singh wrote: >>>> qcom_ice_probe() >>>> -> qcom_ice_create() >>>> -> devm_clk_get_optional_enabled() [...] >> On the developer/customer experience side, would you expect having to >> manually enable what's essentially a sub-feature of the storage media >> on every single board? > > Wait, don't we do that for display nodes anyway ? > > Also there might be a case where you just don't want the ICE enabled. I can think of literally none.. > So I suggest we disable the ICE by default and enable it only on boards > where there is a consumer. > > We don't normally leave stuff enabled just because runtime PM will > disabled it for us. We should because the hardware is in a state that's otherwise unknown to Linux, I've been trying to push that forward, but many things currently can't be enabled without side effects. With the right drivers in place, the hw can be safely powered off or at least parked, instead of letting it spin in whatever state the bootloader has left it in. Konrad