From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD748C433FE for ; Fri, 11 Nov 2022 08:11:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233144AbiKKILG (ORCPT ); Fri, 11 Nov 2022 03:11:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42536 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233098AbiKKIKn (ORCPT ); Fri, 11 Nov 2022 03:10:43 -0500 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5BDAA78318 for ; Fri, 11 Nov 2022 00:10:42 -0800 (PST) Received: by mail-lf1-x12b.google.com with SMTP id b3so7268869lfv.2 for ; Fri, 11 Nov 2022 00:10:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MzAy5meGjwQ/InrlG2I98BKggIHGTjNBmOG6pUO6dkc=; b=Xcw9On4h27nqAtUbOOYseoVPLsY2bnsEhPNaKyOn+TVR9n9njJAGcVymZzpkYfnhbv ZJMonHYchoaWGeFvKk+jggNPnFf2wNL8ggpoxFvz8X1fL5jgZ/nigPywRAQwCpt63DLs Q1DdxWObKNQc5yiWArbq4LI4wRYhlnpSB4r85v7jw7AaLgZ2+QQ3DTC6J8urLzlQPqva HUT3fvdP7eYbbOJe4Dr9x1ha0D+nb/uSCUPYWg5xhrnnwhwjdwEphzDUsVdnq1MstSMj BfXSosIK0+fwt7BsL+JGCzbMYW1+0/aPejqTDDzmK+e4dq2r4rzqjKQvDJHY9ifXxsNa y3ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=MzAy5meGjwQ/InrlG2I98BKggIHGTjNBmOG6pUO6dkc=; b=xcw9vC78rPvkrOKw/wziegOgzYIqNaehJiXY8zOjahcgzOGS5Sp5HYCttuEg1jyqyc dHYTLXtxeQVXg07g4OIFMQP8zpYtrfQTeLIcb1WLU0R1VCOesjxdJF7E2tgF85aeMuCx 8fj8GyXlf7O/tptHt8xHsrD3yfw+id4YxHcG94DHjYBQpNJ5G9vIWwARd1u5vObi22RB QgmTiAZn9jP/TBqQvuXF/KlGC7IuPdiTQsWD8BzXgldVs5uKTIFFfsAn6GuEekv4zwug 0r9LQNpQw501va8GKw3h9Mawo2nZrllYv9hoiJeMU5BgLnqQ2CVpCxhFv1i+MpvscQ9F RGcg== X-Gm-Message-State: ANoB5plB9MYFEjGlO7MQQ+IoLyuEDGKnDCL+GdtvoccfgosnHpoVO/N5 lGjLxxQcO7DXK8Tcan40uC89Sg== X-Google-Smtp-Source: AA0mqf6NiswRKjxe+tlWxl+vlzIGWnrSa2ODCTbyizH2znT83X8Z+gfAEU3Uluz0WJ0ykTWLAeiKtQ== X-Received: by 2002:ac2:48a7:0:b0:4b3:9fcb:df92 with SMTP id u7-20020ac248a7000000b004b39fcbdf92mr341884lfg.607.1668154240758; Fri, 11 Nov 2022 00:10:40 -0800 (PST) Received: from [192.168.0.20] (088156142199.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.199]) by smtp.gmail.com with ESMTPSA id m1-20020a056512114100b004ac6a444b26sm209790lfg.141.2022.11.11.00.10.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Nov 2022 00:10:40 -0800 (PST) Message-ID: Date: Fri, 11 Nov 2022 09:10:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [Patch v3 3/3] ARM: dts: exynos: Rename compatible string property from version to SoC specific Content-Language: en-US To: Aakarsh Jain , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Cc: m.szyprowski@samsung.com, andrzej.hajda@intel.com, mchehab@kernel.org, hverkuil-cisco@xs4all.nl, ezequiel@vanguardiasur.com.ar, jernej.skrabec@gmail.com, benjamin.gaignard@collabora.com, krzysztof.kozlowski+dt@linaro.org, stanimir.varbanov@linaro.org, dillon.minfei@gmail.com, david.plowman@raspberrypi.com, mark.rutland@arm.com, robh+dt@kernel.org, krzk+dt@kernel.org, andi@etezian.org, alim.akhtar@samsung.com, aswani.reddy@samsung.com, pankaj.dubey@samsung.com, smitha.t@samsung.com References: <20221111032337.79219-1-aakarsh.jain@samsung.com> <20221111032337.79219-4-aakarsh.jain@samsung.com> From: Krzysztof Kozlowski In-Reply-To: <20221111032337.79219-4-aakarsh.jain@samsung.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/11/2022 04:23, Aakarsh Jain wrote: > commit "752d3a23d1f68de87e3c" which adds MFC codec device node > for exynos3250 SoC. Since exynos3250.dtsi and exynos5420.dtsi are > using same compatible string as "samsung,mfc-v7" but their > node properties are different.As both SoCs have MFC v7 hardware > module but with different clock hierarchy and complexity. > So renaming compatible string from version specific to SoC based. > > Reviewed-by: Tommaso Merciai > Suggested-by: Alim Akhtar > Signed-off-by: Aakarsh Jain > --- > arch/arm/boot/dts/exynos3250.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/exynos3250.dtsi b/arch/arm/boot/dts/exynos3250.dtsi > index 326b9e0ed8d3..98105c64f7d9 100644 > --- a/arch/arm/boot/dts/exynos3250.dtsi > +++ b/arch/arm/boot/dts/exynos3250.dtsi > @@ -485,7 +485,7 @@ > }; > > mfc: codec@13400000 { > - compatible = "samsung,mfc-v7"; > + compatible = "samsung,exynos3250-mfc"; No improvements. Changeset is non-bisectable. I said it in v1, then in v2. So now third time... Don't send a new version if you are not going to fix it or resolve discussion. In cover letter you said "Addressed review comments from Krzysztof Kozlowski", so please explain me, how did you resolve my comments about fallback for this patch and for bindings patch? Best regards, Krzysztof