From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752308AbdH3R1x (ORCPT ); Wed, 30 Aug 2017 13:27:53 -0400 Received: from mailout.easymail.ca ([64.68.200.34]:45706 "EHLO mailout.easymail.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752220AbdH3R1v (ORCPT ); Wed, 30 Aug 2017 13:27:51 -0400 Reply-To: shuah@kernel.org Subject: Re: [PATCH] usbip: vhci-hcd: make vhci_hc_driver const To: Bhumika Goyal , julia.lawall@lip6.fr, valentina.manea.m@gmail.com, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org References: <1504097543-15089-1-git-send-email-bhumirks@gmail.com> Cc: Shuah Khan , Shuah Khan From: Shuah Khan Message-ID: Date: Wed, 30 Aug 2017 11:27:38 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1504097543-15089-1-git-send-email-bhumirks@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/30/2017 06:52 AM, Bhumika Goyal wrote: > Make this const as it is not modified anywhere. > > Signed-off-by: Bhumika Goyal > --- > drivers/usb/usbip/vhci_hcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/usbip/vhci_hcd.c b/drivers/usb/usbip/vhci_hcd.c > index c747623..11b9a22 100644 > --- a/drivers/usb/usbip/vhci_hcd.c > +++ b/drivers/usb/usbip/vhci_hcd.c > @@ -1274,7 +1274,7 @@ static int vhci_free_streams(struct usb_hcd *hcd, struct usb_device *udev, > return 0; > } > > -static struct hc_driver vhci_hc_driver = { > +static const struct hc_driver vhci_hc_driver = { > .description = driver_name, > .product_desc = driver_desc, > .hcd_priv_size = sizeof(struct vhci_hcd), > Looks good to me. Acked-by: Shuah Khan thanks, -- Shuah