mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: iseletsk@cloudlinux.com
To: fa.linux.kernel@googlegroups.com
Cc: linux-kernel@vger.kernel.org, rusty@rustcorp.com.au,
	Matthew Garrett <mjg59@srcf.ucam.org>,
	Alex Lyashkov <umka@cloudlinux.com>
Subject: Re: [PATCH] Taint kernel when lve module is loaded
Date: Sat, 23 Jun 2012 08:07:12 -0700 (PDT)	[thread overview]
Message-ID: <b770341d-e1e3-4d57-b283-3d8ff92b0d36@googlegroups.com> (raw)
In-Reply-To: <fa.WTHIDfGYg3w7zn9rxlDshNfnPtI@ifi.uio.no>

Hello Everyone,

I am very sorry about this situation. It was my oversight. We planned to close source the module, and we will do it later on. Yet, it looks like one of our developers missed the point -- and did things incorrectly.

Please, give us two-three weeks to straighten things out. By the end of three weeks I plan to have source RPMs with the GPLed version of the modules available in our source repositories.

Later on we will have new module that is not GPL released.

Once again -- I am sorry about the incident. We haven't planned to deceive anyone. This was more of an internal miscommunication then anything else.


I appreciate your understanding,
Igor Seletskiy
CEO of CloudLinux

On Friday, June 22, 2012 1:50:24 PM UTC-4, Matthew Garrett wrote:
> Cloudlinux have a product called lve that includes a kernel module. This
> was previously GPLed but is now under a proprietary license, but the
> module continues to declare MODULE_LICENSE("GPL") and makes use of some
> EXPORT_SYMBOL_GPL symbols. Forcibly taint it in order to avoid this.
> 
> Signed-off-by: Matthew Garrett <mjg59@srcf.ucam.org>
> Cc: Alex Lyashkov <umka@cloudlinux.com>
> ---
>  kernel/module.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/kernel/module.c b/kernel/module.c
> index 4edbd9c..9ad9ee9 100644
> --- a/kernel/module.c
> +++ b/kernel/module.c
> @@ -2730,6 +2730,10 @@ static int check_module_license_and_versions(struct module *mod)
>  	if (strcmp(mod->name, "driverloader") == 0)
>  		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
>  
> +	/* lve claims to be GPL but upstream won't provide source */
> +	if (strcmp(mod->name, "lve") == 0)
> +		add_taint_module(mod, TAINT_PROPRIETARY_MODULE);
> +
>  #ifdef CONFIG_MODVERSIONS
>  	if ((mod->num_syms && !mod->crcs)
>  	    || (mod->num_gpl_syms && !mod->gpl_crcs)
> -- 
> 1.7.10.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


       reply	other threads:[~2012-06-23 17:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <fa.WTHIDfGYg3w7zn9rxlDshNfnPtI@ifi.uio.no>
2012-06-23 15:07 ` iseletsk [this message]
2012-06-24  6:39   ` Greg KH
2012-06-24  7:33   ` Mike Galbraith
     [not found] ` <fa.lxvUw3/2JBxq1zvQzI4sJk8pEOQ@ifi.uio.no>
     [not found]   ` <fa.Fdbx7aeDSXKMF/2ajG0IUf0AAKs@ifi.uio.no>
     [not found]     ` <fa.TAjdtaR/BMl+PZAWwtAit9BevAo@ifi.uio.no>
     [not found]       ` <fa.cm6Pl6ITE2qRnrdz/DXqaOSgExs@ifi.uio.no>
2012-06-23 19:26         ` iseletsk
2012-06-24  6:35           ` Greg KH
     [not found]             ` <CA+-XxSG8mpERvUwKgG4M8=ZuSd3P+ZYfw5mL3R4zLTAYGPW3Mw@mail.gmail.com>
2012-07-11 15:26               ` Greg KH
2012-06-22 17:49 Matthew Garrett
2012-06-22 18:43 ` Greg KH
2012-06-22 18:51   ` Matthew Garrett
2012-06-22 19:22     ` Greg KH
2012-06-22 19:43       ` Greg KH
2012-06-22 19:09 ` richard -rw- weinberger
2012-06-22 19:40   ` Greg KH
2012-06-23  0:00 ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b770341d-e1e3-4d57-b283-3d8ff92b0d36@googlegroups.com \
    --to=iseletsk@cloudlinux.com \
    --cc=fa.linux.kernel@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg59@srcf.ucam.org \
    --cc=rusty@rustcorp.com.au \
    --cc=umka@cloudlinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®