mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michael Straube <straube.linux@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: gregkh@linuxfoundation.org, hdegoede@redhat.com,
	Larry.Finger@lwfinger.net, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] staging: rtl8723bs: move rtw_init_mlme_timer to core/rtw_mlme.c
Date: Fri, 1 Aug 2025 09:19:09 +0200	[thread overview]
Message-ID: <b77087d4-a80d-46e6-8d96-3ce976bc70d7@gmail.com> (raw)
In-Reply-To: <05bc4742-ef57-482b-a2af-23a7f238fd69@suswa.mountain>

Am 31.07.25 um 17:59 schrieb Dan Carpenter:
> On Wed, Jul 30, 2025 at 12:44:56PM +0200, Michael Straube wrote:
>> +static void _rtw_set_scan_deny_timer_hdl(struct timer_list *t)
>> +{
>> +	struct adapter *adapter =
>> +	timer_container_of(adapter, t, mlmepriv.set_scan_deny_timer);
> 
> You accidentally deleted a tab here.  This should have been:
> 
> 	struct adapter *adapter =
> 		timer_container_of(adapter, t, mlmepriv.set_scan_deny_timer);
> 
> regards,
> dan carpenter
> 
>> +
>> +	rtw_clear_scan_deny(adapter);
>> +}
> 
> [ snip ]
> 
>> -static void _rtw_set_scan_deny_timer_hdl(struct timer_list *t)
>> -{
>> -	struct adapter *adapter =
>> -		timer_container_of(adapter, t, mlmepriv.set_scan_deny_timer);
>> -
>> -	rtw_clear_scan_deny(adapter);
>> -}
> 

Hi Dan,
thank you for reviewing, I'll fix that up and send v2.

regards,
Michael

  reply	other threads:[~2025-08-01  7:19 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-30 10:44 [PATCH 0/8] staging: rtl8723bs: get rid of os_dep/mlme_linux.c Michael Straube
2025-07-30 10:44 ` [PATCH 1/8] staging: rtl8723bs: remove wrapper rtw_os_indicate_scan_done Michael Straube
2025-07-30 10:44 ` [PATCH 2/8] staging: rtl8723bs: move init_mlme_ext_timer to core/rtw_mlme_ext.c Michael Straube
2025-07-30 10:44 ` [PATCH 3/8] staging: rtl8723bs: move rtw_init_mlme_timer to core/rtw_mlme.c Michael Straube
2025-07-31 15:59   ` Dan Carpenter
2025-08-01  7:19     ` Michael Straube [this message]
2025-07-30 10:44 ` [PATCH 4/8] staging: rtl8723bs: remove wrapper init_addba_retry_timer Michael Straube
2025-07-30 10:44 ` [PATCH 5/8] staging: rtl8723bs: merge rtw_os_indicate_connect into rtw_indicate_connect Michael Straube
2025-07-30 10:44 ` [PATCH 6/8] staging: rtl8723bs: merge rtw_os_indicate_disconnect into rtw_indicate_disconnect Michael Straube
2025-07-30 10:45 ` [PATCH 7/8] staging: rtl8723bs: move rtw_report_sec_ie to core/rtw_mlme.c Michael Straube
2025-07-30 10:45 ` [PATCH 8/8] staging: rtl8723bs: move rtw_reset_securitypriv " Michael Straube

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b77087d4-a80d-46e6-8d96-3ce976bc70d7@gmail.com \
    --to=straube.linux@gmail.com \
    --cc=Larry.Finger@lwfinger.net \
    --cc=dan.carpenter@linaro.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hdegoede@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®