From: Vincenzo Frascino <vincenzo.frascino@arm.com>
To: Arnd Bergmann <arnd@arndb.de>, Arnd Bergmann <arnd@kernel.org>,
Daniel Scally <dan.scally@ideasonboard.com>,
Jacopo Mondi <jacopo.mondi@ideasonboard.com>,
Hans Verkuil <hverkuil+cisco@kernel.org>,
Linus Walleij <linusw@kernel.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] media: mali-c55: add padding to mali_c55_params_ccm structure
Date: Thu, 17 Sep 2026 13:54:02 +0100 [thread overview]
Message-ID: <b7718435-5b48-4598-9462-cb0d9e013881@arm.com> (raw)
In-Reply-To: <3052a817-3188-47b2-a95d-ec26aaa0d24d@app.fastmail.com>
On 16/09/2026 19:55, Arnd Bergmann wrote:
> It depends on how the structure is initialized. Depending on the compiler
> version and optimization level, a local variable declared as
>
> struct mali_c55_params_ccm v = {};
>
> may end up with uninitialized stack data in unnamed padding, but if you
> do a memset(), that should always be safe. If the fields are set individually,
> then you also have to set the __pad field, but that's not how you do it here.
Fine by me. With this:
Reviewed-by: Vincenzo Frascino <vincenzo.frascino@arm.com>
--
Regards,
Vincenzo
next prev parent reply other threads:[~2026-09-17 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 20:24 Arnd Bergmann
2026-09-16 15:43 ` Vincenzo Frascino
2026-09-16 18:55 ` Arnd Bergmann
2026-09-17 12:54 ` Vincenzo Frascino [this message]
2026-09-17 22:15 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7718435-5b48-4598-9462-cb0d9e013881@arm.com \
--to=vincenzo.frascino@arm.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=dan.scally@ideasonboard.com \
--cc=hverkuil+cisco@kernel.org \
--cc=jacopo.mondi@ideasonboard.com \
--cc=linusw@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®