From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0A162FFDEB for ; Sat, 6 Dec 2025 16:12:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765037542; cv=none; b=s/z17Lxije6odnq9JkJog/SIbc32Bq/koxSl/crIUXtmejBciIa0jyPtqOtkka+flT/EJeXjmz8fjyrfhXjegje9UnbyCtbj+NdvIyvQe8MGTKr3p4kMwTy6LrdZkXX2/Qyo0GJDLkCQkiPbPGsQTPihUHzVbiVFri+0bRHw6rc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765037542; c=relaxed/simple; bh=PSUb299D2dYUfFweRiNrtxHWpDEOy5t5wSnP8271FXg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=mlTUB73qJ2LBAv+Cv1Ik/mijnMz05mtYSBVBxz7K4D218OJUkUTVLlDBDja3r3i1RtyffaH3yHA+8rKCX2NFK31708XpNTPnvtYX36zrutfk6Lc9YyMpBiiVsP52Y558tMwHZ0F0HnZvufWc94c3P1Yfmlc8GLa6awVZDnTrfeY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SWXYd1bt; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Z4CL9zvQ; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SWXYd1bt"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Z4CL9zvQ" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5B6CRp3K3084098 for ; Sat, 6 Dec 2025 16:12:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= OcVXm5JIAcyGqoJflm6whI5XkmDpNUJ6dOT69v0sFpE=; b=SWXYd1btFwoRiND6 APXPBBWva/xapGbLe6jvCaQoqCg7rFIzguszDcjP5q/VXt+fryuAbBjZoXp/g9v2 5EPOvmdq8St19MJEzKJ0iQYQygljJBcW2/nI3R/7oa1FKRTSOfKTCZ3zv4n9vgH+ t3v06kbPSGqzWn2/hNgOmrfPffchqpORgTn2PlFxoiFqaUJKmToHQmiuhkyWffWz NfTDkS7/xcmSnoRg+Hv+9BgPw9T1XUWT6BC50xZwZJwNkTFsedX04R2gzjHEGVfT 1Yrgv3iSVwPSYc3r0CLGlCqPy0C86nGsQGDVtDo2QNwr2kZcjSOupnxdu5x+4dGc AUqpng== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4avcq30ym4-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Sat, 06 Dec 2025 16:12:19 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-2956a694b47so3454385ad.1 for ; Sat, 06 Dec 2025 08:12:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765037539; x=1765642339; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OcVXm5JIAcyGqoJflm6whI5XkmDpNUJ6dOT69v0sFpE=; b=Z4CL9zvQL3TWViMItEjM+lSh+9ldKEQ33pi2ZqLw4XiyPWxEdaG/3X7F53wGykwzES Sb4a/rkwT1PDT7RQ5OiHAzBDPew70NcaIBb3kbps6fU2m3bliAW24gBoJxOqQfySJUAs 40MsqRMoXY8UYVoWIkUJW9s+PXKzZ9kBBstYuGgLpgGUIA4EieNuJzuDL5X7V+LrMoF6 ml1sEpqYmTTFAcit42woRm56VLZuq/jEDcKlkM2GwW7Wtgm58rhEbVo3xbICE+7t/vpx LnDwdMl2lmEiXTOuQDhSa2Ki1stI67ZFChqmfRigcg4iDLIiDYoX+SD3x79fVOZQBazu HU3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765037539; x=1765642339; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=OcVXm5JIAcyGqoJflm6whI5XkmDpNUJ6dOT69v0sFpE=; b=NIchtsGu++iYlYpaup9PxY0J65bGBf93XTuB1A1mg/PkxXiNtH2x+56pgsil6JBWjG 6NMFlMVOo0uuvoaXSoHBarSKsI+Gy/Ev/KMgvFYNJ12QtE9HZGmQmClodSOdKxCSEM7o jzj5/xpqtE4gXNer7whHsXwpOhcVRaFfDd5A5wQ46SDP7vfE4t+qqRFh7n8KVwAEAWB1 1OgLlLzhxoGyv8iwFeLGM+/sUTpJO92delJBxuJFhmSyVORSni4FtwDSdsOpODHakg+R ep3vmtjZdxd8Y1ICSq4m/k6dWpI48L2eZOCdtCxnoVsU/KxodEf3KGvZk26MnS26FOjL eKkA== X-Forwarded-Encrypted: i=1; AJvYcCUQ8Pw0MayBSlnyzBMiCazmAmoPdFL84IkHOuVwKIG5Hg/3UUDMANSLtifX1PYDxJ0WzgbOvi7IeO+AuEU=@vger.kernel.org X-Gm-Message-State: AOJu0YxgyxMHnw6OznK800u7SanQEiBNIiV11qV2AtNpQA4gYW+W26Rz WopibMZkFA27tbNi0fF1A932toqzac5DBzWXCIoBFL9nQXA2F8lu4tKqBeXfSF1rGTt0mn2YUwF 14uEiXsEcdZuoVdjCHPLFfMaejlMsWxG2Y9EOl065zR8qWls/PMnI/+DDJL3YES9hhVE= X-Gm-Gg: ASbGnctpqRu8bFGqjvi2kGSnX1wGtJKeMthrjeqEvXiWoXL+O0BLzVn9jtukJlKfVOW 2eaKaj9OrvGkCEKNbDqPU047QuzqVpMkCPBljlWUH1mpz58yEKNdpWL1zd7IpjEiK8wk8mnUGK1 5vTofIZa8BExnSCSR6dJQVqnzUC/4IzzfRXT734cQvQ4g+cHSOXxRDuSdTtzMflhLXHGmQHfDXW Uh8GVUaj+3NtOtGEfzC5Df4YY18rjaXV/tG0p2M85O7uJ7bDt08lpXK/hefvnnvtwCJ0fPjBGuJ DmuhqVNyXOYo7l+HrxH1M+hQ/GMNhDp/iX4s/YnFpgbu2m6rnKDr89u3xjz0P8YC8E5CeUVVId7 UdQYJgcBAP9ni7KIyMW6FB4/+rgF78xX7FFnEXbB8jRAP6w== X-Received: by 2002:a05:7022:f89:b0:119:e55a:9c04 with SMTP id a92af1059eb24-11e032ac37dmr2065791c88.32.1765037539125; Sat, 06 Dec 2025 08:12:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IE6Q72hT1tfm6ehPxRu0e2geTtWEprk5QX5IDwHV/oq7L2zAoa9XsSYNu2EY3vjHRgUFdsabA== X-Received: by 2002:a05:7022:f89:b0:119:e55a:9c04 with SMTP id a92af1059eb24-11e032ac37dmr2065761c88.32.1765037538505; Sat, 06 Dec 2025 08:12:18 -0800 (PST) Received: from [192.168.1.3] ([122.177.243.159]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11df7552211sm31523490c88.1.2025.12.06.08.12.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 06 Dec 2025 08:12:18 -0800 (PST) Message-ID: Date: Sat, 6 Dec 2025 21:42:11 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/3] phy: qualcomm: phy-qcom-eusb2-repeater: Add squelch detect param update To: Konrad Dybcio Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, Vinod Koul , Kishon Vijay Abraham I , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Luca Weiss , Neil Armstrong , Johan Hovold , Pengyu Luo , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251204044644.3072086-1-krishna.kurapati@oss.qualcomm.com> <20251204044644.3072086-3-krishna.kurapati@oss.qualcomm.com> <755b7579-757f-4ced-b3c4-39c20e6b25a7@oss.qualcomm.com> Content-Language: en-US From: Krishna Kurapati In-Reply-To: <755b7579-757f-4ced-b3c4-39c20e6b25a7@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjA2MDEzMiBTYWx0ZWRfX/cWv4FalV81R zPI6L0/faBgJjEYZNaj31Poj2kAqNZ/j/LlUPOpc4Bih8G+jKa7WYxATYqFBYOHnXGD7JiQsZ3T bzJTr+5QBv509OkwVfMRYtTfZodgqHidFMLc2y+hkZl++nbPxVh6RMqFrkMox6K9lY6PrweAXIr fw3QbJ5DCogXekb03oLsiPZa5GkqZ1gFPLyDLgeojWKxRoZY2JEYzVZNE7TJ+sgGeO+MyA+XrHg QxMMVWk/kmqWWWZ8SMib2KLrGTjjIv33Q3m6O3BHv+i3M4r1xfmBmY46K0r8AzZIkLEeBBs5PtB XlfjI4R9A8SjImmRx20mgjWHY5lXda7f9npZeWJd/L/1w6z3iYwQvq3aS3Ffvm2s8+22idnjQ5f 83BrxNAlnILPICP7q2FBmSpcb6X+wQ== X-Authority-Analysis: v=2.4 cv=as+/yCZV c=1 sm=1 tr=0 ts=693455e3 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=mGeNq4HQZpM0LKVKY7z1pw==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=7OXqrvXZNe0mwyzepZkA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 X-Proofpoint-ORIG-GUID: bb3zFzWkYZby9OxHKuS_UAo_02vkPNmk X-Proofpoint-GUID: bb3zFzWkYZby9OxHKuS_UAo_02vkPNmk X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-06_02,2025-12-04_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 suspectscore=0 phishscore=0 bulkscore=0 adultscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512060132 On 12/5/2025 7:01 PM, Konrad Dybcio wrote: > On 12/4/25 5:46 AM, Krishna Kurapati wrote: >> Add support for overriding Squelch Detect parameter. >> >> Signed-off-by: Krishna Kurapati >> --- >> .../phy/qualcomm/phy-qcom-eusb2-repeater.c | 22 +++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c >> index 651a12b59bc8..a75b37d4e16d 100644 >> --- a/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c >> +++ b/drivers/phy/qualcomm/phy-qcom-eusb2-repeater.c >> @@ -37,6 +37,17 @@ >> #define EUSB2_TUNE_EUSB_EQU 0x5A >> #define EUSB2_TUNE_EUSB_HS_COMP_CUR 0x5B >> >> +static const int squelch_detector[] = { >> + [0] = -6000, >> + [1] = -5000, >> + [2] = -4000, >> + [3] = -3000, >> + [4] = -2000, >> + [5] = -1000, >> + [6] = 0, >> + [7] = 1000, >> +}; > > I forgot to ask, do these values apply to all of the supported repeaters? > I checked smb2360/pmih010x_eusb2_repeater and pm8550b repeaters (SM8{5/6/7}50/ Kaanapali/ Hamoa). For all of them, the above table is same. Regards, Krishna, > i.e. > > PM8550B > PMIV0104 > SMB2360 > > Konrad