From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A91C416F8E5 for ; Sat, 31 Aug 2024 10:07:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725098851; cv=none; b=k6bo3bgFMSgWDV6b4GsouAhMl61KlBHTVWzVa4XlBfsSQ++4t4XORPD3Fq1LPoxwJZdeXGvW2tiLIZiBFPRB39sFQFH3oKlKxDHmY93rgECBTMEcaUNtqr7WWu7uuORmVHZFLQS5rbnA8nY+Yg6s+nr8vtldSt3BtCTuPrUvgwA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1725098851; c=relaxed/simple; bh=GaUosfCd3jJGo0FpzgDxZtkIsu8gi1r2FdslqV+izUE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=urOZkZe96Zr+UYysmAQbu7nZ0onIO2FoiMdUf0d/wlSa9KHtDdpy8WMcSFUAeH+/P8ZEK03Yy7ocdYfN7x93mZax5r006E+8/D4Gfz91c6dZ8w34G/N3TtKdFa45IC0H9HjYGUO2+fOmLcclCLmysZTJw7BfYvl0iDb8iYRqcik= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=EPMSs2t8; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="EPMSs2t8" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725098848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=DiJ5BrALhyOBQpHEAb/pCM8cuqFOjK5I4kSW6yg2UpQ=; b=EPMSs2t8uFasQDUcwWp/snV/FH9cpRstGlkxklbhAEOzhUqjuLQ4+ElapE5IxaqfTI8BYr bdqstHc9a3SdRYfscEsOuRCZni79i/MtYlpzf4n6X6ROXzn37yeGxRXzID/EBpvWuUD+pd zwh0XxwTXngSXOHfeATDi0HZs1XOYSc= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-473-YXNY8fVYM9CRRE4lzFnOZg-1; Sat, 31 Aug 2024 06:07:26 -0400 X-MC-Unique: YXNY8fVYM9CRRE4lzFnOZg-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-42ac185e26cso25449245e9.3 for ; Sat, 31 Aug 2024 03:07:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725098845; x=1725703645; h=content-transfer-encoding:in-reply-to:organization:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DiJ5BrALhyOBQpHEAb/pCM8cuqFOjK5I4kSW6yg2UpQ=; b=axbg0O1IRLfgRPXpNMItea7da5R1UtOPT4NRgf7G87hSvxFcazWVBiMDY2CZvTCem3 SV2WU0u7s0yBFQuP8ADYh9xLQBkrRpRkNQjW6WOeDZx9rDnJaCeDLgBvw06AiT9cBYF2 mu1oPM5hmxdqPOYvt9pNF0wvgQTKvXsS9fDSrfcouzEX04sVX6G2lmH48RxH/DvxIA/q ly8By72AafpeCxoZ/f9nPLb3+CTVq5IXn9t8czk2zeuz3+BsAlXnNpXLdSmJAfxGYSUx gNcTmSFkDVyRF4NuJT2oBYnk3qti+SLMJ4Dglj2J74eZ+zBtdnyNJpYry7h1ocnBmBgF v0AA== X-Forwarded-Encrypted: i=1; AJvYcCWA/keOvaxHALFDORUqwpbr3KwdQ09FiBMM3oCISxE+daBJOuRDQLckttszlIB4Od6yXbk0/blz2ru4G0g=@vger.kernel.org X-Gm-Message-State: AOJu0YzETGevCpuQQsZ9PKttupgktt2G/qoT7dovqBxlYKekmn+kDcwn U363r8k68VjnlVDBkXhNR0dOpYGVxSPuRPxVsdaaO95fXSMDrvX4jRE669yfOBQKr8SyfZKqD2A Zer9d4nR2AXSBGB2M4+zq6Mntdepxkbmyj1EtisenbY29WbubpG56fToobEo07w== X-Received: by 2002:a5d:6c6f:0:b0:371:8ed7:49e9 with SMTP id ffacd0b85a97d-374a959cd9amr3605048f8f.26.1725098845335; Sat, 31 Aug 2024 03:07:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGJ9HLKbV7w4UEpPl8Q8zbPKleArrTv90wQB7I5emwPN8RX+CsSEQZ/60tCqZY8YKfmdW9fBQ== X-Received: by 2002:a5d:6c6f:0:b0:371:8ed7:49e9 with SMTP id ffacd0b85a97d-374a959cd9amr3605002f8f.26.1725098843585; Sat, 31 Aug 2024 03:07:23 -0700 (PDT) Received: from [192.168.3.141] (p5b0c6ee6.dip0.t-ipconnect.de. [91.12.110.230]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3749efaf8b8sm6161217f8f.91.2024.08.31.03.07.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Aug 2024 03:07:23 -0700 (PDT) Message-ID: Date: Sat, 31 Aug 2024 12:07:22 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC] mm: entirely reuse the whole anon mTHP in do_wp_page To: Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Barry Song , Chuanhua Han , Baolin Wang , Ryan Roberts , Zi Yan , Chris Li , Kairui Song , Kalesh Singh , Suren Baghdasaryan References: <20240831092339.66085-1-21cnbao@gmail.com> Content-Language: en-US From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 31.08.24 11:55, Barry Song wrote: > On Sat, Aug 31, 2024 at 9:44 PM David Hildenbrand wrote: >> >> On 31.08.24 11:23, Barry Song wrote: >>> From: Barry Song >>> >>> On a physical phone, it's sometimes observed that deferred_split >>> mTHPs account for over 15% of the total mTHPs. Profiling by Chuanhua >>> indicates that the majority of these originate from the typical fork >>> scenario. >>> When the child process either execs or exits, the parent process should >>> ideally be able to reuse the entire mTHP. However, the current kernel >>> lacks this capability and instead places the mTHP into split_deferred, >>> performing a CoW (Copy-on-Write) on just a single subpage of the mTHP. >>> >>> main() >>> { >>> #define SIZE 1024 * 1024UL >>> void *p = malloc(SIZE); >>> memset(p, 0x11, SIZE); >>> if (fork() == 0) >>> exec(....); >>> /* >>> * this will trigger cow one subpage from >>> * mTHP and put mTHP into split_deferred >>> * list >>> */ >>> *(int *)(p + 10) = 10; >>> printf("done\n"); >>> while(1); >>> } >>> >>> This leads to two significant issues: >>> >>> * Memory Waste: Before the mTHP is fully split by the shrinker, >>> it wastes memory. In extreme cases, such as with a 64KB mTHP, >>> the memory usage could be 64KB + 60KB until the last subpage >>> is written, at which point the mTHP is freed. >>> >>> * Fragmentation and Performance Loss: It destroys large folios >>> (negating the performance benefits of CONT-PTE) and fragments memory. >>> >>> To address this, we should aim to reuse the entire mTHP in such cases. >>> >>> Hi David, >>> >>> I’ve renamed wp_page_reuse() to wp_folio_reuse() and added an >>> entirely_reuse argument because I’m not sure if there are still cases >>> where we reuse a subpage within an mTHP. For now, I’m setting >>> entirely_reuse to true only for the newly supported case, while all >>> other cases still get false. Please let me know if this is incorrect—if >>> we don’t reuse subpages at all, we could remove the argument. >> >> See [1] I sent out this week, that is able to reuse even without >> scanning page tables. If we find the the folio is exclusive we could try >> processing surrounding PTEs that map the same folio. >> >> [1] https://lkml.kernel.org/r/20240829165627.2256514-1-david@redhat.com > > Great! It looks like I missed your patch again. Since you've implemented this > in a better way, I’d prefer to use your patchset. I wouldn't say better, just more universally. And while taking care of properly sync'ing the mapcount vs. refcount :P > > I’m curious about how you're handling ptep_set_access_flags_nr() or similar > things because I couldn’t find the related code in your patch 10/17: > > [PATCH v1 10/17] mm: COW reuse support for PTE-mapped THP with CONFIG_MM_ID > > Am I missing something? The idea is to keep individual write faults as fast as possible. So the patch set keeps it simple and only reuses a single PTE at a time, setting that one PAE and mapping it writable. As the patch states, it might be reasonable to optimize some cases, maybe also only on some architectures. For example to fault-around and map the other ones writable as well. It might not always be desirable though, especially not for larger folios. -- Cheers, David / dhildenb