From: Krzysztof Kozlowski <krzk@kernel.org>
To: "Omer PALA" <palaomer100@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Michal Simek" <michal.simek@amd.com>,
"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
"moderated list:ARM/ZYNQ ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5] dt-bindings: iio: adc: Add dt binding to xlnx,xadc
Date: Sat, 19 Sep 2026 09:25:17 +0200 [thread overview]
Message-ID: <b787a787-5011-4f14-9332-4cca098b374d@kernel.org> (raw)
In-Reply-To: <20260918203257.6034-1-palaomer100@gmail.com>
On 18/09/2026 22:32, Omer PALA wrote:
> Add yaml devicetree binding for xlnx,zynq-xadc-1.00.a,
> xlnx,axi-xadc-1.00.a and xlnx,system-management-wiz-1.3 from
> xilinx-xadc.txt file.
>
> Signed-off-by: Omer PALA <palaomer100@gmail.com>
> ---
> Changes in v5:
> Fix validation bypass: xlnx,external-mux-channel could be set even
> when xlnx,external-mux was omitted entirely, due to "not: properties:"
> being vacuously true when the key is absent. Now uses required +
> properties with if/else.
How many versions are you going to send one day? If you only used search:
https://lore.kernel.org/all/?q=dfn%3ADocumentation%2Fdevicetree%2Fbindings%2Fiio%2Fadc%2Fxilinx-xadc.txt
I asked for this indirectly in your staging patch. I pointed previous
discussion where I said work was already done and received comments.
The lesson to take from that was to CHECK for existing work and READ
existing comments.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-09-19 7:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 14:58 [PATCH] " Omer PALA
2026-09-18 17:48 ` [PATCH v2] " Omer PALA
2026-09-18 18:58 ` [PATCH v3] " Omer PALA
2026-09-18 19:44 ` [PATCH v4] " Omer PALA
2026-09-18 20:32 ` [PATCH v5] " Omer PALA
2026-09-19 7:25 ` Krzysztof Kozlowski [this message]
2026-09-19 8:07 ` Omer PALA
2026-09-19 8:30 ` Krzysztof Kozlowski
2026-09-19 7:32 ` [PATCH v2] " Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b787a787-5011-4f14-9332-4cca098b374d@kernel.org \
--to=krzk@kernel.org \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@amd.com \
--cc=nuno.sa@analog.com \
--cc=palaomer100@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®