From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932446AbcE2RCd (ORCPT ); Sun, 29 May 2016 13:02:33 -0400 Received: from saturn.retrosnub.co.uk ([178.18.118.26]:33650 "EHLO saturn.retrosnub.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932246AbcE2RCc (ORCPT ); Sun, 29 May 2016 13:02:32 -0400 Subject: Re: [PATCH 1/7] iio: adc: ad7266: claim direct mode during sensor read To: Daniel Baluta , Alison Schofield References: Cc: Lars-Peter Clausen , "Hennerich, Michael" , Hartmut Knaack , Peter Meerwald-Stadler , "linux-iio@vger.kernel.org" , Linux Kernel Mailing List From: Jonathan Cameron Message-ID: Date: Sun, 29 May 2016 18:02:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 25/05/16 11:33, Daniel Baluta wrote: > On Tue, May 24, 2016 at 10:16 PM, Alison Schofield wrote: >> Driver was checking for direct mode but not locking it down. >> Use iio_device_claim_direct_mode() to guarantee device stays >> in direct mode. >> >> Signed-off-by: Alison Schofield >> Cc: Daniel Baluta > > Acked-by: Daniel Baluta Looks good. Applied to the togreg branch of iio.git - initially pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > >> --- >> drivers/iio/adc/ad7266.c | 7 +++---- >> 1 file changed, 3 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/iio/adc/ad7266.c b/drivers/iio/adc/ad7266.c >> index 21e19b6..01240ae 100644 >> --- a/drivers/iio/adc/ad7266.c >> +++ b/drivers/iio/adc/ad7266.c >> @@ -154,12 +154,11 @@ static int ad7266_read_raw(struct iio_dev *indio_dev, >> >> switch (m) { >> case IIO_CHAN_INFO_RAW: >> - if (iio_buffer_enabled(indio_dev)) >> - return -EBUSY; >> - >> - ret = ad7266_read_single(st, val, chan->address); >> + ret = iio_device_claim_direct_mode(indio_dev); >> if (ret) >> return ret; >> + ret = ad7266_read_single(st, val, chan->address); >> + iio_device_release_direct_mode(indio_dev); >> >> *val = (*val >> 2) & 0xfff; >> if (chan->scan_type.sign == 's') >> -- > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >