From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF61E468C04 for ; Thu, 3 Sep 2026 09:05:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788426319; cv=none; b=pG8mFZT8XaINBay8fAaWFVQyjj1dx/EgskxIh4HYrubwePYTB/Un3MnzgiS+gQxE6PXVPSs1EjKVDJzhmkZr+C7FgrQqw4w/sfvF58LrMvkXRkONS060qr6D2ltrTOmn7Kr/q4rTYub53PYSjeeis4OVABlW6H35kcytazq2h5k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1788426319; c=relaxed/simple; bh=1ZFBwN4O2Tnlfpi2Ys3/dlh9ftVvt7IonIdLG60fN5U=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=tKX6og+YVFQhnuPR28qScGXKvO7yvl/F8UX2wAx1teozQyOdqDemisaZrBUEuFXZlTPSjblVwDsJBggymNLA+XEin+gctkAPTvt7PrQK80xAqC+PkvBGnaHmr5Ba+fp9kU4nrgazhwIF55qlTfii0kUVQkF562C9e5HzIldTTfI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=eRnHNCwD; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=GM7R5T8C; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="eRnHNCwD"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="GM7R5T8C" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6839325H519798 for ; Thu, 3 Sep 2026 09:05:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= UIAGfBApybDy6Np2y/KdX9quRVrgGs5YTAz7KoZkn8U=; b=eRnHNCwDtU9+IpxN VddEf6WD3xIe9dvaCHophKdTK8NP5iEoa3aed1Rpy9TCeOvV5NIuxNHnmGF+Dpw3 j//1nq1vznIET1tlVwDDgtc5S949+9Ta95VgIWLE1+kQtS0dutW59+CkqHRkytrM uAJbnvHH7ErvtaRcVWGtSI8lns5AEqIpu/iBTVczWpG15zyxA0NA4NLOVOIaLTbk tfTqtiY6DcpBREIpJBTZyaDrKStA4Y4BJq27ia3LyxRGCNdpfWy8j5p+iVmvaPYh eIB7Epf7Yxp8hRPPjySmh32WCs4aV8+xhkBf4X+sglUyT4ZzyiUyz/t9saZb7JQZ vI2zHQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4gf1j4h3eq-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 03 Sep 2026 09:05:15 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-938fd633df7so41720485a.1 for ; Thu, 03 Sep 2026 02:05:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1788426315; x=1789031115; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=UIAGfBApybDy6Np2y/KdX9quRVrgGs5YTAz7KoZkn8U=; b=GM7R5T8CigW++rJYAreA5+EELwjWfZCTfN/OhHKaLIKIpDDnN4N0L24BsBPfylvT9+ 75iiFLx4uL8+FwhYiC4nI3cI2c6bvpfbU69lL+5rDmWxZqVJnESRVjaZAwulkBccMdcY ilKAgw2vnk8yoSEd0o8qfPXEp24VA08So01yf3H9R8D1AwXZFWox/D3FdYZ81FNeWccG 0ypscgKNGWr1upV6yeMzJFBTjJdUeJO0qZgjHLp65kpB7VC56ZFIu0EBoc5zX1wdHRUk aUFKvkleoodDYhSqamo0mV5V6/dlvzSX5Hq5lqdO9ATBUY/dGrZBEI9MEZlsvEApBiyd BZbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1788426315; x=1789031115; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=UIAGfBApybDy6Np2y/KdX9quRVrgGs5YTAz7KoZkn8U=; b=pwHJ34XzUiPBu/zvsJ+ixXfCzSfmR62/PTXROJ5peD0FT39PBZGo0wQXXAbDLuoqRD eYUiKfnAii5J8W/gPzITf8eDCm2jSnlFzaplFdQYUGCPIW1BK05C86NttcbdGIy4QvZO QTMSojC1gQv3MHNpbGNqlS1fcKA4n1QR+YmRXEi1Q/UDmzcBJP82V55LJ05CH5bch9P/ Ljlwisjc+0wUVIyG/b5YnOGVyI19wFn868liNOF/yUZxmNqV0OuN9DSFj21oVZHSs/nA gpu+KfH1Ur+R04iJ1csJISylY+fpas0Xhc32KdFiWWUvUIeR9PEGPIzicXD1a4pZqYjD PTMg== X-Forwarded-Encrypted: i=1; AKwUvBwRu6V6VTqZQaYTKRZNS4YwWEEndaz1mq8sAT5U/RU+ujuxyUs75FpeTIt9ds7ubuoWxyp6TxCaAD9UMCs=@vger.kernel.org X-Gm-Message-State: AFuF++kVRJdGdtwhncPY3DHlg9yo3OF0gd6Y1js3XcjNI9M3zcu5t+Kf o88pm749W2fx8URC7/Lcg5hWF/B4evub4syYmA68uIGlzFQDaLXx+QfjCAYyk6bR1RSyHHoMEYm VatbFXqpH9dVM4UPvqPZWYLHgIw6RfYpcp810/0DelhxCFy4VUUWNbvBGsaKKiX9KlSY= X-Gm-Gg: AYBFou2Za5NNMgtrBxxLP96tU3Gumqi0mwiGa80c76GlIzW9w/oQZZ7Q4+8p6trSjNB 0kBc/1UJaDxS4yzBlAq/xME4Z0mdeIZkBC0Y24rY7TihEg1ODYU7m8RIqwoWS3mKQCciTJ9+YuF tWdKHUdL9PVSSn0PXFAzeoolzBnZZ3l0uZc6dMn0cWkTEbRJJMN/DWiIhKreA1WnRMlDD7H6bSk 5FJ3dN+epnmMpKglF8UXuKnp/uM6XG1f6HVZx9tCxA1CjXWw+NxT059wQ1Krk0G35l9YZqvA6IV EoHYdE84JA/678UXOBMSYjURTnVI4W0vbK0d/yT6OOctjVYGkX00Y2knzTFmBcd2CwinKCtRlF6 /7kZCWwLVmeE+uniPB0z0ZA== X-Received: by 2002:a05:620a:2b89:b0:939:2c96:1551 with SMTP id af79cd13be357-93960cba6f8mr788247485a.1.1788426315325; Thu, 03 Sep 2026 02:05:15 -0700 (PDT) X-Received: by 2002:a05:620a:2b89:b0:939:2c96:1551 with SMTP id af79cd13be357-93960cba6f8mr788242185a.1.1788426314787; Thu, 03 Sep 2026 02:05:14 -0700 (PDT) Received: from [192.168.202.12] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c25f4238ad7sm67640066b.54.2026.09.03.02.05.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Sep 2026 02:05:14 -0700 (PDT) Message-ID: Date: Thu, 3 Sep 2026 11:05:11 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] remoteproc: qcom_q6v5_pas: propagate dev_pm_genpd_set_performance_state() errors To: Dmitry Baryshkov , Mukesh Ojha Cc: Bjorn Andersson , Mathieu Poirier , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Manivannan Sadhasivam , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260902204334.2061226-1-mukesh.ojha@oss.qualcomm.com> <20260902204334.2061226-2-mukesh.ojha@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=dufrzVg4 c=1 sm=1 tr=0 ts=6a99384c cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=EUspDBNiAAAA:8 a=DOEPYjRYTCW89wv4dG0A:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-GUID: bHs4VBoZ706UnMd2otJRB7g5IlR9SjPT X-Proofpoint-ORIG-GUID: bHs4VBoZ706UnMd2otJRB7g5IlR9SjPT X-Proofpoint-Spam-Info: AW1haW4tMjYwOTAzMDA3NyBTYWx0ZWRfX0DpwSa6Jh8cr cpbPe5ijA0ylRQknwYQ0W+hOkzH6PXYPXR4dMDyxvh6/TcZiRifAy1W4TpCfGQCUyBq+7O3bvO7 sGYSyM64acewcLz/ht74svc8vyQJ8Is= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTAzMDA3NyBTYWx0ZWRfX5bwIYAljAIeS SwrVoWGLRazEjogGF4HopUlEGjZX4VhDFWIrYVEcNRMilDxi0EfbRPtEotykEmwZLV0YGc8aDPZ CCJhWCmpbqUo9ErHAa+wRkCOI4N7YNyL/q2dHvy06FjzvP7OCNQ/sdYwRm+IUCusVCvJXybhMfs tl5qLEwrqhKmQej3+5U6ka4FNR4WAtRE7tLEyslQetK9J8d7YFHWeAiRu9m5hYqcTV7A3HiOvcI 8pBoyVNZpRPQdzn7HRG1bCJYM2xXJyzX4RIWJFj8G4cYe7Tq9lgNaEl5LsvKtvxINwiyoTlmwLa F4Np0ZSTdGeZVjgH6dLl5k47Nwd+m5qhzMFVeF1g6uWfhzfDXQdUK/yjF76f02eZv3KdHLyHrVj PS466/M2+kacu2iTvABeMQHm4R/UT87+oCeaAnX+KwO7a8DPSM0oDNNOfncDtw6d3Emqes9nbyH ib+2Uh2HbfHIzndO3XA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-03_02,2026-09-03_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0 clxscore=1015 spamscore=0 lowpriorityscore=0 adultscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2609030077 On 9/3/26 9:45 AM, Dmitry Baryshkov wrote: > On Thu, Sep 03, 2026 at 02:13:32AM +0530, Mukesh Ojha wrote: >> The proxy power domain enable path discards the return value of >> dev_pm_genpd_set_performance_state(), masking failures silently. >> When the call fails the performance state is not applied, yet >> firmware load proceeds without any indication of the problem. >> >> Capture the return value and emit a warning on failure. Firmware >> load continues regardless a performance state failure is non-fatal >> but the warning provides a visible signal for debugging. >> >> Signed-off-by: Mukesh Ojha >> --- >> drivers/remoteproc/qcom_q6v5_pas.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c >> index a005546c265d..01dc0194e130 100644 >> --- a/drivers/remoteproc/qcom_q6v5_pas.c >> +++ b/drivers/remoteproc/qcom_q6v5_pas.c >> @@ -167,7 +167,11 @@ static int qcom_pas_pds_enable(struct qcom_pas *pas, struct device **pds, >> int i; >> >> for (i = 0; i < pd_count; i++) { >> - dev_pm_genpd_set_performance_state(pds[i], INT_MAX); >> + ret = dev_pm_genpd_set_performance_state(pds[i], INT_MAX); >> + if (ret) >> + dev_warn(pas->dev, >> + "failed to set proxy PD %d state %u: %d\n", >> + i, INT_MAX, ret); > > Should it be turned into an error? Yes Konrad