From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68F603A641D for ; Thu, 30 Jul 2026 14:55:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.158.5 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785423329; cv=none; b=Sr94xdYQbrfiz+z78MQTydsSiw3kJkXo8TaFAJxNIFQC5Oh6NFTU1cVbMFeWqe9gBlFRJTB+xo6NrvXnbhmF8lklKGm0V4LvtR3kM/K4quJFvNZkUT3P0KOsle8PJFz/8qYBRSCDH7TVDAdpz8kSGV2IU9ixIXMd5KaT1KqXQc0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785423329; c=relaxed/simple; bh=cUvWloZolvPm8NadGhHjKbkFhmnTTAvPrOdN7c+ZZNc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pM1/uDu5y3WD8bQTfHYDkCqs9UBWKS7Dlu5rehA0mZQOkNANQ1mkXphSUbpXt5Vr9XsZD2plIMOYPJkHUvxJA2BQ6X9fVtS7GnJdkXR7q5PS0iz02beDVOmYEf3FiAbfeDyr4h6aXjj+1X+tYHRcBjKvmo0vjxdXI4NB7UdbeWc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com; spf=pass smtp.mailfrom=linux.ibm.com; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b=rIC1RNki; arc=none smtp.client-ip=148.163.158.5 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.ibm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ibm.com header.i=@ibm.com header.b="rIC1RNki" Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66UDHhhZ3020677; Thu, 30 Jul 2026 14:50:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=9Z0uQxvmNrLSRCmkr4D1+JE0i6yoiQ LKgFJIdlFFf+4=; b=rIC1RNkiW8+mftZFmsFq2DCH60j8D5rFTPBUOEU1qi/MNc FABo72XhgHK1N4MWNYEKgaS2W6spwj+GmTCkopTjo0auw+1lxsAbZoIESaN5Larm 51E0Ias37FjxUwGFuYtT7ZKFjmM2lUOa7TpGRMfMwXKgdTyYJuUAxwft+cUafTvz k6eZS75tnc9h6qXX4seLVH5z26vt1sYD+OsdwfVnLq/zwg2yp+iLVXIL07/tCr+/ 2CAzD6EBxSUaHLHzQgRUaJgbX0NFVGB4MZli2CTD+xxS5Q6pHHZC4syB1dqvAX1w 3zMfdaVOiqgf/A6OBd+BN2AbzbFnJ67FavkEjSow== Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 4fmv0nydwu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Jul 2026 14:50:09 +0000 (GMT) Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.18.1.7/8.18.1.7) with ESMTP id 66UEfLeY006361; Thu, 30 Jul 2026 14:50:08 GMT Received: from smtprelay02.fra02v.mail.ibm.com ([9.218.2.226]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 4fn8fkbtaf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 30 Jul 2026 14:50:08 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (smtpav05.fra02v.mail.ibm.com [10.20.54.104]) by smtprelay02.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 66UEo6g047186296 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 30 Jul 2026 14:50:06 GMT Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 725772004D; Thu, 30 Jul 2026 14:50:06 +0000 (GMT) Received: from smtpav05.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 590A520043; Thu, 30 Jul 2026 14:50:06 +0000 (GMT) Received: from li-008a6a4c-3549-11b2-a85c-c5cc2836eea2.ibm.com (unknown [9.224.92.206]) by smtpav05.fra02v.mail.ibm.com (Postfix) with ESMTPS; Thu, 30 Jul 2026 14:50:06 +0000 (GMT) Date: Thu, 30 Jul 2026 16:50:05 +0200 From: Alexander Gordeev To: "David Hildenbrand (Arm)" Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pu Lehui Subject: Re: [PATCH] mm: use proper PTE accessor in move_ptes() Message-ID: References: <20260720141633.501799-1-agordeev@linux.ibm.com> <7f60a20f-7293-489b-8539-847fa1b96789@kernel.org> <51102823-ceab-499f-8b6a-162e392f864f@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <51102823-ceab-499f-8b6a-162e392f864f@kernel.org> X-TM-AS-GCONF: 00 X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMwMDExMiBTYWx0ZWRfX/35g+J0LkFlX 8xVdto5GtSbSr2OoyON3SyaZi3Vx12y9NUpgYphp/kI0Cum4Mm5QaovT2yd8O6wDaPigfXKeXXu iMBAAyrMI72ZWgc7XzviKj3/D1CtTy8= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMwMDExMiBTYWx0ZWRfX/nYNa++3prAB r3L8RIDNZjfTuFoHlfZ5tjPqIqhXa4gmSZtM0Ja59gNsScNVCp9kRrzVbSu9osZb/1Cr/yWEAk1 w/ccbsxzTTeBEuMPTVUxrIs+E3E/VvwbJOjD+uoo7PQmftcOSAH4//+DDBfQoBKHZyQiiS/BRMB G1LLAsCUy4g3A2TlgixGWEdbSmhLGVgJcG7gokqQ/oLM2UfGMOgzpubDptnDJfzRgtEYMx6bGZX xpSbn591FuTiTcDIZ0wdRGEBxEoDBwujLPnDT4HEIH5fbL7u7HTauiL5g5RnlJL1thL8r7yfr6Q pLsGjmevY28b59+mu23N7aJuwKcQXsV+eQVYc8/sS/B/j46+vy0TRuM4sx4MMtiOY/luKFuSpKQ Ue/pxjs8970yVc6KHZ8Gm1yX2pVtlF5XZjCyzw/7UaqOiTaiDB4ub+4TKu19J09SL8wbA4b9jgi PTeAGyBPKs6wqOetNDg== X-Authority-Analysis: v=2.4 cv=b5WCJNGx c=1 sm=1 tr=0 ts=6a6b64a1 cx=c_pps a=GFwsV6G8L6GxiO2Y/PsHdQ==:117 a=GFwsV6G8L6GxiO2Y/PsHdQ==:17 a=kj9zAlcOel0A:10 a=RAioF0-LDSMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=RnoormkPH1_aCDwRdu11:22 a=V8glGbnc2Ofi9Qvn3v5h:22 a=VnNF1IyMAAAA:8 a=VwQbUJbxAAAA:8 a=CgfZsCgG6mTAnALvW7wA:9 a=CjuIK1q_8ugA:10 X-Proofpoint-GUID: g30uzBDJJit5SmXkJpWfX_IHS0WiqhTT X-Proofpoint-ORIG-GUID: g30uzBDJJit5SmXkJpWfX_IHS0WiqhTT X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-30_04,2026-07-29_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 spamscore=0 adultscore=0 malwarescore=0 impostorscore=0 bulkscore=0 phishscore=0 suspectscore=0 clxscore=1015 lowpriorityscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607300112 On Thu, Jul 30, 2026 at 03:08:04PM +0200, David Hildenbrand (Arm) wrote: > On 7/30/26 15:07, David Hildenbrand (Arm) wrote: > > On 7/20/26 16:16, Alexander Gordeev wrote: > >> Follow the pattern established by commit c33c794828f2 > >> ("mm: ptep_get() conversion") and use the proper PTE > >> accessor instead of a direct pointer dereference. > >> > >> Fixes: b36b701bbcd9 ("mm: expose abnormal new_pte during move_ptes") > >> Signed-off-by: Alexander Gordeev > >> --- > >> mm/mremap.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/mm/mremap.c b/mm/mremap.c > >> index 0dfe3de39ccc..e99b19a9850b 100644 > >> --- a/mm/mremap.c > >> +++ b/mm/mremap.c > >> @@ -264,7 +264,7 @@ static int move_ptes(struct pagetable_move_control *pmc, > >> > >> for (; old_addr < old_end; old_ptep += nr_ptes, old_addr += nr_ptes * PAGE_SIZE, > >> new_ptep += nr_ptes, new_addr += nr_ptes * PAGE_SIZE) { > >> - VM_WARN_ON_ONCE(!pte_none(*new_ptep)); > >> + VM_WARN_ON_ONCE(!pte_none(ptep_get(new_ptep))); > >> > >> nr_ptes = 1; > >> max_nr_ptes = (old_end - old_addr) >> PAGE_SHIFT; > > > > Acked-by: David Hildenbrand (Arm) > > > > Ah, but I think we should drop the Fixes: tag, or am I missing something? No, you do not. I confused it with ptep_get_lockless(), so no bugfix here. Should I send v2? > -- > Cheers, > > David Thanks!