From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A5C9C2B9F7 for ; Mon, 24 May 2021 13:56:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 67E2C613C8 for ; Mon, 24 May 2021 13:56:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232885AbhEXN6L (ORCPT ); Mon, 24 May 2021 09:58:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:50188 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232462AbhEXN6J (ORCPT ); Mon, 24 May 2021 09:58:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621864600; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rJGWlb0mzdcs5C9EH1U6m2Va0MhvnRjaEHGGSG6l/jM=; b=DYv4d6FR+Tn1BBBxIbvFbSr9Ixmmf8U1Oc2e4sgvncmbQIQJ2TK9Cz7XHIcWPdsPABpUf5 wvRCBjl0FZbUkr8ZHTv5JjT1vWoDinv/TucYb++BTXKEiuSGe6SUSitFUO49rlejNG+MmA il/o48Nj1zXw5RwfqGb3ZhmVacA2yNU= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-581-1t_fm3ShM5GMCvSqm4Vkfw-1; Mon, 24 May 2021 09:56:39 -0400 X-MC-Unique: 1t_fm3ShM5GMCvSqm4Vkfw-1 Received: by mail-ed1-f71.google.com with SMTP id w22-20020a05640234d6b029038d04376b6aso15540203edc.21 for ; Mon, 24 May 2021 06:56:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=rJGWlb0mzdcs5C9EH1U6m2Va0MhvnRjaEHGGSG6l/jM=; b=Ef4TYBbiC/MEe/FkX66eucN8QbeiBybZiNrBzyimRQNDRYGOTebvNIfyPWR0JjwRq5 ZTWauU+MNfeA63jPOPrnxYHvyJpY9BFBEwppFvmKwxHsgATG6U6vDnyPHfMcAXVZkWIs oeTQam6PiGVIKqeXSDNldogWWZUWoAodasf1/KtbZpisCq1ZKJ+r9jGWErnqnr125qO0 aNa6g3spQQ9Zkor770acJgkDi3LBX0GipxYMo++91rZMEXaBRVPzK3OiWyIVFDLwgs3D wQnLAzwAIUV33OT05rdAOXiIJOviH+5Nu9rSIiuqh18SOiNxA7IBBhcj26taBiQgPb8O yeQQ== X-Gm-Message-State: AOAM531gGvxgDI36K9Rly1GZh7XlvtlPeWFqAON64h3ptwQ6cPDmqT9O oyfMFJlxiKcRksxSQGwABhW4ETHCOiiwPHKrlX2n+qebpmamBiDAIFWu5/setOQF72e1M6DXaOI /hFAOJChsFo/mhTjYgMKPaeKsWh9UTVyjXUaIQW8dh9LLUDewtz1CKSoygu3MlAIXCmx338tlgb Pw X-Received: by 2002:a17:906:710a:: with SMTP id x10mr23830936ejj.516.1621864597690; Mon, 24 May 2021 06:56:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxq0mpI+41JnPNU1+jhy8PAqOk7Rr0AjJRODt2B+GDUy9HDBcyVZhW7k15yjOkD1FtlXjLt9w== X-Received: by 2002:a17:906:710a:: with SMTP id x10mr23830920ejj.516.1621864597507; Mon, 24 May 2021 06:56:37 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id i2sm9176706edc.96.2021.05.24.06.56.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 May 2021 06:56:36 -0700 (PDT) Subject: Re: [PATCH v2 3/7] KVM: nVMX: Ignore 'hv_clean_fields' data when eVMCS data is copied in vmx_get_nested_state() To: Vitaly Kuznetsov , kvm@vger.kernel.org Cc: Sean Christopherson , Wanpeng Li , Jim Mattson , Maxim Levitsky , linux-kernel@vger.kernel.org References: <20210517135054.1914802-1-vkuznets@redhat.com> <20210517135054.1914802-4-vkuznets@redhat.com> From: Paolo Bonzini Message-ID: Date: Mon, 24 May 2021 15:56:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210517135054.1914802-4-vkuznets@redhat.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 17/05/21 15:50, Vitaly Kuznetsov wrote: > 'Clean fields' data from enlightened VMCS is only valid upon vmentry: L1 > hypervisor is not obliged to keep it up-to-date while it is mangling L2's > state, KVM_GET_NESTED_STATE request may come at a wrong moment when actual > eVMCS changes are unsynchronized with 'hv_clean_fields'. As upon migration > VMCS12 is used as a source of ultimate truth, we must make sure we pick all > the changes to eVMCS and thus 'clean fields' data must be ignored. While you're at it, would you mind making copy_vmcs12_to_enlightened and copy_enlightened_to_vmcs12 void? Paolo