From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Stephan Gerhold <stephan@gerhold.net>,
Bjorn Andersson <andersson@kernel.org>
Cc: Andy Gross <agross@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] arm64: dts: qcom: apq8016-sbc-d3-camera: Use more generic node names
Date: Fri, 22 Sep 2023 22:18:40 +0100 [thread overview]
Message-ID: <b7a715aa-eb74-4909-8dae-88d063bee28b@linaro.org> (raw)
In-Reply-To: <20230922-apq8016-sbc-camera-dtso-v1-1-ce9451895ca1@gerhold.net>
On 22/09/2023 16:11, Stephan Gerhold wrote:
> Add "regulator" to the node names of the fixed regulators, and drop the
> "_rear" part of the camera node name since it is not part of the class
> of the device (which is simply "camera").
>
> Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
> ---
> &cci_i2c0 {
> - camera_rear@3b {
> + camera@3b {
> compatible = "ovti,ov5640";
> reg = <0x3b>;
You could consider a follow-up patch here along the lines of
orientation = <2>
to indicate the camera is External.
This shows up with a pretty name in libcamera based applications then.
Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
next prev parent reply other threads:[~2023-09-22 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 15:11 [PATCH 0/2] arm64: dts: qcom: apq8016-sbc-d3-camera: Convert to DT overlay Stephan Gerhold
2023-09-22 15:11 ` [PATCH 1/2] arm64: dts: qcom: apq8016-sbc-d3-camera: Use more generic node names Stephan Gerhold
2023-09-22 21:18 ` Bryan O'Donoghue [this message]
2023-09-22 15:11 ` [PATCH 2/2] arm64: dts: qcom: apq8016-sbc-d3-camera: Convert to DT overlay Stephan Gerhold
2023-09-22 20:47 ` [PATCH 0/2] " Bryan O'Donoghue
2023-09-22 20:58 ` Stephan Gerhold
2023-09-22 21:13 ` Bryan O'Donoghue
2024-01-28 17:45 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7a715aa-eb74-4909-8dae-88d063bee28b@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stephan@gerhold.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®