From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S970197AbdIZTLv (ORCPT ); Tue, 26 Sep 2017 15:11:51 -0400 Received: from mail-dm3nam03on0080.outbound.protection.outlook.com ([104.47.41.80]:28072 "EHLO NAM03-DM3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S968158AbdIZTLt (ORCPT ); Tue, 26 Sep 2017 15:11:49 -0400 Cc: brijesh.singh@amd.com, linux-kernel@vger.kernel.org, x86@kernel.org, kvm@vger.kernel.org, Thomas Gleixner , Ingo Molnar , "H . Peter Anvin" , Andy Lutomirski , Tom Lendacky , "Kirill A. Shutemov" , Laura Abbott , =?UTF-8?B?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , Dan Williams , Kees Cook Subject: Re: [Part1 PATCH v4 10/17] x86/mm, resource: Use PAGE_KERNEL protection for ioremap of memory pages To: Borislav Petkov References: <20170916123418.37807-1-brijesh.singh@amd.com> <20170916123418.37807-11-brijesh.singh@amd.com> <20170917140703.GH4733@nazgul.tnic> From: Brijesh Singh Message-ID: Date: Tue, 26 Sep 2017 14:11:42 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170917140703.GH4733@nazgul.tnic> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [165.204.77.1] X-ClientProxiedBy: CY4PR2201CA0019.namprd22.prod.outlook.com (10.171.208.157) To SN1PR12MB0160.namprd12.prod.outlook.com (10.162.3.147) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 053f747c-3577-489b-f0bd-08d505126e7c X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(48565401081)(2017052603199)(201703131423075)(201703031133081)(201702281549075);SRVR:SN1PR12MB0160; X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;3:UnuN6EWPBQR1XCUBfMVSvV6w6dqP0Y5PaUl7EYvOghFCFQNeh5N4tgHDsAwwvNlQ8Y532MlahKynM52Z/oUS6S6IizVUNLO/nI3TQgcXixgFMSjlLaBubBdMD+uRchBOCNnJr4zUrScNPEDBykjTU9aCd9b3Jly6eACYk7lQFYLqg60gZMGFeSqIXT1PqJXKo5w9dQf0fLLjr0cx8hxGJPc75oIM0LVN72MYGVF1/f9sdrKwFpo0u/P37umyvH8y;25:HuwQcW4e7r9goOS8yu+wI5lRcEm/LDJAfRpnMMSZKy3GwWig53z1z2e6w2I14o2xysU1omY5XWUIThBLInA53gtWcK7oPgP3gmJkD61hKLs6dJ+LVz80AWLxL5zQk9iFRp8VKeNTeeFG0jehbZpKY21pEnVbdAtq4ym3CE6yO+4nc1ohh/JAnEFp/WXXkJomPLBR84g3zbfVQsSG701Jma9JZVA8aoDuT6oLD/dPCdjs+2H/gGLilxj2TrMzChHibP0tQsnPTnjS16r2++ROhA3qETLSD4iDb8bbgQnQ9D6i26knAouE5wbbg9PR+j5Xo/uTC/4SRMLZuT41gE4YuA==;31:wV0AW+Ki66cQBTfAiP6A+7VUTncW05XjEa6QlXorVwrAuUc2qCldaTRKgwFzawGlcw3/P2YUtTw7G2cUsU7Vl8RzxdBvZMbbZOFtBR/4wxyPsg8xDal/2ZqLvQG40K4c6T8+lDC3WWRy8+K7e1CNUPBFf1yYRyAfVQ4ytCRU/Lt8TnKUAm2gAwg/JpodXgO/i+Ai/EtPO0pWsq/JQ0niyeF8pEIYvX2zRb2gNCCP3Co= X-MS-TrafficTypeDiagnostic: SN1PR12MB0160: X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;20:PeRdu+NkAYGFwtTL0u4Vn1K17Gduv+pl8w8DzN/6LtTxJOisj8vL1vwkK70wOLEmjhKQIQ1Kk+K/zH1MSz48pSOub+5meF7ZawjprtCb2V3c81f/1Uj8xdv88p3IVlKoFEqxVuIz5G7424S0BkPjCnK+5vkrxwEYMDJYO3lBdJEw33+GFJxxtl40PxVLAP2FblkJrxfTnnQzaabLn/6qFkZY7wMVgVaSCNI9baVpN06BtgqCZXyhOX39EjDZNjGhWoW6FqMuImoHK763Ocb6bvbjGVgvG5JvltxN3eBHY01FZCsIU27BKqFhjaaIMMyvBwWS00wisfosZJ8ecRGgvoE36YnQ/ICNdQacKmrEk45z3o3XAFboRv98wHcsMOSVgnVg7Md5oHCOZOzVs2GCU4ztrtCsGrPXQTUWdm+dZ+1gKsZkEsw1PH8ffOpp68cKZyS71nXeE0vy3w0D1AY9WyHRb418r0kCXGe78bSKf9XH1VjZJBIuibSVBn5j/1BE;4:nnWt1ylJgRorJJM64cwfspkzAplAbz79PSImV1YRiAWyDyc1zad2BrKQPiBRYeKxtiWuNKxpKloKWlfXBUijcwDZka5xSwzc3HagIrAsmX0fJvjA7r8LrzCRr3+AaqjuK0wci7oP95pZRbw/Jwo1wS/Wtl045fw4BubKnY1TencUnDdKtbCE/2bvWctJiQW/u4/WZ9cqWwiEDCSdHA+oj62KaFyR9QV0VCpZrq4evaNjCO0FFTHsC+WjvJqkTnVK X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(100000703101)(100105400095)(3002001)(6055026)(6041248)(20161123555025)(20161123562025)(20161123560025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:SN1PR12MB0160;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:SN1PR12MB0160; X-Forefront-PRVS: 0442E569BC X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(376002)(39860400002)(346002)(24454002)(189002)(199003)(377454003)(90366009)(53546010)(31686004)(106356001)(31696002)(6116002)(86362001)(65826007)(66066001)(33646002)(3846002)(58126008)(5660300001)(189998001)(16576012)(7736002)(83506001)(316002)(97736004)(64126003)(47776003)(65806001)(65956001)(8936002)(81166006)(230700001)(105586002)(16526017)(81156014)(305945005)(8676002)(50466002)(25786009)(68736007)(50986999)(229853002)(54356999)(76176999)(2906002)(7416002)(77096006)(4326008)(101416001)(6666003)(478600001)(36756003)(6486002)(6246003)(2950100002)(23676002)(54906003)(6916009)(53936002);DIR:OUT;SFP:1101;SCL:1;SRVR:SN1PR12MB0160;H:[10.236.136.62];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=brijesh.singh@amd.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtTTjFQUjEyTUIwMTYwOzIzOnBUcDdRVDJ0VWU2Mk5MVmZVYk5Ic3J1dXdp?= =?utf-8?B?dWt6ZWhjYm81YWpwU1VNZVlJZStOZTFBcDJibXNQSXZ0ZnRmcFNWSmY1dFhT?= =?utf-8?B?cU04Tzg4eDUrWnYwVkxJS2pjM0FmekoydUJTSC9EM2NaYm9QTElxUXB2dlEy?= =?utf-8?B?eHJOWTM4UFQ1enNZQkNMQ3pBam81aFU2UmoxMmI5TTduS1lUK3pQNC8rSUpp?= =?utf-8?B?cTdHbEo2RHord0FQM2N1dW5mT2c0RFo1L0x4b3B5T2p6bmd3dmdlcFRTTTI3?= =?utf-8?B?NUJNM0JQNWY2NjlWVGNVeXg2RkxVSlhOT00zdXNFS3hqb0RUWFVSZ040Umw0?= =?utf-8?B?SnhhTTNGUDI0TnpuSy9NVURESDlZdWdCU2E1K1RyejZWVE4xZUxPRUFPb2FD?= =?utf-8?B?djFuNElDQ3AyL0FlTk1ld2VLM1B4Y0xpTDBKZWhZM1NVeU5LU3BvczNzV1BO?= =?utf-8?B?TWRORmMzNEplNVlLMVdZV3plUVEwWVk4bjJPNUpha3E1QmxKRTE0R3NiR1ls?= =?utf-8?B?aG5QKzJvd3BNN05yRWNoLysyVmlYaldMSy9YQ3RrMUVMT2RRRGtOS0ZjdmQw?= =?utf-8?B?TGZCK3FTUU95TnUyN0w2bC9XTStrRDlUOUp4YUQxa0pmZk82SCtYcExxQnJz?= =?utf-8?B?RXBPNGZueldVa1dCRjl4QUg0ZkJONHZMK280S2VtR2JTZkVTdkk1Y3R4d05u?= =?utf-8?B?a1ZJQzAzbFdYWG9MdU5OUGI3eUJZOS8zZ3U3Y1ZPZGNRdVltc1o3TDNOclJa?= =?utf-8?B?NE11NUIwNEhWNlF3cllnZVgxVmRWd1pDRlMvWEUyUkZZYzVuN0ZuNWhnTkFS?= =?utf-8?B?SWNsMDlhbUdWaXcwUTkrZk5ZM0t6bnlQUlR6ZzVUS3JEWUdkTm9tN2srWjht?= =?utf-8?B?enA4QjNjOTdOVDNrbFZRZTNEUnZoblFscUZFRlEwcDFKVmV5OHpmMlRKWlBJ?= =?utf-8?B?OEI1S3phazBlWGVpNWVUVFBIRjVGeU5wN0k3bXV4ZGdxR0poK0FDQk5nTlk4?= =?utf-8?B?aFJYSDFseDRoY3hKTVJsQU16YVQxVnR6cWEzbjJKb3gxTTljTFVpd1dRZmdW?= =?utf-8?B?VUJpRTVnVkJjYWhvNUNMTi9GTjA2UEdiN285Rkt4bnovTjhzZEY0WnR6MTdk?= =?utf-8?B?UzR1eDJKcEY0TzNwc25leVhXTHdNYmErR2VMcnRSaXNLbTQ3ZTNZQWl3V2hu?= =?utf-8?B?Y3YzWlBBazNLV3BpZVljYWttTGIzMmxNZ0RnREVEWW9XTUtwUUt6Z2diTFZH?= =?utf-8?B?UTlxTlVEbStaeTNFNFYzcGdlajY5VUwwNlZHallPWmM4MGs2aG11TFQ2VkVw?= =?utf-8?B?VjNiL0tETlRMSkI0ajFsNlIzMi9mNGtuc09UUWloYmROT0orb1FPMm9tcUtp?= =?utf-8?B?NllXbmk1dEp1ajZGaUszMHNubnl0NnZMUE1vaWpSdGpYQ0dRQ0VjWVhvdjFI?= =?utf-8?B?SHlicTlja3VCaXZhYU9nT1BIekhRSkRxN0M3c2Z6SDJSUmNCdC8xLzJtZS9t?= =?utf-8?B?bytLOUl1V0x6WUJIQ2xPLzhqYnJ6QVcrcXhqMnlCZVgrdmhxOW9rdm9MQ2Fq?= =?utf-8?B?a3A0c1kvZ3VJNDMyclZuM3N3UE4yMVJId1JDK0lvSVVtRW9HK1dDSnJYbExh?= =?utf-8?B?STRBdTMxOVhPQm40RmpnWHlTaXNSaXVCSlE3QUdOM0VaTnpjRUIzcWs1WEtP?= =?utf-8?B?aGNFdUUzb0JFdHJ4bStPU2QvdE5jN3hybXgrWkRjSUlMSjN2cVZVVUNnNGty?= =?utf-8?B?b2t3eW5MQzRDR2lBQ3pqMjhXbGlQZDluYmJqbDhwVWdQeW5wRU1ZZEZGVFUx?= =?utf-8?B?WXNBdTVIck0yY2NiWlNvU0V1L2RSQk1yNDJPQXJzY3JvQW10Wk82bmF6aU9z?= =?utf-8?B?VEhhaVF6dlEyMHdrc2I4Q0ZscjNlN0tCSTRJdGJHS3hpdjZZMURldFprMzdv?= =?utf-8?B?RVlkWjZRcUJBPT0=?= X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;6:4HbSXMJJltJCKiFg4tqol/nksprx1JzUOcuMeaJ7HYP8vglHoDdWX5X0UJ4xkTtkZd6sdGsr89iF4t0ncVdBwqeZYzp4CfjQCb+SPzwXLT4NggY5RXL7rZtYkJyyPuW0O8YFnfQawurLSzEnnpS2XRjLbblhDW2JcP8gWoCCGVNZwbcZ/QgaK1op5lBUbKicffEB3GK9Zo3ivAMxusm+Ptrs6EqxSoBI8cQFvIQPVGJaFMwhvh9Q15zqMLRC8JtwAEhoo9qcMVzZLKD2aBZPh9hCO6E6zAJrC3MnDgu3s8xGekw878aYG//pOe1wX/LIQwjN1aZ9M47EGfkPNXkDIw==;5:mJuLM+7VFllAMLLkus2VRLrvs6ASx6CyEAItaaASgN3G/gksTDw4MLcDoPdwF31ukmBDS0lTET+eLh7ugomQR5XFYHsC2YvPzri3bi5FLigTtV63zpdh6cuhoh2u8FX4AdT/wMqyvOOaqzCAQv+TqQ==;24:66/UDyRnhVTevkI4J71IN5rm0C9vRVuax5kPb/X6dB79qqph5PoIPwhW44vtEXWGF0B78bhItuJLfa2hmcI0CuDTE+DCtqgPR3FyVLhPZlc=;7:EIhK2ovq8y1POVNaXaH3jvQGVB3B7snZdC8xuzk/c8XEpRdwN9kssGUQ1VA6xfh3jgMP34kzz9r/ALyr1HEYagzsAfjik5rQKKv1PSB9xduMNVaDXoxi5jOPLtyWvF2fPKiX1r967oc4AIkWJSkc3q6G+4l34RvjWorMr7mbNRChgJ50MZRr9MADH6qfS170+h3u6uneVG9Cgm818Ccv2uRsUcPfCIpLDSuGFtf9c9Y= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;SN1PR12MB0160;20:exdvB1ehfRoYWwAsY8wIAJdZEkFzIiy1yEpXEkmvotML5A2KSEHfSWeAbqf3UjIwWcv+SAwPBJDi4FTwqJIhbvXR67xtWgIXKPymI2S7q+lVC4MZVgPw+xJLteXyPgL6dWBF6Q7TPasrMLi64KeiHUVQ03vOPB2x089ADOkIl4j+00Id7bGDrbc+CzYIz9cMoa7Yr5yBa9hGuQfWu1hqjQ2D4pA0Fa1Na2eY3rtT0T4AjIWNcpDKtoJbTnTzefUF X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Sep 2017 19:11:45.4181 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR12MB0160 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/17/2017 09:07 AM, Borislav Petkov wrote: ... >> -static int __ioremap_check_ram(unsigned long start_pfn, unsigned long nr_pages, >> - void *arg) >> +static int __ioremap_check_ram(struct resource *res) >> { >> + unsigned long start_pfn, stop_pfn; >> unsigned long i; >> >> - for (i = 0; i < nr_pages; ++i) >> - if (pfn_valid(start_pfn + i) && >> - !PageReserved(pfn_to_page(start_pfn + i))) >> - return 1; >> + if ((res->flags & IORESOURCE_SYSTEM_RAM) != IORESOURCE_SYSTEM_RAM) >> + return 0; >> + >> + start_pfn = (res->start + PAGE_SIZE - 1) >> PAGE_SHIFT; >> + stop_pfn = (res->end + 1) >> PAGE_SHIFT; >> + if (stop_pfn > start_pfn) { >> + for (i = 0; i < (stop_pfn - start_pfn); ++i) >> + if (pfn_valid(start_pfn + i) && >> + !PageReserved(pfn_to_page(start_pfn + i))) >> + return 1; >> + } >> >> return 0; > > Should return bool I guess. > Yes, I will fix it in next rev. thanks thanks