From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCD7A3A4502 for ; Mon, 13 Apr 2026 08:07:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776067622; cv=none; b=nMUwnI37i54ejMgvJdX6CmHGjymgSWQjErD0qdq/ditfcj5D6D+AEKtprG32Z2uAjELrdfisYTBhUVPje3Hn5mF9jTZWcxKFYT+aljA1lEUGXi0ps8sel5uKGbQCmuvwlWgLL2/CjVrDVrGLg0p29sJ1YpG8L5EprgSEzxi+Y9U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776067622; c=relaxed/simple; bh=RWAnBIoSBVjs/bknciQqBmrJcXvOXa2NfmGL8Kl6siY=; h=Message-ID:Date:MIME-Version:From:Subject:To:Cc:References: In-Reply-To:Content-Type; b=K+Or6lObN0RLdm8S0ZJ0LBMuMcFDu3TH+PGlyAP/PtoXOnFWVAVEBXq3Gcb3Z9e+H9ZBv5tnLjHJ3DQwH4u4nPCNrg5TyPyY08N1XY886MT+j9ieyxTuV1LTBPn6qC4FxPsJVMs5s0EUCaVnCcckiQOWrX4ecZo2uMQOaLoD/nQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=OOscnBwD; arc=none smtp.client-ip=209.85.128.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="OOscnBwD" Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-48374014a77so57730525e9.3 for ; Mon, 13 Apr 2026 01:07:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1776067619; x=1776672419; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=UdgIACL9N5s62AI/UD+N+ywu/reA3cigk1RK/jHdjGA=; b=OOscnBwDJC56J+ZgrheOt+o9JMjeen63WjiUXRcfVOxhUJ850SgVJulPwOr9RPizpa 8QTFhPlttgIsW0U9m+x3vvcWnE+PAxB9dRD183aIhOu2jnXTNrQl04KffsN1LPVEQAtu enu/qh9g4PuZc79NHTevyiONW9qqzSeWlLXo3O8R62zwU6YDITY4ctiShkpvREUeJTnn gBSbT1KXUpN1QdnlFZ5DgoyHuX+XD4cMBaH3BAfnBDkUJS7hMLmZRyt8dHJ/0JcS0Ddc 0SuN2tfPQ7WHV68yEQQuDH9sRokRjp0nkEAARYTrDeorJgoXV510ayGRjg6AA03ajVfJ TKbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776067619; x=1776672419; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:references:cc:to:subject:reply-to:from:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UdgIACL9N5s62AI/UD+N+ywu/reA3cigk1RK/jHdjGA=; b=Lo4623QQzSgbmWTTSjX3TTyCdLbkXmBJbVltBMxqSCkvDDNrvWooSAro8as567dscb 1jUTObpsqHnekGL+unJ6gZ2JY1x8TdWNZgoZgtoDaS0yMqdA1MMQE95+PkH6tW8m1gZj MvxW+Gw6xnpuzK6COikA1m2MhOknaKWY6Xl1hrbMOJS6kpbJwTRG/RUOLJZ0/lXV+iCZ 1tmhEZzipasi8DtQlsxJAQK/9hMryS9GH1knIpn411EqztMm3OYsd/DcgYuHonOn96wR xCrxn9mppzXZfBb+mklZ7RwjksoWWLlHtrsEANL9oc4rEmJyiYcWavcHrM8b189EjQeq Xb+g== X-Forwarded-Encrypted: i=1; AFNElJ/c6cXGm3w4/kWv5nfstsH1nB1C0UzarKc/L9R84aqqkxVNncCGLSu01NjweA/oLjQ6HFzMeYGuG887Tzw=@vger.kernel.org X-Gm-Message-State: AOJu0Ywda24nGxotlg2SWv9wToNvxAfVkpX5evwMZcWaD3dPoxKDmhiy 7YRA+5ZT0cgS8hzm/Oy1OHvwUE/17JS2cMAVMhRcFRb+Cs2D9twu8rn/nCYWqddlQas= X-Gm-Gg: AeBDiesacOuOufXonq2AfbA/4xtANF6kyC9/rqzGz+1smfNFykLiKp+iSTFnIFuqtka Q42rlaHT/rUU6lHOHwk6c/tXfMceCv0jpvDuaDlG0U1MIyNFuwVKcF/9DemhFXr9wGU8a4joy2R iPKvzdzJgxOZw/FLKSNlG92yWqWPmNwS9Tujs5MdoQ9wkKwsmfS9EAwvYjcoPui/t8A8vVNFSOj IugxPUAj5DlX+uh8rLxZRDLLtp3r6InSUXh0IDw7rjsreo70gIatmkYZyDuBDvdT5YYd1LpPbGk mP7eMWeZo/VadntRB836XSdSEkYuHfGuxVNepYr0JAKwQWiZ96+6P6BtqjPK1pE9SkaCfSDHl2H 0vTebr6OHkR7KtvqFMcMy1a6MwgIu241xtDM52dl8J2Yk/fiXb1ipnSZma9gI+iqKv8l37P7eXA tpaUeFIEI5+iUrkq3oRIE/QYoMKyAiQJGJs3PX+yrFKrkcyBncrIQFjKG5T7b288HzkhQKPYKTl 1h1Neg= X-Received: by 2002:a05:600c:528f:b0:488:a82f:bbb4 with SMTP id 5b1f17b1804b1-488d689d0b8mr166171385e9.26.1776067619103; Mon, 13 Apr 2026 01:06:59 -0700 (PDT) Received: from ?IPV6:2a01:cb1c:fcf:4600:4cfb:7427:8a08:9d25? ([2a01:cb1c:fcf:4600:4cfb:7427:8a08:9d25]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-488d683c902sm93012965e9.22.2026.04.13.01.06.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Apr 2026 01:06:58 -0700 (PDT) Message-ID: Date: Mon, 13 Apr 2026 10:06:57 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: neil.armstrong@linaro.org Reply-To: Neil Armstrong Subject: Re: [PATCH v3 2/2] drm/panel: panasonic-vvx10f034n00: transition to mipi_dsi wrapped functions To: Avinal Kumar , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Douglas Anderson , Dmitry Baryshkov Cc: maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch References: <20260113091440.43735-1-avinal.xlvii@gmail.com> <20260113091440.43735-3-avinal.xlvii@gmail.com> Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: <20260113091440.43735-3-avinal.xlvii@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/13/26 10:14, Avinal Kumar wrote: > Changes the panasonic-vvx10f034n00 panel to multi > style functions for improved error handling. > > Signed-off-by: Avinal Kumar > --- > .../gpu/drm/panel/panel-panasonic-vvx10f034n00.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c > index 3c3308fc55df..73c5827a15a4 100644 > --- a/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c > +++ b/drivers/gpu/drm/panel/panel-panasonic-vvx10f034n00.c > @@ -44,14 +44,24 @@ static inline struct wuxga_nt_panel *to_wuxga_nt_panel(struct drm_panel *panel) > > static int wuxga_nt_panel_on(struct wuxga_nt_panel *wuxga_nt) > { > - return mipi_dsi_turn_on_peripheral(wuxga_nt->dsi); > + struct mipi_dsi_multi_context dsi_ctx = { > + .dsi = wuxga_nt->dsi > + }; > + > + mipi_dsi_turn_on_peripheral_multi(&dsi_ctx); > + return dsi_ctx.accum_err; > } > > static int wuxga_nt_panel_disable(struct drm_panel *panel) > { > struct wuxga_nt_panel *wuxga_nt = to_wuxga_nt_panel(panel); > > - return mipi_dsi_shutdown_peripheral(wuxga_nt->dsi); > + struct mipi_dsi_multi_context dsi_ctx = { > + .dsi = wuxga_nt->dsi > + }; > + > + mipi_dsi_shutdown_peripheral_multi(&dsi_ctx); > + return dsi_ctx.accum_err; > } > > static int wuxga_nt_panel_unprepare(struct drm_panel *panel) So yeah we want to use multi functions but in this case I don't think it's appropriate when a since dsi function is called in a callback. Dmitry ? Doug ? Neil