From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 466933D5671 for ; Thu, 9 Apr 2026 15:52:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775749979; cv=none; b=EJszyWNHgF5YJNDPps7ZLMS/frultiv0eHx9Q6QEsudmR7eOjnu3/qXP1PuDV7uMkh3386c0KcQfehiV8j4Clv4LAW49O5/8UOSBLp6yeGb7+Jz/ASZOgYxe1jWdmY329+Qyj+BWKGphX5W8FdEftXqhpFE+Cr1XmgnZdVt0FFw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775749979; c=relaxed/simple; bh=/pvXc5WIJxIAf4hbxTG79yDKdrk8s8Sribq0S9nfTEg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aU8Mxa8hpegIj3/UfA/aD2n0xAS5Qo943FR6AnT90AnIUlfm3kEOuMWpS/9fB6e3ovXSlNqjHEPsG3btm8pCbMQoyOjcOSf874W30xm6nMW6yA/ajGMY9LdmlJ4lY4tSL9+VypHWks7gX+vFzxTHhs339IbC0BflzCjXwrhAI0I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=hWgRkilN; arc=none smtp.client-ip=209.85.208.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="hWgRkilN" Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-38cbe9162f8so631391fa.0 for ; Thu, 09 Apr 2026 08:52:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1775749975; x=1776354775; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=K5p2xo/4m0JDhf++H7DLBizAlziwNWg0BWASCHtSL14=; b=hWgRkilN7uvDud/09oH/2BAyiFtDWBPMCJk4SR7DGkWzxEZDYF69LrX9d2fnpO0fpw hUKUJKrp0xTK7P8yQlJhAS4z+6XvBqcAp4QN2Tl93gdPJkvrpKoTUd2XxYRz4tgBxVGs kR3JAlu0MKD9GMFVNbThce/Mhf6jel3DNXczKlkvk/+S89HufIYtvif1IBkhZ/T4GoOK e00NULCvjDjE9QtL/18ciIXKG6YyE1XhOavSGPV8z1X0elWWg7eR0yt3gmGC91xJZZwl XNK+LUUseRzBp+XCEC0xYwJzUuNjU33vkd8rQ/2hpP0eNIYF8NbvYTT3reaWNIwIJ2+v WeXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775749975; x=1776354775; h=content-transfer-encoding:in-reply-to:from:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=K5p2xo/4m0JDhf++H7DLBizAlziwNWg0BWASCHtSL14=; b=bd5HWpfP5f/2/PIfVacbUg8T/NXUUPQ0KWUc2/1ZLudxSC5rSmctU8YlStVO+Qi6LU Mh42HPVYOuOBQv+MyA+W1N3I1kbmA0dv0IEk4GE2oDbR4ScTk5MiRKE5Ouddxi+iB+yX bWgzXpHMhpQpYPR9LhlSCQcRZt3lRiYNjmwjq0Zsm0Ahx24t9wL4Jdz9yeuXonb7YG9D goIBH9Ejr4LYdiZvendhPaJT0z4ILn0+kqEyT2vBl8tla1A1mnp9s+K3SMgR2ARysUpl 0nSsK1HzjEg81DXjXBtvSaq6e2lGRY7/R39e0MHjgSeYX/doRjH5IMBzcTEjmwfdqTaN 1frQ== X-Forwarded-Encrypted: i=1; AJvYcCUeG1klhF8wpQQE+Kl5yghCk3hIbj8JzA35+3fYF2Xcg75bY20EOkXUSB7dssm0xB6r8RC3R6u0S38zhus=@vger.kernel.org X-Gm-Message-State: AOJu0YwMYH6PFu8wI2+g5wd9Mud4amEdoZaRf3DYAFshfoG2xgo79sOc 2kIddslXZPehZHe4jVN1ouHSxNot2m6PMHrOnmOAb6WrHbehznhyNK//eOkS2QT3+pQ= X-Gm-Gg: AeBDies0KYC5+cOYbmrozj27v//8c5GFdc5QNR4Rs7qa19Sy1c1YlgMHRcT6nmfH4qJ T+sQgJaYhyjVRfSImgrcnYcW6jlNxNBUirQ4HyNTiwicUbWwJ8KYJv+W+GD07e1dLWl6aqrrX9a fhdVz+xhqUxZ2ha7Fb+Q/vJzsgZL2RoBDhmKFCGQ70UpY4JoiQI3oGi5McMH5BdZAKfUf7ol++S /gndV473OR81YmnHO8AIAVGdBypBiTGgGO7TtDbsJS4zkhZeuo/xzyPOBMX4vuKbOUeH00VegNS V39AWLYvnuc/as8+lst0e57NWgIMURxLMZDbV42PWIQSaeqvJ7dt2efuiNqpEw9JoCdrl39H2JM 7finuO/t9JMv9qmZoc31RwYzxGpZg7Spd6U0/MPMPcyouhjYo9Pg2AfRU1rq87k4yU2+RbugMsm Zmft/fBiNgtwNSVpNqJU4p6fL9LkMVB0qBW4oht0K8Llc26yGEG8NweY1J8WBWJE3rjBY/+cg1w AEkjA== X-Received: by 2002:a05:651c:1b06:b0:386:5df3:8195 with SMTP id 38308e7fff4ca-38d9d4c710amr34829731fa.6.1775749975281; Thu, 09 Apr 2026 08:52:55 -0700 (PDT) Received: from [192.168.1.100] (91-159-24-186.elisa-laajakaista.fi. [91.159.24.186]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-38e495ae59bsm188831fa.38.2026.04.09.08.52.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Apr 2026 08:52:54 -0700 (PDT) Message-ID: Date: Thu, 9 Apr 2026 18:52:44 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 1/5] media: qcom: camss: Fix RDI streaming for CSID 680 To: bod@kernel.org, Robert Foss , Todor Tomov , Bryan O'Donoghue , Mauro Carvalho Chehab , Hans Verkuil , Loic Poulain , Hans Verkuil , Gjorgji Rosikopulos , Milen Mitkov , Depeng Shao , Yongsheng Li Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org References: <20260407-camss-rdi-fix-v3-0-08f72d1f3442@kernel.org> <20260407-camss-rdi-fix-v3-1-08f72d1f3442@kernel.org> From: Vladimir Zapolskiy In-Reply-To: <20260407-camss-rdi-fix-v3-1-08f72d1f3442@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/7/26 13:34, bod@kernel.org wrote: > From: Bryan O'Donoghue > > Fix streaming to RDI1 and RDI2. csid->phy.en_vc contains a bitmask of > enabled CSID ports not virtual channels. > > We cycle through the number of available CSID ports and test this value > against the vc_en bitmask. > > We then use the passed value both as an index to the port configuration > macros and as a virtual channel index. > > This is a very broken pattern. Reviewing the initial introduction of VC > support it states that you can only map one CSID to one VFE. This is true > however each CSID has multiple sources which can sink inside of the VFE - > for example there is a "pixel" path for bayer stats which sources @ > CSID(x):3 and sinks on VFE(x):pix. > > That is CSID port # 3 should drive VFE port #3. With our current setup only > a sensor which drives virtual channel number #3 could possibly enable that > setup. > > This is deeply wrong the virtual channel has no relevance to hooking CSID > to VFE, a fact that is proven after this patch is applied allowing > RDI0,RDI1 and RDI2 to function with VC0 whereas before only RDI1 worked. > > Another way the current model breaks is the DT field. A sensor driving > different data-types on the same VC would not be able to separate the VC:DT > pair to separate RDI outputs, thus breaking another feature of VCs in the > MIPI data-stream. > > Default the VC back to zero. A follow on series will implement subdev > streams to actually enable VCs without breaking CSID source to VFE sink. > > Fixes: 253314b20408 ("media: qcom: camss: Add CSID 680 support") > Cc: stable@vger.kernel.org > Signed-off-by: Bryan O'Donoghue Reviewed-by: Vladimir Zapolskiy -- Best wishes, Vladimir