From: Joe Perches <joe@perches.com>
To: Julia Lawall <julia.lawall@lip6.fr>,
Linus Walleij <linus.walleij@linaro.org>
Cc: kbuild-all@01.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] RFC: bus: fix semicolon.cocci warnings
Date: Fri, 15 Jun 2018 11:06:59 -0700 [thread overview]
Message-ID: <b7ace76dba30099151e645aa7496c84dff18b29a.camel@perches.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1806151958100.14023@hadrien>
On Fri, 2018-06-15 at 19:59 +0200, Julia Lawall wrote:
> From: kbuild test robot <fengguang.wu@intel.com>
>
> Remove unneeded semicolon.
[]
> +++ b/drivers/bus/96boards-mezzanines/96boards-secure96.c
> @@ -223,7 +223,7 @@ out_unreg_leds:
> platform_device_unregister(sec->leds_device);
> for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
> mezzanine_ls_put_gpiod(ls, sec->secure96_leds[i].gpiod);
> - };
> + }
> return ERR_PTR(ret);
> }
> EXPORT_SYMBOL_GPL(secure96_populate);
> @@ -244,6 +244,6 @@ void secure96_depopulate(void *data)
> platform_device_unregister(sec->leds_device);
> for (i = 0; i < ARRAY_SIZE(ledinfos); i++) {
> mezzanine_ls_put_gpiod(sec->ls, sec->secure96_leds[i].gpiod);
> - };
> + }
> }
> EXPORT_SYMBOL_GPL(secure96_depopulate);
While these are clearly correct, perhaps it would
be better to remove the braces too.
prev parent reply other threads:[~2018-06-15 18:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-15 17:59 Julia Lawall
2018-06-15 18:06 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7ace76dba30099151e645aa7496c84dff18b29a.camel@perches.com \
--to=joe@perches.com \
--cc=julia.lawall@lip6.fr \
--cc=kbuild-all@01.org \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®