From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A810D53E for ; Mon, 17 Jun 2024 19:54:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718654086; cv=none; b=cKmeDH5rb0sNnbggBl8itM/myiEQ0m2c/GPBcMCfDf/judMYpgIyYr0l5yYx4BWVPLOMxSoOTl3SguGkTr/aHKmvJUYLoTGfFx3LtCTlQWFRrvgZRX41F6z9cK+JqgnsPdwe5Jd15GB4N7vY5kgYMpkHdSVBP5NlQQmyJ2DRPYA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718654086; c=relaxed/simple; bh=Ki+PTbc1GxfDrvhVqHJ57W/XR1v1M3XS3dBT4kzMlkU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Q1EB4ovXzt/4oLEQqlRBdCWeb8x9De5dZPdvi1KiwHUMuWzcHlNhEEidHkUdlG6OIFR12zjCTdB4MqmOdWoykiXE0v68Xafysi8DgPnk3SQeY6CvieFZGvEHtE4YhraKyqLOJZzKf4xIWvKoZN0j6bY0ERSenZ7m5j88GVWMfy0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=chfZ60Dz; arc=none smtp.client-ip=209.85.208.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="chfZ60Dz" Received: by mail-lj1-f181.google.com with SMTP id 38308e7fff4ca-2e72224c395so48440631fa.3 for ; Mon, 17 Jun 2024 12:54:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718654083; x=1719258883; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=D48MDGlr810xqpuSk4MZZtp4IG/NVS2nfRA2oR5Rofk=; b=chfZ60DzE6l/kGOpAr0wAopbA9UTdLa+Scu5MkoUz2z9dUMRlO4g96KOLfddrF4Mog g6YiB4lDm6dpLW8p7UmCfXMW4uCuHgjMtnlnzu0RASkPhQH/hY87K+bukLc26fnimKLE VqPz9j1vZwXYzhBXzx3MkVJ6mDvuEDWptbkpeSNdCTNUaIfvLydPvJI/bPi0ucC9bDjP EjlsXLn73qdggXcdf7QYN8HKgndjjkDWuyT05FnEWENOWSXjWOwVMQ4+ASuDLDqPsZN7 HAWZzoiX7uAqOpoOnIoCytzohez96CIAz0pSrYQQsxP4N3aZuVDF8CEKJJ8mtQi07OiF Eiiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718654083; x=1719258883; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=D48MDGlr810xqpuSk4MZZtp4IG/NVS2nfRA2oR5Rofk=; b=PZzoomdYmop0CHttSTpe0SoAN7FSbk0FjHbcnxZ7EkuG8rXqHpW7uD8hdXv4/Xm5ma MPNFBeP5Npn97LDOWJKx8lzXmemqjZ4jTmlew13JDVgBVG+2v1BTleMd3LCSAVl4AOua m222zNqWuy7Yy19vHIG3S+ABLyrS/JX1q+hu/nt6DTo8gmbcliQa0f0CIPa/AbU5DtMm xpHIB7cBZF5wgOxLx6udH02bSKv1iQ6+32rl5mXMWGKbTrT6qRk2PvUYMDFWUxB95i51 YMIlT5/j3a6V/BdSfzDla4eWWBdkCNUeQKHibMbWobAtBKDeu18ANW7owgyT0YDyuKaV OX4w== X-Forwarded-Encrypted: i=1; AJvYcCXYy5/RRi7WOg2H9PI9xkWdamgyzYB+UF1aw99lnDnx4ZH0a9wN/ufDN5pqKe/dLlrr4zKMrITk5vzB+tbZi6ppcA2bOxyccSFb/hC3 X-Gm-Message-State: AOJu0YxuwAv9Ao241p1FQaQXc2HY88R6j8xJkGO580lIZOq4yJbeBGd2 4s9+CKA0nMX9N4QqZIQXOK2lVuuHT1/f6cStzlCOCj59tpN40dagJN1Ud6S1MCA= X-Google-Smtp-Source: AGHT+IHlIabr4uY5f6ymwX+qGJ4PmeSSEGNGNnK+82sLd5GTqP8sxe4S2CCHMad+L/kqLlQE0QMBcQ== X-Received: by 2002:a2e:9913:0:b0:2ec:35b5:81ce with SMTP id 38308e7fff4ca-2ec35b584c3mr782941fa.32.1718654082758; Mon, 17 Jun 2024 12:54:42 -0700 (PDT) Received: from ?IPV6:2a00:f41:cb2:a9df:5ff5:5bcf:651f:66f5? ([2a00:f41:cb2:a9df:5ff5:5bcf:651f:66f5]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2ec05c8a2a1sm14790851fa.114.2024.06.17.12.54.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jun 2024 12:54:42 -0700 (PDT) Message-ID: Date: Mon, 17 Jun 2024 21:54:39 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 8/8] serial: qcom-geni: Rework TX in FIFO mode to fix hangs/lockups To: Doug Anderson Cc: Greg Kroah-Hartman , Jiri Slaby , Yicong Yang , Tony Lindgren , Andy Shevchenko , Johan Hovold , John Ogness , linux-arm-msm@vger.kernel.org, Bjorn Andersson , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Stephen Boyd , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Rob Herring References: <20240610222515.3023730-1-dianders@chromium.org> <20240610152420.v4.8.I1af05e555c42a9c98435bb7aee0ee60e3dcd015e@changeid> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 6/17/24 21:37, Doug Anderson wrote: > Hi, > > On Mon, Jun 17, 2024 at 12:10 PM Konrad Dybcio wrote: >> >> >> >> On 6/11/24 00:24, Douglas Anderson wrote: >>> The fact that the Qualcomm GENI hardware interface is based around >>> "packets" is really awkward to fit into Linux's UART design. >>> Specifically, in order to send bytes you need to start up a new >>> "command" saying how many bytes you want to send and then you need to >>> send all those bytes. Once you've committed to sending that number of >>> bytes it's very awkward to change your mind and send fewer, especially >>> if you want to do so without dropping bytes on the ground. >> >> [...] >> >> >>> +static void qcom_geni_serial_enable_cmd_done(struct uart_port *uport) >>> +{ >>> + struct qcom_geni_serial_port *port = to_dev_port(uport); >>> + >>> + /* If we're not in FIFO mode we don't use CMD_DONE. */ >>> + if (port->dev_data->mode != GENI_SE_FIFO) >>> + return; >>> + >>> + writel(M_CMD_DONE_EN, uport->membase + SE_GENI_M_IRQ_EN_SET); >>> +} >> >> IDK if this is worth of a separate function, instead of checking for the >> FIFO in port_setup and writing it there, but generally this patch looks >> good to me > > Sure. Somehow it felt weird to me to put it straight in there, but I > could go either way. Do you think I should spin the series just for > this, or just make this change if I happen to need to spin the series > for something else? The latter. Konrad