From: cruzzhao <cruzzhao@linux.alibaba.com>
To: Josh Don <joshdon@google.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Benjamin Segall <bsegall@google.com>,
Mel Gorman <mgorman@suse.de>,
Daniel Bristot de Oliveira <bristot@redhat.com>,
Alexey Dobriyan <adobriyan@gmail.com>,
Eric Dumazet <edumazet@google.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 1/2] sched/core: Cookied forceidle accounting per cpu
Date: Thu, 6 Jan 2022 20:09:47 +0800 [thread overview]
Message-ID: <b7b06597-b3f1-677d-863b-e6cbf6664389@linux.alibaba.com> (raw)
In-Reply-To: <CABk29Nts4sysjmRcnZ_DWmMzhUrianp55Zgf-Nod8m+aUKiWeA@mail.gmail.com>
在 2022/1/6 上午4:47, Josh Don 写道:
> On Wed, Jan 5, 2022 at 3:33 AM cruzzhao <cruzzhao@linux.alibaba.com> wrote:
>
> I don't see how this is very helpful for steal_cookie_task(), since it
> isn't a targeted metric for that specific case. If you were interested
> in that specifically, I'd think you'd want to look at more direct
> metrics, such as task migration counts, or adding some
> accounting/histogram for the time between steal and load balance away.
>
I've already read the patch "sched: CGroup tagging interface for core
scheduling", but it hasn't been merged into linux-next. IMO it's better
to do this at the cgroup level after the cgroup tagging interface is
introduced.
Best,
Cruz Zhao
>
> That motivation makes more sense to me. Have you considered
> accumulating this at the cgroup level (ie. attributing it as another
> type of usage)?
next prev parent reply other threads:[~2022-01-06 12:09 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 12:30 [PATCH 0/2] Forced idle time " Cruz Zhao
2021-12-23 12:30 ` [PATCH 1/2] sched/core: Cookied forceidle " Cruz Zhao
2022-01-05 1:48 ` Josh Don
2022-01-05 11:33 ` cruzzhao
2022-01-05 20:47 ` Josh Don
2022-01-06 12:09 ` cruzzhao [this message]
2022-01-06 19:49 ` Josh Don
2021-12-23 12:30 ` [PATCH 2/2] sched/core: Uncookied force idle " Cruz Zhao
2022-01-05 1:56 ` Josh Don
2022-01-05 11:33 ` cruzzhao
2022-01-05 20:59 ` Josh Don
2022-01-06 12:05 ` cruzzhao
2022-01-06 20:03 ` Josh Don
2021-12-23 12:40 ` [PATCH 0/2] Forced idle time " cruzzhao
2022-01-04 7:15 ` cruzzhao
2022-01-04 17:58 ` Josh Don
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7b06597-b3f1-677d-863b-e6cbf6664389@linux.alibaba.com \
--to=cruzzhao@linux.alibaba.com \
--cc=adobriyan@gmail.com \
--cc=bristot@redhat.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=edumazet@google.com \
--cc=joshdon@google.com \
--cc=juri.lelli@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome