From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5F4A3D47BF for ; Thu, 16 Apr 2026 13:52:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776347567; cv=none; b=hKDvBTho6Lbpj35RJmz0fKPmhDCkNsBriSe6tjoIWwsKh8e+faILhNiAYEjNTrdPwfcxY8wTTnbY5l2QdZN24RVbjEa9VPuBXEPpynZByDr1ZHvdbI7xuOe6o5a2xPoiOxON8v+evnO+aUDyJ3PH41aleozwXRwvGkoy7bXJSnU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776347567; c=relaxed/simple; bh=B70FZ+Ga8PwVGy83BiIRKB7y4GG12RQVNQwTwJXCbn4=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=utZbbVIXsbrSKTYDjxiDfyl42tbf7ZBCl2I7qf9+wnl84ilM60PYu/yzNLO+V3ohs17/FcOyUPsl3juraqVSGJlNVOuFCjlNodxuIrl/rA+uBjuwTT+rvs1dFAd+JQLnp1PWm9L8GVQ4y6Kgvdca9GUCf6w5n7XHKSH56W5PaFs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=pDuIPU58; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=jPctGZyQ; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="pDuIPU58"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="jPctGZyQ" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63G8xn3j4125032 for ; Thu, 16 Apr 2026 13:52:43 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= +OFWZqVzZGSVKYR/6nGUmZmi/+VsR+GRP+LJUeyBYjU=; b=pDuIPU58c4TY3F7n SZFptInWYSXM0aMao40zBx1KsOP0xDNt7CYf0FMjjqrvHa7gWfVfiAhcR2x7KzZG HJ/hdYMcAhlutyD9Gn48ZQ9OKTqfO6VrNs+q8x1zSAWcpI2Thuw8Uybbr29VYbU5 XMEZ0gFCtTO3jtOl+KxPs8skaGXHsqu8cUJkd+bxEBpgj7VBuvENRBLQuqsJ6rjA YMDkfpkHEuaeaiWLyB0OTmgO3eab9ILSsLXYrqRS4DpeMFZEwmim+bfsQA5xrOoV kBNm/snElZGuWNf/MtE9gU/3SLbZspvVlhXvHw2ixJAgZsoiGNRxWPmBSnGe9kRa xNOG4A== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4djvrf8xwh-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 16 Apr 2026 13:52:43 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-8aca2eeac85so19326346d6.3 for ; Thu, 16 Apr 2026 06:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776347562; x=1776952362; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+OFWZqVzZGSVKYR/6nGUmZmi/+VsR+GRP+LJUeyBYjU=; b=jPctGZyQpv37z4zB6wUgC/rVTEsPdobGZuD/silq0fWFNHWG0YREGQnjfeHhWk/vK8 zMS/Sqrski0JYIJ1HyBOXwtJ/XLF4VHmpJJkbtKcVAvzAOnPdMX4iH7+HcgZZQBIDarR 2EWZzd/7nxkrwb9yVkL6c7W6zyoMi0lnZp66mAMIDueP+AZ8mZyccS9FNu81H+ztkGRB CxMbflr5asYalAEskpbYToXy+/gEoUAgLOWpdFmEqnhoOHy2E+9NjWqSFMppHKoO8vK8 ZNHiSgzRK/XsS+Gqph1XufejvUYO9fU74s/oAaxBZx3vZx5mnkAAgngVRRD+FQZfvCAR 0nXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776347562; x=1776952362; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+OFWZqVzZGSVKYR/6nGUmZmi/+VsR+GRP+LJUeyBYjU=; b=A5uh/l6z9GbZNQJvcuELpJOpY0zNpoN5Fjqv3zFLouYbWIx8WQW81VdwMsHq5FBmWJ a/orWlKpOsQIrqNHrcV/H2yHKwkbG+heib5lmlhM6p5W2JAJkizhOE9E/ePT+Q+V3FcJ ErNDeYCXW6VWiNbfW+g19Z4mlsxfzFIYKe5YJskdTe5sJcGIxYvigWKWwutu8cezZqzd Th1PVKxfpzryQhTeUFU8lDLL91w626W2jzBsDlqKmh+yMU122XZmO3l1H/wZ3UcSgw0K TlrZ24d5JmTEFoeAF5S50GSWjv7VF3BdiuLOSoSV1wd5W6YUmjZPcRAjRTaQMwSKQNIB NPNw== X-Forwarded-Encrypted: i=1; AFNElJ/uzSa9Qo2jOXd8rwSxWk59vm2OZ5j/eJMsD2Y2oqCdvz2qHAVNq3m702z85REv14VP1TKDrTrk6n3KqFU=@vger.kernel.org X-Gm-Message-State: AOJu0YyyIxpbw11yDwoMBx9QQ9wwfrXrH9zsfWLlbN5YFMGSlzj8t/ob mh+EitHBMMeGqWSTN3B+6AYQxLmKlUBgy2XPMcm5AcV62EJAjbYtt5NnDLhV6kThRzdQ7NeDCm2 XWjUfrmP8nVG3eD7EAdQ0sQHNaLL0tYyJouoTNkcezxSDEAqLj/HLs2SvG6MpckPr9Xo= X-Gm-Gg: AeBDieuGnGitUCFJ6b17hFolUP02sjF4rpKHI5M9d38rTsYJbbRvrtKQ0QRva/q+TNZ VimewBb96oMAN6MZDVnmew/G3iBFLkreGQnhldfJBVkpblckbCpWfk0ydQpYAs1BOSp1ngShB49 x2fbs7nc2R1q182VTWH+U6jiKPEVFVAcY6bFvy7DO4ZOgifeOmFXI77LByHQjrY8/e+3aMAwqIk UGYdbSMtLcL0g5KLW/JFeQEtW4GWP8f7j/llFX2zFeFV2mpmdI2WTg2Peh7Xovu4TdOWclvAtrt pilraEf1yIqYfbbi3v+wHIuS1lq4C1V26MaDrQepGrNSWEVz2lWtmeV8ExkAKFntAnKlxq709WF Wn8hBSzD04neGgfaH8cU9PQVhuR0FVzJpI7eTAEWs5u3XpOg+bF0eIS89R+VKdP2cHFixwdsoZx PrikoY4CB5tMkntA== X-Received: by 2002:a05:622a:481a:b0:50b:2275:8c1f with SMTP id d75a77b69052e-50e28cf24f4mr24101491cf.0.1776347562449; Thu, 16 Apr 2026 06:52:42 -0700 (PDT) X-Received: by 2002:a05:622a:481a:b0:50b:2275:8c1f with SMTP id d75a77b69052e-50e28cf24f4mr24100991cf.0.1776347561884; Thu, 16 Apr 2026 06:52:41 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ba170629d7bsm171699866b.0.2026.04.16.06.52.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2026 06:52:40 -0700 (PDT) Message-ID: Date: Thu, 16 Apr 2026 15:52:37 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 00/10] media: qcom: venus: add MSM8939 support To: Erikas Bitovtas , Bryan O'Donoghue , Vikash Garodia , Dikshita Agarwal , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , =?UTF-8?Q?Andr=C3=A9_Apitzsch?= , Bjorn Andersson , Konrad Dybcio , Michael Turquette , Stephen Boyd Cc: linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org References: <20260416-msm8939-venus-rfc-v1-0-a09fcf2c23df@gmail.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260416-msm8939-venus-rfc-v1-0-a09fcf2c23df@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: GORKJuwHoQS0HVZF-RTNzgl0622uD-y5 X-Proofpoint-ORIG-GUID: GORKJuwHoQS0HVZF-RTNzgl0622uD-y5 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDE2MDEzMyBTYWx0ZWRfXwf4eHVxiINdH 62A6JFF804P9s/3NVobrbdT8kn/LxREvUM7KMQfL0FkBL+o8EhDc8BiJNG0dW0u/IYu1vHHgMDn WlsyY2XSA3WjmJn2GiwpeC1BN7er2CBo0g4ZTTnRk/ZicF0kd6F6/Q9kGhhZHUp976LmRY75FPH 436GiOQ4kWG7fWYtvHgRlgtA58RagvxlV8GcUgdZbRIHA1FRk+zE8NfYvy4RRWQUYs4sumq/9sX 1i72R5F9Jzch2zEA3V/tSyI0MD+PPhCqljQUdBLX1bzwjAurBtymCTz6MRmsOmw8U9SDmXoJrvo 9vc++vjpAX0DPAR1g+r4xP0eFCkJ3oEXgnf++7mPAJiReT/L2RtnEkcBroTKpWOouuKB5+nyQlz ls/X0ZDcnJBdc/rR4yTY1Do5yvm/hYyuVBlzILbh4fBZy7S4VXlHfANasocsJxlNJC4sZonp1qO s3Rkl78GCrO5Sa8Xtlw== X-Authority-Analysis: v=2.4 cv=YtE/gYYX c=1 sm=1 tr=0 ts=69e0e9ab cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=gowsoOTTUOVcmtlkKump:22 a=Hal5A9k0WOgLizwzjeAA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-16_03,2026-04-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 phishscore=0 lowpriorityscore=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 clxscore=1015 priorityscore=1501 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604070000 definitions=main-2604160133 On 4/16/26 3:43 PM, Erikas Bitovtas wrote: > This patch series adds support for Venus on MSM8939. It is mostly > similar to MSM8916 Venus, except it needs two additional cores to be > powered on before it can start decoding. > > This patch series is marked as an RFC. Before submitting a non-RFC > series, I would like to have some details clarified regarding how Venus > works in order to improve and eventually upstream support for MSM8939. > > 1. In downstream, particularly in LA.BR.1.2.9.1_rb1.5, the buses > for vcodec0 cores have only decoding bits enabled, as depicted > by qcom,bus-configs property of qcom,msm-bus-clients children > in qcom,vidc node. Do I understand correctly that these cores > are only needed for decoding, and not for encoding? > 2. Currently in device tree there is a video-decoder subnode for Venus > node, however, for SDM845-v2 (and newer) chipsets, Venus does not use > subnodes. Does this mean it should be dropped for MSM8939 as well? > 3. MSM8939 supports HEVC decoding, however, as the patchset is written > now, it does not work. It can be enabled, however, it will result in > breakage of Venus for faulty MSM8916 firmwares, because the code > disabling HEVC for HFI v1 needs to be removed, and as per commit > c50cc6dc6c48 ("media: venus: hfi_parser: Ignore HEVC encoding for V1"), > this would break support for some MSM8916 devices. What could be the > best way to work around this? if (!device_is_compatible(core->dev, "qcom,msm8939-venus"))? Also, you mentioned HEVC *de*coding, while the commit you pointed to disables *en*coding (decoding had been already disabled prior to that commit) Konrad